4d3fc8b057
This release fixes a number of security bugs and has minor new features and bug fixes. Security fixes, from the release notes (https://www.openssh.com/txt/release-9.3): This release contains fixes for a security problem and a memory safety problem. The memory safety problem is not believed to be exploitable, but we report most network-reachable memory faults as security bugs. * ssh-add(1): when adding smartcard keys to ssh-agent(1) with the per-hop destination constraints (ssh-add -h ...) added in OpenSSH 8.9, a logic error prevented the constraints from being communicated to the agent. This resulted in the keys being added without constraints. The common cases of non-smartcard keys and keys without destination constraints are unaffected. This problem was reported by Luci Stanescu. * ssh(1): Portable OpenSSH provides an implementation of the getrrsetbyname(3) function if the standard library does not provide it, for use by the VerifyHostKeyDNS feature. A specifically crafted DNS response could cause this function to perform an out-of-bounds read of adjacent stack data, but this condition does not appear to be exploitable beyond denial-of- service to the ssh(1) client. The getrrsetbyname(3) replacement is only included if the system's standard library lacks this function and portable OpenSSH was not compiled with the ldns library (--with-ldns). getrrsetbyname(3) is only invoked if using VerifyHostKeyDNS to fetch SSHFP records. This problem was found by the Coverity static analyzer. Sponsored by: The FreeBSD Foundation
84 lines
2.2 KiB
C
84 lines
2.2 KiB
C
/*
|
|
* Copyright (c) 1996, David Mazieres <dm@uun.org>
|
|
* Copyright (c) 2008, Damien Miller <djm@openbsd.org>
|
|
* Copyright (c) 2013, Markus Friedl <markus@openbsd.org>
|
|
*
|
|
* Permission to use, copy, modify, and distribute this software for any
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
* copyright notice and this permission notice appear in all copies.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
|
|
#include "includes.h"
|
|
|
|
#ifndef SSH_RANDOM_DEV
|
|
# define SSH_RANDOM_DEV "/dev/urandom"
|
|
#endif /* SSH_RANDOM_DEV */
|
|
|
|
#include <sys/types.h>
|
|
#ifdef HAVE_SYS_RANDOM_H
|
|
# include <sys/random.h>
|
|
#endif
|
|
|
|
#include <fcntl.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#ifdef WITH_OPENSSL
|
|
#include <openssl/rand.h>
|
|
#include <openssl/err.h>
|
|
#endif
|
|
|
|
#include "log.h"
|
|
|
|
int
|
|
_ssh_compat_getentropy(void *s, size_t len)
|
|
{
|
|
#ifdef WITH_OPENSSL
|
|
if (RAND_bytes(s, len) <= 0)
|
|
fatal("Couldn't obtain random bytes (error 0x%lx)",
|
|
(unsigned long)ERR_get_error());
|
|
#else
|
|
int fd, save_errno;
|
|
ssize_t r;
|
|
size_t o = 0;
|
|
|
|
#ifdef HAVE_GETENTROPY
|
|
if ((r = getentropy(s, len)) == 0)
|
|
return 0;
|
|
#endif /* HAVE_GETENTROPY */
|
|
#ifdef HAVE_GETRANDOM
|
|
if ((r = getrandom(s, len, 0)) > 0 && (size_t)r == len)
|
|
return 0;
|
|
#endif /* HAVE_GETRANDOM */
|
|
|
|
if ((fd = open(SSH_RANDOM_DEV, O_RDONLY)) == -1) {
|
|
save_errno = errno;
|
|
/* Try egd/prngd before giving up. */
|
|
if (seed_from_prngd(s, len) == 0)
|
|
return 0;
|
|
fatal("Couldn't open %s: %s", SSH_RANDOM_DEV,
|
|
strerror(save_errno));
|
|
}
|
|
while (o < len) {
|
|
r = read(fd, (u_char *)s + o, len - o);
|
|
if (r < 0) {
|
|
if (errno == EAGAIN || errno == EINTR ||
|
|
errno == EWOULDBLOCK)
|
|
continue;
|
|
fatal("read %s: %s", SSH_RANDOM_DEV, strerror(errno));
|
|
}
|
|
o += r;
|
|
}
|
|
close(fd);
|
|
#endif /* WITH_OPENSSL */
|
|
return 0;
|
|
}
|