d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
469019fb0b
freebsd-dev/module/zcommon/zfs_fletcher_superscalar4.c
Rich Ercolani 0ad5f43442
Drop lying to the compiler in the fletcher4 code 
This is probably the uncontroversial part of #13631, which fixes
a real problem people are having.

There's still things to improve in our code after this is merged,
but it should stop the breakage that people have reported, where
we lie about a type always being aligned and then pass in stack
objects with no alignment requirement and hope for the best.

Of course, our SIMD code was written with unaligned accesses, so it
doesn't care if we drop this...but some auto-vectorized code that
gcc emits sure does, since we told it it can assume they're aligned.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes #14649
2023-03-24 10:29:19 -07:00

231 lines
6.9 KiB
C
Raw Blame History

/*
* Implement fast Fletcher4 using superscalar pipelines.
*
* Use regular C code to compute
* Fletcher4 in four incremental 64-bit parallel accumulator streams,
* and then combine the streams to form the final four checksum words.
* This implementation is a derivative of the AVX SIMD implementation by
* James Guilford and Jinshan Xiong from Intel (see zfs_fletcher_intel.c).
*
* Copyright (C) 2016 Romain Dolbeau.
*
* Authors:
* Romain Dolbeau <romain.dolbeau@atos.net>
*
* This software is available to you under a choice of one of two
* licenses. You may choose to be licensed under the terms of the GNU
* General Public License (GPL) Version 2, available from the file
* COPYING in the main directory of this source tree, or the
* OpenIB.org BSD license below:
*
* Redistribution and use in source and binary forms, with or
* without modification, are permitted provided that the following
* conditions are met:
*
* - Redistributions of source code must retain the above
* copyright notice, this list of conditions and the following
* disclaimer.
*
* - Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the following
* disclaimer in the documentation and/or other materials
* provided with the distribution.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
#include <sys/param.h>
#include <sys/byteorder.h>
#include <sys/spa_checksum.h>
#include <sys/string.h>
#include <zfs_fletcher.h>
static void
fletcher_4_superscalar4_init(fletcher_4_ctx_t *ctx)
{
memset(ctx->superscalar, 0, 4 * sizeof (zfs_fletcher_superscalar_t));
}
static void
fletcher_4_superscalar4_fini(fletcher_4_ctx_t *ctx, zio_cksum_t *zcp)
{
uint64_t A, B, C, D;
A = ctx->superscalar[0].v[0] + ctx->superscalar[0].v[1] +
ctx->superscalar[0].v[2] + ctx->superscalar[0].v[3];
B = 0 - ctx->superscalar[0].v[1] - 2 * ctx->superscalar[0].v[2] -
3 * ctx->superscalar[0].v[3] + 4 * ctx->superscalar[1].v[0] +
4 * ctx->superscalar[1].v[1] + 4 * ctx->superscalar[1].v[2] +
4 * ctx->superscalar[1].v[3];
C = ctx->superscalar[0].v[2] + 3 * ctx->superscalar[0].v[3] -
6 * ctx->superscalar[1].v[0] - 10 * ctx->superscalar[1].v[1] -
14 * ctx->superscalar[1].v[2] - 18 * ctx->superscalar[1].v[3] +
16 * ctx->superscalar[2].v[0] + 16 * ctx->superscalar[2].v[1] +
16 * ctx->superscalar[2].v[2] + 16 * ctx->superscalar[2].v[3];
D = 0 - ctx->superscalar[0].v[3] + 4 * ctx->superscalar[1].v[0] +
10 * ctx->superscalar[1].v[1] + 20 * ctx->superscalar[1].v[2] +
34 * ctx->superscalar[1].v[3] - 48 * ctx->superscalar[2].v[0] -
64 * ctx->superscalar[2].v[1] - 80 * ctx->superscalar[2].v[2] -
96 * ctx->superscalar[2].v[3] + 64 * ctx->superscalar[3].v[0] +
64 * ctx->superscalar[3].v[1] + 64 * ctx->superscalar[3].v[2] +
64 * ctx->superscalar[3].v[3];
ZIO_SET_CHECKSUM(zcp, A, B, C, D);
}
static void
fletcher_4_superscalar4_native(fletcher_4_ctx_t *ctx,
const void *buf, uint64_t size)
{
const uint32_t *ip = buf;
const uint32_t *ipend = ip + (size / sizeof (uint32_t));
uint64_t a, b, c, d;
uint64_t a2, b2, c2, d2;
uint64_t a3, b3, c3, d3;
uint64_t a4, b4, c4, d4;
a = ctx->superscalar[0].v[0];
b = ctx->superscalar[1].v[0];
c = ctx->superscalar[2].v[0];
d = ctx->superscalar[3].v[0];
a2 = ctx->superscalar[0].v[1];
b2 = ctx->superscalar[1].v[1];
c2 = ctx->superscalar[2].v[1];
d2 = ctx->superscalar[3].v[1];
a3 = ctx->superscalar[0].v[2];
b3 = ctx->superscalar[1].v[2];
c3 = ctx->superscalar[2].v[2];
d3 = ctx->superscalar[3].v[2];
a4 = ctx->superscalar[0].v[3];
b4 = ctx->superscalar[1].v[3];
c4 = ctx->superscalar[2].v[3];
d4 = ctx->superscalar[3].v[3];
do {
a += ip[0];
a2 += ip[1];
a3 += ip[2];
a4 += ip[3];
b += a;
b2 += a2;
b3 += a3;
b4 += a4;
c += b;
c2 += b2;
c3 += b3;
c4 += b4;
d += c;
d2 += c2;
d3 += c3;
d4 += c4;
} while ((ip += 4) < ipend);
ctx->superscalar[0].v[0] = a;
ctx->superscalar[1].v[0] = b;
ctx->superscalar[2].v[0] = c;
ctx->superscalar[3].v[0] = d;
ctx->superscalar[0].v[1] = a2;
ctx->superscalar[1].v[1] = b2;
ctx->superscalar[2].v[1] = c2;
ctx->superscalar[3].v[1] = d2;
ctx->superscalar[0].v[2] = a3;
ctx->superscalar[1].v[2] = b3;
ctx->superscalar[2].v[2] = c3;
ctx->superscalar[3].v[2] = d3;
ctx->superscalar[0].v[3] = a4;
ctx->superscalar[1].v[3] = b4;
ctx->superscalar[2].v[3] = c4;
ctx->superscalar[3].v[3] = d4;
}
static void
fletcher_4_superscalar4_byteswap(fletcher_4_ctx_t *ctx,
const void *buf, uint64_t size)
{
const uint32_t *ip = buf;
const uint32_t *ipend = ip + (size / sizeof (uint32_t));
uint64_t a, b, c, d;
uint64_t a2, b2, c2, d2;
uint64_t a3, b3, c3, d3;
uint64_t a4, b4, c4, d4;
a = ctx->superscalar[0].v[0];
b = ctx->superscalar[1].v[0];
c = ctx->superscalar[2].v[0];
d = ctx->superscalar[3].v[0];
a2 = ctx->superscalar[0].v[1];
b2 = ctx->superscalar[1].v[1];
c2 = ctx->superscalar[2].v[1];
d2 = ctx->superscalar[3].v[1];
a3 = ctx->superscalar[0].v[2];
b3 = ctx->superscalar[1].v[2];
c3 = ctx->superscalar[2].v[2];
d3 = ctx->superscalar[3].v[2];
a4 = ctx->superscalar[0].v[3];
b4 = ctx->superscalar[1].v[3];
c4 = ctx->superscalar[2].v[3];
d4 = ctx->superscalar[3].v[3];
do {
a += BSWAP_32(ip[0]);
a2 += BSWAP_32(ip[1]);
a3 += BSWAP_32(ip[2]);
a4 += BSWAP_32(ip[3]);
b += a;
b2 += a2;
b3 += a3;
b4 += a4;
c += b;
c2 += b2;
c3 += b3;
c4 += b4;
d += c;
d2 += c2;
d3 += c3;
d4 += c4;
} while ((ip += 4) < ipend);
ctx->superscalar[0].v[0] = a;
ctx->superscalar[1].v[0] = b;
ctx->superscalar[2].v[0] = c;
ctx->superscalar[3].v[0] = d;
ctx->superscalar[0].v[1] = a2;
ctx->superscalar[1].v[1] = b2;
ctx->superscalar[2].v[1] = c2;
ctx->superscalar[3].v[1] = d2;
ctx->superscalar[0].v[2] = a3;
ctx->superscalar[1].v[2] = b3;
ctx->superscalar[2].v[2] = c3;
ctx->superscalar[3].v[2] = d3;
ctx->superscalar[0].v[3] = a4;
ctx->superscalar[1].v[3] = b4;
ctx->superscalar[2].v[3] = c4;
ctx->superscalar[3].v[3] = d4;
}
static boolean_t fletcher_4_superscalar4_valid(void)
{
return (B_TRUE);
}
const fletcher_4_ops_t fletcher_4_superscalar4_ops = {
.init_native = fletcher_4_superscalar4_init,
.compute_native = fletcher_4_superscalar4_native,
.fini_native = fletcher_4_superscalar4_fini,
.init_byteswap = fletcher_4_superscalar4_init,
.compute_byteswap = fletcher_4_superscalar4_byteswap,
.fini_byteswap = fletcher_4_superscalar4_fini,
.valid = fletcher_4_superscalar4_valid,
.uses_fpu = B_FALSE,
.name = "superscalar4"
};
Reference in New Issue View Git Blame Copy Permalink