ed549cb0c5
The following issues are patched: - CVE-2022-42898 PAC parse integer overflows - CVE-2022-3437 Overflows and non-constant time leaks in DES{,3} and arcfour - CVE-2021-44758 NULL dereference DoS in SPNEGO acceptors - CVE-2022-44640 Heimdal KDC: invalid free in ASN.1 codec Note that CVE-2022-44640 is a severe vulnerability, possibly a 10.0 on the Common Vulnerability Scoring System (CVSS) v3, as we believe it should be possible to get an RCE on a KDC, which means that credentials can be compromised that can be used to impersonate anyone in a realm or forest of realms. Heimdal's ASN.1 compiler generates code that allows specially crafted DER encodings of CHOICEs to invoke the wrong free function on the decoded structure upon decode error. This is known to impact the Heimdal KDC, leading to an invalid free() of an address partly or wholly under the control of the attacker, in turn leading to a potential remote code execution (RCE) vulnerability. This error affects the DER codec for all extensible CHOICE types used in Heimdal, though not all cases will be exploitable. We have not completed a thorough analysis of all the Heimdal components affected, thus the Kerberos client, the X.509 library, and other parts, may be affected as well. This bug has been in Heimdal's ASN.1 compiler since 2005, but it may only affect Heimdal 1.6 and up. It was first reported by Douglas Bagnall, though it had been found independently by the Heimdal maintainers via fuzzing a few weeks earlier. While no zero-day exploit is known, such an exploit will likely be available soon after public disclosure. - CVE-2019-14870: Validate client attributes in protocol-transition - CVE-2019-14870: Apply forwardable policy in protocol-transition - CVE-2019-14870: Always lookup impersonate client in DB Sponsored by: so (philip) Obtained from: so (philip) Tested by: philip, cy MFC after: immediately
271 lines
7.9 KiB
C
271 lines
7.9 KiB
C
/*
|
|
* Copyright (c) 1997 - 2006 Kungliga Tekniska Högskolan
|
|
* (Royal Institute of Technology, Stockholm, Sweden).
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* 3. Neither the name of the Institute nor the names of its contributors
|
|
* may be used to endorse or promote products derived from this software
|
|
* without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE INSTITUTE AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE INSTITUTE OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "kadmin_locl.h"
|
|
#include "kadmin-commands.h"
|
|
|
|
static void
|
|
add_tl(kadm5_principal_ent_rec *princ, int type, krb5_data *data)
|
|
{
|
|
krb5_tl_data *tl, **ptl;
|
|
|
|
tl = ecalloc(1, sizeof(*tl));
|
|
tl->tl_data_next = NULL;
|
|
tl->tl_data_type = KRB5_TL_EXTENSION;
|
|
tl->tl_data_length = data->length;
|
|
tl->tl_data_contents = data->data;
|
|
|
|
princ->n_tl_data++;
|
|
ptl = &princ->tl_data;
|
|
while (*ptl != NULL)
|
|
ptl = &(*ptl)->tl_data_next;
|
|
*ptl = tl;
|
|
|
|
return;
|
|
}
|
|
|
|
static void
|
|
add_constrained_delegation(krb5_context contextp,
|
|
kadm5_principal_ent_rec *princ,
|
|
struct getarg_strings *strings)
|
|
{
|
|
krb5_error_code ret;
|
|
HDB_extension ext;
|
|
krb5_data buf;
|
|
size_t size = 0;
|
|
|
|
memset(&ext, 0, sizeof(ext));
|
|
ext.mandatory = FALSE;
|
|
ext.data.element = choice_HDB_extension_data_allowed_to_delegate_to;
|
|
|
|
if (strings->num_strings == 1 && strings->strings[0][0] == '\0') {
|
|
ext.data.u.allowed_to_delegate_to.val = NULL;
|
|
ext.data.u.allowed_to_delegate_to.len = 0;
|
|
} else {
|
|
krb5_principal p;
|
|
int i;
|
|
|
|
ext.data.u.allowed_to_delegate_to.val =
|
|
calloc(strings->num_strings,
|
|
sizeof(ext.data.u.allowed_to_delegate_to.val[0]));
|
|
ext.data.u.allowed_to_delegate_to.len = strings->num_strings;
|
|
|
|
for (i = 0; i < strings->num_strings; i++) {
|
|
ret = krb5_parse_name(contextp, strings->strings[i], &p);
|
|
if (ret)
|
|
abort();
|
|
ret = copy_Principal(p, &ext.data.u.allowed_to_delegate_to.val[i]);
|
|
if (ret)
|
|
abort();
|
|
krb5_free_principal(contextp, p);
|
|
}
|
|
}
|
|
|
|
ASN1_MALLOC_ENCODE(HDB_extension, buf.data, buf.length,
|
|
&ext, &size, ret);
|
|
free_HDB_extension(&ext);
|
|
if (ret)
|
|
abort();
|
|
if (buf.length != size)
|
|
abort();
|
|
|
|
add_tl(princ, KRB5_TL_EXTENSION, &buf);
|
|
}
|
|
|
|
static void
|
|
add_aliases(krb5_context contextp, kadm5_principal_ent_rec *princ,
|
|
struct getarg_strings *strings)
|
|
{
|
|
krb5_error_code ret = 0;
|
|
HDB_extension ext;
|
|
krb5_data buf;
|
|
krb5_principal p;
|
|
size_t size = 0;
|
|
int i;
|
|
|
|
memset(&ext, 0, sizeof(ext));
|
|
ext.mandatory = FALSE;
|
|
ext.data.element = choice_HDB_extension_data_aliases;
|
|
ext.data.u.aliases.case_insensitive = 0;
|
|
|
|
if (strings->num_strings == 1 && strings->strings[0][0] == '\0') {
|
|
ext.data.u.aliases.aliases.val = NULL;
|
|
ext.data.u.aliases.aliases.len = 0;
|
|
} else {
|
|
ext.data.u.aliases.aliases.val =
|
|
calloc(strings->num_strings,
|
|
sizeof(ext.data.u.aliases.aliases.val[0]));
|
|
ext.data.u.aliases.aliases.len = strings->num_strings;
|
|
|
|
for (i = 0; ret == 0 && i < strings->num_strings; i++) {
|
|
ret = krb5_parse_name(contextp, strings->strings[i], &p);
|
|
if (ret)
|
|
krb5_err(contextp, 1, ret, "Could not parse alias %s",
|
|
strings->strings[i]);
|
|
if (ret == 0)
|
|
ret = copy_Principal(p, &ext.data.u.aliases.aliases.val[i]);
|
|
if (ret)
|
|
krb5_err(contextp, 1, ret, "Could not copy parsed alias %s",
|
|
strings->strings[i]);
|
|
krb5_free_principal(contextp, p);
|
|
}
|
|
}
|
|
|
|
ASN1_MALLOC_ENCODE(HDB_extension, buf.data, buf.length,
|
|
&ext, &size, ret);
|
|
free_HDB_extension(&ext);
|
|
if (ret)
|
|
abort();
|
|
if (buf.length != size)
|
|
abort();
|
|
|
|
add_tl(princ, KRB5_TL_EXTENSION, &buf);
|
|
}
|
|
|
|
static void
|
|
add_pkinit_acl(krb5_context contextp, kadm5_principal_ent_rec *princ,
|
|
struct getarg_strings *strings)
|
|
{
|
|
krb5_error_code ret;
|
|
HDB_extension ext;
|
|
krb5_data buf;
|
|
size_t size = 0;
|
|
int i;
|
|
|
|
memset(&ext, 0, sizeof(ext));
|
|
ext.mandatory = FALSE;
|
|
ext.data.element = choice_HDB_extension_data_pkinit_acl;
|
|
ext.data.u.aliases.case_insensitive = 0;
|
|
|
|
if (strings->num_strings == 1 && strings->strings[0][0] == '\0') {
|
|
ext.data.u.pkinit_acl.val = NULL;
|
|
ext.data.u.pkinit_acl.len = 0;
|
|
} else {
|
|
ext.data.u.pkinit_acl.val =
|
|
calloc(strings->num_strings,
|
|
sizeof(ext.data.u.pkinit_acl.val[0]));
|
|
ext.data.u.pkinit_acl.len = strings->num_strings;
|
|
|
|
for (i = 0; i < strings->num_strings; i++) {
|
|
ext.data.u.pkinit_acl.val[i].subject = estrdup(strings->strings[i]);
|
|
}
|
|
}
|
|
|
|
ASN1_MALLOC_ENCODE(HDB_extension, buf.data, buf.length,
|
|
&ext, &size, ret);
|
|
free_HDB_extension(&ext);
|
|
if (ret)
|
|
abort();
|
|
if (buf.length != size)
|
|
abort();
|
|
|
|
add_tl(princ, KRB5_TL_EXTENSION, &buf);
|
|
}
|
|
|
|
static int
|
|
do_mod_entry(krb5_principal principal, void *data)
|
|
{
|
|
krb5_error_code ret;
|
|
kadm5_principal_ent_rec princ;
|
|
int mask = 0;
|
|
struct modify_options *e = data;
|
|
|
|
memset (&princ, 0, sizeof(princ));
|
|
ret = kadm5_get_principal(kadm_handle, principal, &princ,
|
|
KADM5_PRINCIPAL | KADM5_ATTRIBUTES |
|
|
KADM5_MAX_LIFE | KADM5_MAX_RLIFE |
|
|
KADM5_PRINC_EXPIRE_TIME |
|
|
KADM5_PW_EXPIRATION);
|
|
if(ret)
|
|
return ret;
|
|
|
|
if(e->max_ticket_life_string ||
|
|
e->max_renewable_life_string ||
|
|
e->expiration_time_string ||
|
|
e->pw_expiration_time_string ||
|
|
e->attributes_string ||
|
|
e->kvno_integer != -1 ||
|
|
e->constrained_delegation_strings.num_strings ||
|
|
e->alias_strings.num_strings ||
|
|
e->pkinit_acl_strings.num_strings) {
|
|
ret = set_entry(context, &princ, &mask,
|
|
e->max_ticket_life_string,
|
|
e->max_renewable_life_string,
|
|
e->expiration_time_string,
|
|
e->pw_expiration_time_string,
|
|
e->attributes_string);
|
|
if(e->kvno_integer != -1) {
|
|
princ.kvno = e->kvno_integer;
|
|
mask |= KADM5_KVNO;
|
|
}
|
|
if (e->constrained_delegation_strings.num_strings) {
|
|
add_constrained_delegation(context, &princ,
|
|
&e->constrained_delegation_strings);
|
|
mask |= KADM5_TL_DATA;
|
|
}
|
|
if (e->alias_strings.num_strings) {
|
|
add_aliases(context, &princ, &e->alias_strings);
|
|
mask |= KADM5_TL_DATA;
|
|
}
|
|
if (e->pkinit_acl_strings.num_strings) {
|
|
add_pkinit_acl(context, &princ, &e->pkinit_acl_strings);
|
|
mask |= KADM5_TL_DATA;
|
|
}
|
|
|
|
} else
|
|
ret = edit_entry(&princ, &mask, NULL, 0);
|
|
if(ret == 0) {
|
|
ret = kadm5_modify_principal(kadm_handle, &princ, mask);
|
|
if(ret)
|
|
krb5_warn(context, ret, "kadm5_modify_principal");
|
|
}
|
|
|
|
kadm5_free_principal_ent(kadm_handle, &princ);
|
|
return ret;
|
|
}
|
|
|
|
int
|
|
mod_entry(struct modify_options *opt, int argc, char **argv)
|
|
{
|
|
krb5_error_code ret = 0;
|
|
int i;
|
|
|
|
for(i = 0; i < argc; i++) {
|
|
ret = foreach_principal(argv[i], do_mod_entry, "mod", opt);
|
|
if (ret)
|
|
break;
|
|
}
|
|
return ret != 0;
|
|
}
|
|
|