FreeBSD src
Go to file
Mark Johnston 4cbba6ae24 MFOpenZFS: Fix zpool history unbounded memory usage
In original implementation, zpool history will read the whole history
before printing anything, causing memory usage goes unbounded. We fix
this by breaking it into read-print iterations.

Reviewed-by: Tom Caputi <tcaputi@datto.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@nutanix.com>
Closes #9516

Note, this change changes the libzfs.so ABI by modifying the prototype
of zpool_get_history().  Since libzfs is effectively private to the base
system it is anticipated that this will not be a problem.

PR:		247557
Obtained from:	OpenZFS
Reported and tested by:	Sam Vaughan <samjvaughan@gmail.com>
Discussed with:	freqlabs
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D25745
openzfs/zfs@7125a109dc
2020-07-23 14:21:45 +00:00
bin Update to D25266, bin/ps: Make the rtprio option actually show 2020-07-14 18:57:31 +00:00
cddl MFOpenZFS: Fix zpool history unbounded memory usage 2020-07-23 14:21:45 +00:00
contrib Fix some regressions with the zgrep(1) wrapper. 2020-07-20 23:57:53 +00:00
crypto openssh: refer to OpenSSL not SSLeay, part 2 2020-07-15 18:49:00 +00:00
etc Add tests for "add", "change" and "delete" functionality of /sbin/route. 2020-07-22 13:49:54 +00:00
gnu Remove now-unused GNU as build infrastructure 2020-06-07 13:53:23 +00:00
include Make CLOCK_REALTIME and TIMER_ABSTIME available for XOPEN_SOURCE >= 500. 2020-07-14 20:23:27 +00:00
kerberos5 Update Makefile.depend files 2019-12-11 17:37:53 +00:00
lib geli(8): Add missing commands in the EXAMPLES section 2020-07-22 13:00:56 +00:00
libexec getty appears to date from 3rd edition research unix. That's the oldest man page 2020-07-22 00:44:47 +00:00
release Enable EFI system partition on amd64 and i386 VM images 2020-07-14 18:02:24 +00:00
rescue rescue: Remove useless linking with libl 2020-03-24 07:08:02 +00:00
sbin Add tests for "add", "change" and "delete" functionality of /sbin/route. 2020-07-22 13:49:54 +00:00
secure Replace OPENSSL_NO_SSL3_METHODs with dummies 2020-07-01 00:59:28 +00:00
share Add missing bitset(9) MLINKS. 2020-07-19 12:22:32 +00:00
stand Revert that! 2020-07-19 23:56:19 +00:00
sys cuse: Stop checking for failures from malloc(M_WAITOK). 2020-07-23 14:03:37 +00:00
targets Add WITH_CLANG_FORMAT option 2020-06-24 17:03:42 +00:00
tests Fix sys.geom.class.eli.onetime_test.onetime after r363402 2020-07-22 17:37:11 +00:00
tools add script to help figure out what man pages need MLINKS updated... 2020-07-16 23:05:18 +00:00
usr.bin netstat(1): Add EXAMPLES section 2020-07-21 16:17:23 +00:00
usr.sbin Correct a type-mismatch between xdr_long and the variable "bad". 2020-07-22 23:39:58 +00:00
.arcconfig callsign isn't required anymore 2016-09-29 06:19:45 +00:00
.arclint arc lint: ignore /tests/ in chmod 2017-12-19 03:38:06 +00:00
.cirrus.yml Cirrus-CI: increase timeout to 120m 2020-02-19 15:56:40 +00:00
.clang-format Clang-format: Avoid hardcoded LLVM include-order style 2020-06-24 23:22:36 +00:00
.gitattributes Add a basic clang-format configuration file 2019-06-07 15:23:52 +00:00
.gitignore .gitignore: Add LINT kernel configurations generated into SRCDIR 2019-08-10 18:22:22 +00:00
COPYRIGHT Happy New Year 2020! 2019-12-31 16:01:36 +00:00
LOCKS LOCKS: update current locks 2018-06-09 03:08:04 +00:00
MAINTAINERS Update bhyve maintainers. 2020-06-26 06:11:50 +00:00
Makefile Use universe-toolchain config(8) 2020-04-29 02:18:39 +00:00
Makefile.inc1 Add WITH_CLANG_FORMAT option 2020-06-24 17:03:42 +00:00
Makefile.libcompat Stop building libl and liby 2020-03-26 08:23:09 +00:00
Makefile.sys.inc AUTO_OBJ: For all top-level targets enforce using an OBJDIR. 2017-12-05 21:29:47 +00:00
ObsoleteFiles.inc devstat(9): Update the man page to reflect the current implementation 2020-07-17 22:15:02 +00:00
README README: add generic notes about GENERIC and NOTES 2018-06-17 19:44:24 +00:00
README.md README: add generic notes about GENERIC and NOTES 2018-06-17 19:44:24 +00:00
RELNOTES Add a RELNOTES entry for r363253. 2020-07-16 15:12:52 +00:00
UPDATING Add a note regarding the introduction of the new bc and dc implementations 2020-07-05 14:43:14 +00:00

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html, and https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information, including setting make(1) variables.

Source Roadmap:

bin		System/user commands.

cddl		Various commands and libraries under the Common Development
		and Distribution License.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

stand		Boot loader sources.

sys		Kernel sources.

sys/<arch>/conf Kernel configuration files. GENERIC is the configuration
		used in release builds. NOTES contains documentation of
		all possible entries.

tests		Regression tests which can be run by Kyua.  See tests/README
		for additional information.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/current-stable.html