freebsd-dev

FreeBSD src

Go to file

Alexander Motin 67aa4cb2b9 MFV r316902: 7745 print error if lzc_* is called before libzfs_core_init illumos/illumos-gate@7c13517fff `7c13517fff` https://www.illumos.org/issues/7745 The problem is that consumers of `libZFS_Core` that forget to call `libzfs_core_init()` before calling any other function of the library are having a hard time realizing their mistake. The library's internal file descriptor is declared as global static, which is ok, but it is not initialized explicitly; therefore, it defaults to 0, which is a valid file descriptor. If `libzfs_core_init()`, which explicitly initializes the correct fd, is skipped, the ioctl functions return errors that do not have anything to do with `libZFS_Core`, where the problem is actually located. Even though assertions for that existed within `libZFS_Core` for debug builds, they were never enabled because the `-DDEBUG` flag was missing from the compiler flags. This patch applies the following changes: 1. It adds `-DDEBUG` for debug builds of `libZFS_Core` and `libzfs`, to enable their assertions on debug builds. 2. It corrects an assertion within `libzfs`, where a function had been spelled incorrectly (`zpool_prop_unsupported()`) and nobody knew because the `-DDEBUG` flag was missing, and the preprocessor was taking that part of the code away. 3. The library's internal fd is initialized to `-1` and `VERIFY` assertions have been placed to check that the fd is not equal to `-1` before issuing any ioctl. It is important here to note, that the `VERIFY` assertions exist in both debug and non-debug builds. 4. In `libzfs_core_fini` we make sure to never increment the refcount of our fd below 0, and also reset the fd to `-1` when no one refers to it. The reason for this, is for the rare case that the consumer closes all references but then calls one of the library's functions without using `libzfs_core_init()` first, and in the mean time, a previous call to `open()` decided to reuse our previous fd. This scenario would have passed our assertion in Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Approved by: Dan McDonald <danmcd@omniti.com> Author: Serapheim Dimitropoulos <serapheim@delphix.com>		2018-02-20 20:40:55 +00:00
bin	Capsicumize uuidgen.	2018-02-17 12:32:53 +00:00
cddl	MFV r316902: 7745 print error if lzc_* is called before libzfs_core_init	2018-02-20 20:40:55 +00:00
contrib	MFV r329552: less v530.	2018-02-19 05:10:22 +00:00
crypto	Add declaration of SSL_get_selected_srtp_profile() for OpenSSL.	2018-01-25 23:38:05 +00:00
etc	Fix handling of "one_nomatch" shell variable to preserve its contents	2018-02-17 13:32:29 +00:00
gnu	Remove libreadline from the source tree, all consumers but gdb	2018-02-06 12:22:42 +00:00
include	Vendor import of llvm release_60 branch r325330:	2018-02-16 19:10:15 +00:00
kerberos5	various: general adoption of SPDX licensing ID tags.	2017-11-27 15:37:16 +00:00
lib	Introduce channel flags in libcasper.	2018-02-17 12:22:29 +00:00
libexec	Sprinkle static; avoid nested externs.	2018-02-04 19:05:13 +00:00
release	Put the pine64 root filesystem on teh correct partition.	2018-02-16 16:22:54 +00:00
rescue	Avoid referencing private lib names directly.	2017-11-10 07:53:02 +00:00
sbin	More verbose output.	2018-02-20 05:35:00 +00:00
secure	Remove c_rehash(1) to not confuse users. We do not install the Perl script.	2018-02-08 19:55:03 +00:00
share	style.lua(9): Clarify local variable guideline	2018-02-20 05:21:58 +00:00
stand	lualoader: Replace invalid construct with valid construct	2018-02-20 20:29:41 +00:00
sys	mtx: add debug assertions to mtx_spin_wait_unlocked	2018-02-20 20:39:34 +00:00
targets	Remove libreadline from the source tree, all consumers but gdb	2018-02-06 12:22:42 +00:00
tests	gpart: append partition name to the underlying provider's physical path	2018-02-14 20:26:09 +00:00
tools	tools/80211: correct array index	2018-02-19 19:01:46 +00:00
usr.bin	tail: fix "tail -r" for piped input that begins with '\n'	2018-02-19 22:09:49 +00:00
usr.sbin	Fixup minor nits in the PNP_INFO protocol.	2018-02-17 06:57:03 +00:00
.arcconfig	callsign isn't required anymore	2016-09-29 06:19:45 +00:00
.arclint	arc lint: ignore /tests/ in chmod	2017-12-19 03:38:06 +00:00
.gitattributes	.git*: add gitattributes and gitignore	2017-12-25 21:07:54 +00:00
.gitignore	.git*: add gitattributes and gitignore	2017-12-25 21:07:54 +00:00
COPYRIGHT	Happy New Year 2018 my friends!	2017-12-31 16:48:04 +00:00
LOCKS
MAINTAINERS	list myself in the MAINTAINERS file for Xen bits	2018-02-13 16:25:43 +00:00
Makefile	Add a note about why we have the conditional before including	2018-02-07 16:28:26 +00:00
Makefile.inc1	sort needs to be in ITOOLS since find -s was changed to find \| sort.	2018-02-09 18:47:00 +00:00
Makefile.libcompat	X_COMPILER_* may not be defined.	2018-01-24 18:08:37 +00:00
Makefile.sys.inc	AUTO_OBJ: For all top-level targets enforce using an OBJDIR.	2017-12-05 21:29:47 +00:00
ObsoleteFiles.inc	Move devmatch to sbin from usr/sbin.	2018-02-12 14:44:21 +00:00
README	Vendor import of less v530.	2018-02-19 04:47:31 +00:00
README.md	Document the sys/boot -> stand move in hier.7 and the top-level README.	2017-12-03 20:36:36 +00:00
UPDATING	Add Lua as a scripting langauge to /boot/loader	2018-02-12 15:31:53 +00:00

README.md

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

For copyright information, please see the file COPYRIGHT in this directory (additional copyright information also exists for some sources in this tree - please see the specific source directories for more information).

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7) and https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html for more information, including setting make(1) variables.

The buildkernel and installkernel targets build and install the kernel and the modules (see below). Please see the top of the Makefile in this directory for more information on the standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process. See build(7), config(8), and https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information.

Note: If you want to build and install the kernel with the buildkernel and installkernel targets, you might need to build world before. More information is available in the handbook.

The kernel configuration files reside in the sys/<arch>/conf sub-directory. GENERIC is the default configuration used in release builds. NOTES contains entries and documentation for all possible devices, not just those commonly used.

Source Roadmap:

bin				System/user commands.

cddl			Various commands and libraries under the Common Development  
				and Distribution License.

contrib			Packages contributed by 3rd parties.

crypto			Cryptography stuff (see crypto/README).

etc				Template files for /etc.

gnu				Various commands and libraries under the GNU Public License.  
				Please see gnu/COPYING* for more information.

include			System include files.

kerberos5		Kerberos5 (Heimdal) package.

lib				System libraries.

libexec			System daemons.

release			Release building Makefile & associated tools.

rescue			Build system for statically linked /rescue utilities.

sbin			System commands.

secure			Cryptographic libraries and commands.

share			Shared resources.

stand			Boot loader sources.

sys				Kernel sources.

tests			Regression tests which can be run by Kyua.  See tests/README
				for additional information.

tools			Utilities for regression testing and miscellaneous tasks.

usr.bin			User commands.

usr.sbin		System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/current-stable.html