Currently, we handle SIGINT by calling summary() and _exit() directly from the signal handler, which we install after setup(). There are several issues with this: * summary() is not signal safe; * the parent is not informed about the signal; * setup() can block on open(), and catching SIGINT at that stage will produce the correct exit status but will not print anything to stderr as POSIX demands. Fix this by making SIGINT non-restartable, changing our signal handler to only set a flag, installing it before setup(), and checking the termination flag before and after every blocking operation, i.e. open(), read(), write(). Also add two test cases, one for catching SIGINT while opening the input and one for catching it while reading. I couldn't think of an easy way to test catching SIGINT while writing (it's certainly feasible, but perhaps not from a shell script). MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: cracauer, ngie, imp Differential Revision: https://reviews.freebsd.org/D39641
74 lines
2.7 KiB
C
74 lines
2.7 KiB
C
/*-
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*
|
|
* Copyright (c) 1991, 1993, 1994
|
|
* The Regents of the University of California. All rights reserved.
|
|
*
|
|
* This code is derived from software contributed to Berkeley by
|
|
* Keith Muller of the University of California, San Diego and Lance
|
|
* Visser of Convex Computer Corporation.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. Neither the name of the University nor the names of its contributors
|
|
* may be used to endorse or promote products derived from this software
|
|
* without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*
|
|
* @(#)extern.h 8.3 (Berkeley) 4/2/94
|
|
* $FreeBSD$
|
|
*/
|
|
|
|
void block(void);
|
|
void block_close(void);
|
|
void dd_out(int);
|
|
void def(void);
|
|
void def_close(void);
|
|
void jcl(char **);
|
|
void pos_in(void);
|
|
void pos_out(void);
|
|
double secs_elapsed(void);
|
|
void progress(void);
|
|
void summary(void);
|
|
void sigalarm_handler(int);
|
|
void siginfo_handler(int);
|
|
void terminate(int);
|
|
void check_terminate(void);
|
|
void unblock(void);
|
|
void unblock_close(void);
|
|
|
|
extern IO in, out;
|
|
extern STAT st;
|
|
extern void (*cfunc)(void);
|
|
extern uintmax_t cpy_cnt;
|
|
extern size_t cbsz;
|
|
extern uint64_t ddflags;
|
|
extern size_t speed;
|
|
extern uintmax_t files_cnt;
|
|
extern const u_char *ctab;
|
|
extern const u_char a2e_32V[], a2e_POSIX[];
|
|
extern const u_char e2a_32V[], e2a_POSIX[];
|
|
extern const u_char a2ibm_32V[], a2ibm_POSIX[];
|
|
extern u_char casetab[];
|
|
extern char fill_char;
|
|
extern volatile sig_atomic_t need_summary;
|
|
extern volatile sig_atomic_t need_progress;
|
|
extern volatile sig_atomic_t kill_signal;
|