d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
76e6db686e
freebsd-dev/lib/libc/string
History
Baptiste Daroussin 76e6db686e collate: Fix expansion substitions (broken upstream too) 
Through testing, the user noted that some Cyrillic characters were not
sorting correctly, and this was confirmed.

After extensive testing and review, the localedef tool was eliminated
as the culprit.  The sustitutions were encoded correctly in LC_COLLATE.

The error was mainly in wcscoll where character expansions were
mishandled.  The main directive pass routines had to be written to
go back for a new collation value when the "state" variable was set.
Before pointers were being advanced, the second lookup was gettting
applied to the wrong character, etc.

The "eat expansion codes" section on collate.c also had a bug.  Later
own, the "state" variable logic was changed to only set if next
code was greater than zero (rather than >= 0).

Some additional cleanups got captured from previous work:
1) The previous commit moved the binary search comment from the
   correct location to a wrong location because it's wrong upstream
   in Illumos.  The comment has little value so I just removed it.
2) Don't check if pointers are null before freeing, this is
   redundant as free() handles null pointers.
3) The two binary search trees were standardized wrt initialization
4) On the binary search trees, a negative "high" exits rather than
   checking the table count again.

Submitted by:	marino
Obtained from:	DragonflyBSD
2015-10-23 23:24:03 +00:00
..
bcmp.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
bcmp.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
bcopy.3 Fix spelling. 2015-08-24 01:53:18 +00:00
bcopy.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
bstring.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
bzero.3 Update bzero(3) manpage to following the Posix Standard. 2015-08-24 01:51:10 +00:00
bzero.c
ffs.3 Document bitset(9) 2015-10-17 19:55:58 +00:00
ffs.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
ffsl.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
ffsll.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
fls.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
flsl.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
flsll.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
index.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
Makefile.inc Remove duplicated code. 2014-10-16 22:04:07 +00:00
memccpy.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
memccpy.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
memchr.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
memchr.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
memcmp.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
memcmp.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
memcpy.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
memcpy.c
memmem.3 memmem(3): empty little string matches the beginning of the big string 2015-05-26 21:16:07 +00:00
memmem.c memmem(3): empty little string matches the beginning of the big string 2015-05-26 21:16:07 +00:00
memmove.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
memmove.c
memrchr.c
memset.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
memset.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
stpcpy.c Add restrict qualifiers. 2009-02-28 06:05:37 +00:00
stpncpy.c - Add getdelim(), getline(), stpncpy(), strnlen(), wcsnlen(), 2009-02-28 06:00:58 +00:00
strcasecmp.3 Fix strcasecmp_l() and strncasecmp_l() POSIX 2008 compliance. 2014-05-30 01:09:07 +00:00
strcasecmp.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strcasestr.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strcat.3 libc man pages: Remove reference to non-existent FreeBSD Security 2014-03-07 15:35:54 +00:00
strcat.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strchr.3 strchr(3): Mdoc fixes. 2015-06-04 21:54:46 +00:00
strchr.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strchrnul.c Add declaration to eliminate -Wmissing-prototypes warning. 2015-09-20 03:51:15 +00:00
strcmp.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strcmp.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strcoll.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strcoll.c Fix typo 2015-08-09 00:19:14 +00:00
strcpy.3 libc man pages: Remove reference to non-existent FreeBSD Security 2014-03-07 15:35:54 +00:00
strcpy.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strcspn.c
strdup.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strdup.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strerror.3 use .Mt to mark up email addresses consistently (part4) 2014-06-23 08:25:03 +00:00
strerror.c libc: Always use our own copy of sys_errlist and sys_nerr (.so only). 2013-08-31 22:32:42 +00:00
string.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strlcat.c Make strlcpy/strlcat slightly easier to read. 2015-04-06 03:21:22 +00:00
strlcpy.3 Fix .Dd after r257646. 2013-11-05 21:47:00 +00:00
strlcpy.c Make strlcpy/strlcat slightly easier to read. 2015-04-06 03:21:22 +00:00
strlen.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strlen.c Correct bugs fixed but not merged from my own tree. 2010-03-13 00:15:06 +00:00
strmode.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strmode.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strncat.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strncmp.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strncpy.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strndup.c Replace strndup with OpenBSD's implementation. 2015-08-26 23:28:10 +00:00
strnlen.c - Add getdelim(), getline(), stpncpy(), strnlen(), wcsnlen(), 2009-02-28 06:00:58 +00:00
strnstr.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strpbrk.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strpbrk.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strrchr.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strsep.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strsep.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strsignal.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strspn.3 Various mdoc fixes and a few EOL whitespace removals. 2014-12-21 12:36:36 +00:00
strspn.c
strstr.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strstr.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strtok.3 use .Mt to mark up email addresses consistently (part4) 2014-06-23 08:25:03 +00:00
strtok.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strxfrm.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
strxfrm.c Fix typo 2015-08-09 00:19:14 +00:00
swab.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
swab.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
Symbol.map Add explicit_bzero(3) and its kernel counterpart. 2014-10-07 04:54:11 +00:00
wcpcpy.c Add wcpcpy(3) and wcpncpy(3). 2009-03-04 06:01:27 +00:00
wcpncpy.c Add wcpcpy(3) and wcpncpy(3). 2009-03-04 06:01:27 +00:00
wcscasecmp.c - Add getdelim(), getline(), stpncpy(), strnlen(), wcsnlen(), 2009-02-28 06:00:58 +00:00
wcscat.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wcschr.c
wcscmp.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
wcscoll.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
wcscoll.c collate: Fix expansion substitions (broken upstream too) 2015-10-23 23:24:03 +00:00
wcscpy.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wcscspn.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wcsdup.c
wcslcat.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wcslcpy.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wcslen.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wcsncasecmp.c - Add getdelim(), getline(), stpncpy(), strnlen(), wcsnlen(), 2009-02-28 06:00:58 +00:00
wcsncat.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wcsncmp.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
wcsncpy.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
wcsnlen.c - Add getdelim(), getline(), stpncpy(), strnlen(), wcsnlen(), 2009-02-28 06:00:58 +00:00
wcspbrk.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wcsrchr.c
wcsspn.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wcsstr.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
wcstok.3
wcstok.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
wcswidth.3
wcswidth.c Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
wcsxfrm.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
wcsxfrm.c The collate functions within libc have been using version 1 and 1.2 of the 2015-08-07 23:41:26 +00:00
wmemchr.3 Renumber clauses to reduce diffs to other versions 2013-05-28 20:57:40 +00:00
wmemchr.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wmemcmp.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wmemcpy.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wmemmove.c - ANSIfy function definitions 2009-02-03 17:58:20 +00:00
wmemset.c Fix the functions to match prototypes. The K&R definitions differ 2009-02-03 20:25:36 +00:00