FreeBSD src
Go to file
Adrian Chadd 8a5350984f Fix link status handling on if_arge upon system boot to allow bootp/NFS to
function.

From the submitter:

This patch fixes an issue I encountered using an NFS root with an
ar71xx-based MikroTik RouterBoard 450G on -current where the kernel fails
to contact a DHCP/BOOTP server via if_arge when it otherwise should be able
to.  This may be the same issue that Monthadar Al Jaberi reported against
an RSPRO on 6 March, as the signature is the same:

%%%

DHCP/BOOTP timeout for server 255.255.255.255
DHCP/BOOTP timeout for server 255.255.255.255
DHCP/BOOTP timeout for server 255.255.255.255
.
.
.
DHCP/BOOTP timeout for server 255.255.255.255
DHCP/BOOTP timeout for server 255.255.255.255
arge0: initialization failed: no memory for rx buffers
DHCP/BOOTP timeout for server 255.255.255.255
arge0: initialization failed: no memory for rx buffers

%%%

The primary issue that I found is that the DHCP/BOOTP message that
bootpc_call() is sending never makes it onto the wire, which I believe is
due to the following:

- Last December, a change was made to the ifioctl that bootpc_call() uses
to adjust the netmask around the sosend().

- The new ioctl (SIOCAIFADDR) performs an if_init when invoked, whereas the
old one (SIOCSIFNETMASK) did not.

- if_arge maintains its own sense of link state in sc->arge_link_status.

- On a single-phy interface, sc->arge_link_status is initialized to 0 in
arge_init_locked().

- sc->arge_link_status remains 0 until a phy state change notification
causes arge_link_task to run, notice the link is up, and set it to 1.

- The inits caused by the ifioctls in bootpc_call are reinitializing the
interface, but not the phy, so sc->arge_link_status goes to 0 and remains
there.

- arge_start_locked() always sees sc->arge_link_status == 0 and returns
without queuing anything.

The attached patch changes arge_init_locked() such that in the single-phy
case, instead of initializing sc->arge_link_status to 0, it runs
arge_link_task() to set it according to the current phy state.  This change
has allowed my setup to mount an NFS root successfully.

Submitted by:	Patrick Kelsey <kelsey@ieee.org>
Reviewed by:	juli
2012-03-13 06:28:52 +00:00
bin Document P_ORPHAN. 2012-03-08 13:00:49 +00:00
cddl Analogous to r232059, add a parameter for the ZFS file system: 2012-02-26 16:30:39 +00:00
contrib Note two shortcomings of GDB on MIPS that should be addressed. 2012-03-13 04:50:41 +00:00
crypto Polish diff against upstream. 2012-02-13 11:59:59 +00:00
etc Rather than printing the output from route add for all FIBs just print them 2012-03-04 18:53:35 +00:00
games
gnu Note two shortcomings of GDB on MIPS that should be addressed. 2012-03-13 04:50:41 +00:00
include Remove fifo.h. The only used function declaration from the header is 2012-03-11 12:19:58 +00:00
kerberos5 Don't support OpenLDAP during lib32 build. 2011-12-06 12:03:01 +00:00
lib Stop calling _init/_fini methods from crt1 for dynamic binaries. Do 2012-03-11 20:04:09 +00:00
libexec Use PTR_SUBU instead of subu (missed this one) 2012-03-12 20:59:18 +00:00
release Make sure not to tar up CVS directories if this ports tree is a CVS 2012-03-09 02:23:03 +00:00
rescue
sbin - Add ipfw eXtended tables permitting radix to be used for any kind of keys. 2012-03-12 14:07:57 +00:00
secure Return NULL on error rather than ":", per the crypt(3) man page. 2012-02-22 01:23:14 +00:00
share Make boot2 build with Clang again. 2012-03-09 23:30:30 +00:00
sys Fix link status handling on if_arge upon system boot to allow bootp/NFS to 2012-03-13 06:28:52 +00:00
tools sh: Add a test for variables with underscores in arithmetic. 2012-03-11 22:12:05 +00:00
usr.bin After r232745, which makes sure __bswap16(), ntohs() and htons() return 2012-03-09 20:50:15 +00:00
usr.sbin Fix crunchide on MIPS with other than the O32 ABI. 2012-03-13 05:21:14 +00:00
COPYRIGHT
LOCKS Update LOCKS syntax. 2008-06-05 19:47:58 +00:00
MAINTAINERS Add isci(4) driver for amd64 and i386 targets. 2012-01-31 19:38:18 +00:00
Makefile Add a kernel-toolchains target like the toolchains target, but building only 2012-03-13 00:38:49 +00:00
Makefile.inc1 Fix a thinko in r232322, where gcc (and its tools) are not built during 2012-03-04 21:36:18 +00:00
ObsoleteFiles.inc Remove fifo.h. The only used function declaration from the header is 2012-03-11 12:19:58 +00:00
README Add the cddl/ directory. 2010-11-14 11:32:56 +00:00
UPDATING Disable the option VFS_ALLOW_NONMPSAFE by default on all the supported 2012-03-06 20:01:25 +00:00

This is the top level of the FreeBSD source directory.  This file
was last revised on:
$FreeBSD$

For copyright information, please see the file COPYRIGHT in this
directory (additional copyright information also exists for some
sources in this tree - please see the specific source directories for
more information).

The Makefile in this directory supports a number of targets for
building components (or all) of the FreeBSD source tree, the most
commonly used one being ``world'', which rebuilds and installs
everything in the FreeBSD system from the source tree except the
kernel, the kernel-modules and the contents of /etc.  The ``world''
target should only be used in cases where the source tree has not
changed from the currently running version.  See:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html
for more information, including setting make(1) variables.

The ``buildkernel'' and ``installkernel'' targets build and install
the kernel and the modules (see below).  Please see the top of
the Makefile in this directory for more information on the
standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process, documentation
for which can be found at:
   http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html
And in the config(8) man page.
Note: If you want to build and install the kernel with the
``buildkernel'' and ``installkernel'' targets, you might need to build
world before.  More information is available in the handbook.

The sample kernel configuration files reside in the sys/<arch>/conf
sub-directory (assuming that you've installed the kernel sources), the
file named GENERIC being the one used to build your initial installation
kernel.  The file NOTES contains entries and documentation for all possible
devices, not just those commonly used.  It is the successor of the ancient
LINT file, but in contrast to LINT, it is not buildable as a kernel but a
pure reference and documentation file.


Source Roadmap:
---------------
bin		System/user commands.

cddl		Various commands and libraries under the Common Development
		and Distribution License.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

games		Amusements.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

sys		Kernel sources.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.


For information on synchronizing your source tree with one or more of
the FreeBSD Project's development branches, please see:

  http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html