d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8af6a2c64e
freebsd-dev/lib/libefivar
History
Warner Losh 8af6a2c64e Define StrCmp in a funky was to be bug-compatible with EDK2 code. 
Paper over a coverity issue:

*** CID 1372592:  API usage errors  (BAD_COMPARE)
/lib/libefivar/efivar-dp-parse.c: 2723 in DevPathFromTextiSCSI()
   Truncating the result of "strcmp" to "unsigned short" may cause it
   to be misinterpreted as 0. Note that "strcmp" may return an integer
   besides -1, 0, or 1.

We do this by making StrCmp return either 0 or 1 for equal or
not-equal.  There's a bug in the DevPathFromTextiSCSI cast of the
return value and this workaround will fix it without breaking other
users of StrCmp (all of which test for == 0).

https://bugzilla.tianocore.org/show_bug.cgi?id=440 has been filed
upstream to log this issue.

CID: 1372592
Sponsored by: Netflix
2017-03-23 02:30:52 +00:00
..
efi-osdep.h Bring in EDK2 routines for printing and parsing device paths. 2017-03-09 00:31:31 +00:00
efivar-dp-format.c Bring in EDK2 routines for printing and parsing device paths. 2017-03-09 00:31:31 +00:00
efivar-dp-parse.c Bring in EDK2 routines for printing and parsing device paths. 2017-03-09 00:31:31 +00:00
efivar-dp.h Bring in EDK2 routines for printing and parsing device paths. 2017-03-09 00:31:31 +00:00
efivar.3
efivar.c Share UCS2/UTF8 routines between boot loader and userland. 2017-03-09 00:24:01 +00:00
efivar.h Bring in EDK2 routines for printing and parsing device paths. 2017-03-09 00:31:31 +00:00
FreeBSD-update Bring in EDK2 routines for printing and parsing device paths. 2017-03-09 00:31:31 +00:00
Makefile Bring in EDK2 routines for printing and parsing device paths. 2017-03-09 00:31:31 +00:00
Makefile.depend DIRDEPS_BUILD: Connect new dependencies. 2016-11-13 00:11:23 +00:00
ProcessorBind.h Bring in EDK2 routines for printing and parsing device paths. 2017-03-09 00:31:31 +00:00
uefi-dplib.h Define StrCmp in a funky was to be bug-compatible with EDK2 code. 2017-03-23 02:30:52 +00:00
uefi-dputil.c Bring in EDK2 routines for printing and parsing device paths. 2017-03-09 00:31:31 +00:00
uefi-guid.c Bring in EDK2 routines for printing and parsing device paths. 2017-03-09 00:31:31 +00:00
uefi-guid.dat Bring in EDK2 routines for printing and parsing device paths. 2017-03-09 00:31:31 +00:00