freebsd-dev/usr.sbin/bsdinstall/distfetch/distfetch.c
Devin Teske bd1df63614 Optimize program flow for execution speed. Also fix some more style(9) nits
while here:
+ Fix an issue when extracting small archives where dialog_mixedgauge was
  not rendering; leaving the user wondering if anything happened.
+ Add #ifdef's to assuage compilation against older libarchive
  NB: Minimize diff between branches; make merging easier.
+ Add missing calls to end_dialog(3)
+ Change string processing from strtok(3) to strcspn(3) (O(1) optimization)
+ Use EXIT_SUCCESS and EXIT_FAILURE instead of 0/1
+ Optimize getenv(3) use, using stored results instead of calling repeatedly
  NB: Fixes copy/paste error wherein we display getenv(BSDINSTALL_DISTDIR) in
      an error msgbox when chdir(2) to getenv(BSDINSTALL_CHROOT) fails
      (wrong variable displayed in msgbox).
+ Use strtol(3) instead of [deprecated] atoi(3)
+ Add additional error checking (e.g., check return of archive_read_new(3))
+ Assign DECONST strings to static variables
+ Fix typo in distextract.c error message (s/Could could/Could not/)
+ Add comments and make a minor whitespace adjustment

Reviewed by:	nwhitehorn, julian
2014-10-01 18:59:57 +00:00

224 lines
5.8 KiB
C

/*-
* Copyright (c) 2011 Nathan Whitehorn
* Copyright (c) 2014 Devin Teske <dteske@FreeBSD.org>
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <sys/param.h>
#include <ctype.h>
#include <err.h>
#include <dialog.h>
#include <errno.h>
#include <fetch.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
static int fetch_files(int nfiles, char **urls);
int
main(void)
{
char *diststring;
char **urls;
int i;
int ndists = 0;
int nfetched;
char error[PATH_MAX + 512];
if (getenv("DISTRIBUTIONS") == NULL)
errx(EXIT_FAILURE, "DISTRIBUTIONS variable is not set");
diststring = strdup(getenv("DISTRIBUTIONS"));
for (i = 0; diststring[i] != 0; i++)
if (isspace(diststring[i]) && !isspace(diststring[i+1]))
ndists++;
ndists++; /* Last one */
urls = calloc(ndists, sizeof(const char *));
if (urls == NULL) {
free(diststring);
errx(EXIT_FAILURE, "Out of memory!");
}
init_dialog(stdin, stdout);
dialog_vars.backtitle = __DECONST(char *, "FreeBSD Installer");
dlg_put_backtitle();
for (i = 0; i < ndists; i++) {
urls[i] = malloc(PATH_MAX);
snprintf(urls[i], PATH_MAX, "%s/%s",
getenv("BSDINSTALL_DISTSITE"), strsep(&diststring, " \t"));
}
if (chdir(getenv("BSDINSTALL_DISTDIR")) != 0) {
snprintf(error, sizeof(error),
"Could could change to directory %s: %s\n",
getenv("BSDINSTALL_DISTDIR"), strerror(errno));
dialog_msgbox("Error", error, 0, 0, TRUE);
end_dialog();
return (EXIT_FAILURE);
}
nfetched = fetch_files(ndists, urls);
end_dialog();
free(diststring);
for (i = 0; i < ndists; i++)
free(urls[i]);
free(urls);
return ((nfetched == ndists) ? EXIT_SUCCESS : EXIT_FAILURE);
}
static int
fetch_files(int nfiles, char **urls)
{
FILE *fetch_out;
FILE *file_out;
const char **items;
int i;
int last_progress;
int nsuccess = 0; /* Number of files successfully downloaded */
int progress = 0;
size_t chunk;
off_t current_bytes;
off_t fsize;
off_t total_bytes;
char status[8];
struct url_stat ustat;
char errormsg[PATH_MAX + 512];
uint8_t block[4096];
/* Make the transfer list for dialog */
items = calloc(sizeof(char *), nfiles * 2);
if (items == NULL)
errx(EXIT_FAILURE, "Out of memory!");
for (i = 0; i < nfiles; i++) {
items[i*2] = strrchr(urls[i], '/');
if (items[i*2] != NULL)
items[i*2]++;
else
items[i*2] = urls[i];
items[i*2 + 1] = "Pending";
}
dialog_msgbox("", "Connecting to server.\nPlease wait...", 0, 0, FALSE);
/* Try to stat all the files */
total_bytes = 0;
for (i = 0; i < nfiles; i++) {
if (fetchStatURL(urls[i], &ustat, "") == 0 && ustat.size > 0)
total_bytes += ustat.size;
}
current_bytes = 0;
for (i = 0; i < nfiles; i++) {
last_progress = progress;
if (total_bytes == 0)
progress = (i*100)/nfiles;
fetchLastErrCode = 0;
fetch_out = fetchXGetURL(urls[i], &ustat, "");
if (fetch_out == NULL) {
snprintf(errormsg, sizeof(errormsg),
"Error while fetching %s: %s\n", urls[i],
fetchLastErrString);
items[i*2 + 1] = "Failed";
dialog_msgbox("Fetch Error", errormsg, 0, 0,
TRUE);
continue;
}
items[i*2 + 1] = "In Progress";
fsize = 0;
file_out = fopen(items[i*2], "w+");
if (file_out == NULL) {
snprintf(errormsg, sizeof(errormsg),
"Error while fetching %s: %s\n",
urls[i], strerror(errno));
items[i*2 + 1] = "Failed";
dialog_msgbox("Fetch Error", errormsg, 0, 0,
TRUE);
fclose(fetch_out);
continue;
}
while ((chunk = fread(block, 1, sizeof(block), fetch_out))
> 0) {
if (fwrite(block, 1, chunk, file_out) < chunk)
break;
current_bytes += chunk;
fsize += chunk;
if (total_bytes > 0) {
last_progress = progress;
progress = (current_bytes*100)/total_bytes;
}
if (ustat.size > 0) {
snprintf(status, sizeof(status), "-%jd",
(fsize*100)/ustat.size);
items[i*2 + 1] = status;
}
if (progress > last_progress)
dialog_mixedgauge("Fetching Distribution",
"Fetching distribution files...", 0, 0,
progress, nfiles,
__DECONST(char **, items));
}
if (ustat.size > 0 && fsize < ustat.size) {
if (fetchLastErrCode == 0)
snprintf(errormsg, sizeof(errormsg),
"Error while fetching %s: %s\n",
urls[i], strerror(errno));
else
snprintf(errormsg, sizeof(errormsg),
"Error while fetching %s: %s\n",
urls[i], fetchLastErrString);
items[i*2 + 1] = "Failed";
dialog_msgbox("Fetch Error", errormsg, 0, 0,
TRUE);
} else {
items[i*2 + 1] = "Done";
nsuccess++;
}
fclose(fetch_out);
fclose(file_out);
}
free(items);
return (nsuccess);
}