FreeBSD src
Go to file
Chuck Tuffli 91064841d7 bhyve: Fix NVMe iovec construction for large IOs
The UEFI driver included with Rocky Linux 8.4 uncovered an existing bug
in the NVMe emulation's construction of iovec's.

By default, NVMe data transfer operations use a scatter-gather list in
which all entries point to a fixed size memory region. For example, if
the Memory Page Size is 4KiB, a 2MiB IO requires 512 entries. Lists
themselves are also fixed size (default is 512 entries).

Because the list size is fixed, the last entry is special. If the IO
requires more than 512 entries, the last entry in the list contains the
address of the next list of entries. But if the IO requires exactly 512
entries, the last entry points to data.

The NVMe emulation missed this logic and unconditionally treated the
last entry as a pointer to the next list. Fix is to check if the
remaining data is greater than the page size before using the last entry
as a pointer to the next list.

PR:		256422
Reported by:	dave@syix.com
Tested by:	jason@tubnor.net
MFC after:	5 days
Relnotes:	yes
Reviewed by:	imp, grehan
Differential Revision:	https://reviews.freebsd.org/D30897
2021-06-27 15:14:52 -07:00
.cirrus-ci Cirrus-CI: retry pkg installation on failure 2021-06-02 22:41:20 -04:00
.github [skip ci] volunteer to maintain POSIX AIO 2021-05-30 17:21:12 -06:00
bin pkgbase: Put chio in utilities 2021-06-19 17:49:44 +02:00
cddl pkgbase: Put dtrace in its own package 2021-06-19 17:49:31 +02:00
contrib clang: stop linking _p libs for -pg as of FreeBSD 14 2021-06-27 13:12:12 -04:00
crypto kerberos.8: Replace dead link 2021-05-16 01:37:09 -04:00
etc sbin/md5: Create /usr/tests/sbin/md5 directory for placing tests 2021-06-25 18:29:46 +08:00
gnu dialog: fix macro redefinition 2021-03-01 16:01:44 +01:00
include FreeBSD: fix compilation of FreeBSD world after 29274c9f6 2021-06-25 10:28:51 -07:00
kerberos5 kerberos5: fix the WITH_OPENLDAP build 2021-01-30 00:07:50 -06:00
lib Work around bogus old gcc "initializer element is not constant" error 2021-06-25 20:43:20 +02:00
libexec rc.subr: use _pidcmd to determine pid for protect 2021-06-24 20:14:31 +02:00
release EC2: Tell gptboot to skip its 3 second wait 2021-06-21 15:37:15 -07:00
rescue ping: add a ping6 hard link for backwards compatibility 2020-11-26 18:33:04 +00:00
sbin mount_nfs.8: Update the man page for commit a145cf3f73 2021-06-26 14:09:28 -07:00
secure secure/caroot, certctl: Rename secure/caroot/blacklisted 2021-06-18 13:38:07 +01:00
share src.conf.5: regen after RISC-V OPENMP (aa033e0b14) 2021-06-27 13:30:08 -04:00
stand libsa: Add tslog support for arm64 2021-06-23 22:21:23 -07:00
sys sctp: initialize sequence numbers for ECN correctly 2021-06-27 20:14:48 +02:00
targets Remove svnlite. 2021-06-11 14:56:41 -07:00
tests fusefs: correctly set lock owner during FUSE_SETLK 2021-06-25 20:40:08 -06:00
tools CI: add arm64 support to ci-qemu-test.sh 2021-06-26 14:26:41 -04:00
usr.bin Update to bmake-20210621 2021-06-25 16:02:40 -07:00
usr.sbin bhyve: Fix NVMe iovec construction for large IOs 2021-06-27 15:14:52 -07:00
.arcconfig Remove history.immutable from .arcconfig 2021-04-13 12:36:25 +01:00
.arclint arc lint: ignore /tests/ in chmod 2017-12-19 03:38:06 +00:00
.cirrus.yml CI: use amd64 EDK II firmware included with QEMU 2021-06-26 14:22:48 -04:00
.clang-format clang-format: Avoid breaking after the opening paren of function definitions 2020-10-28 11:54:00 +00:00
.gitattributes Add a basic clang-format configuration file 2019-06-07 15:23:52 +00:00
.gitignore gitignore: Add .clangd and .ccls-cache 2021-06-04 16:56:08 +08:00
COPYRIGHT copyrights: Happy New Year 2021 2020-12-31 10:29:44 -05:00
LOCKS LOCKS: update current locks 2018-06-09 03:08:04 +00:00
MAINTAINERS [skip ci] volunteer to maintain POSIX AIO 2021-05-30 17:21:12 -06:00
Makefile Remove 'make update'. 2021-06-11 14:56:28 -07:00
Makefile.inc1 Remove svnlite. 2021-06-11 14:56:41 -07:00
Makefile.libcompat libpmc: always generate libpmc_events.c 2021-05-31 17:39:05 -03:00
Makefile.sys.inc AUTO_OBJ: For all top-level targets enforce using an OBJDIR. 2017-12-05 21:29:47 +00:00
ObsoleteFiles.inc ObsoleteFiles.inc: fixup after zpool-features.7.gz got re-introduced 2021-06-27 02:58:15 +02:00
README.md Whitespace cleanup 2021-03-12 19:57:58 +08:00
RELNOTES nfscl: Add entries to UPDATING and RELNOTES for commit a145cf3f73 2021-06-24 19:10:36 -07:00
UPDATING nfscl: Add entries to UPDATING and RELNOTES for commit a145cf3f73 2021-06-24 19:10:36 -07:00

FreeBSD Source:

This is the top level of the FreeBSD source directory.

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), FreeBSD handbook on building userland, and Handbook for kernels for more information, including setting make(1) variables.

Source Roadmap:

Directory Description
bin System/user commands.
cddl Various commands and libraries under the Common Development and Distribution License.
contrib Packages contributed by 3rd parties.
crypto Cryptography stuff (see crypto/README).
etc Template files for /etc.
gnu Various commands and libraries under the GNU Public License. Please see gnu/COPYING and gnu/COPYING.LIB for more information.
include System include files.
kerberos5 Kerberos5 (Heimdal) package.
lib System libraries.
libexec System daemons.
release Release building Makefile & associated tools.
rescue Build system for statically linked /rescue utilities.
sbin System commands.
secure Cryptographic libraries and commands.
share Shared resources.
stand Boot loader sources.
sys Kernel sources.
sys/arch/conf Kernel configuration files. GENERIC is the configuration used in release builds. NOTES contains documentation of all possible entries.
tests Regression tests which can be run by Kyua. See tests/README for additional information.
tools Utilities for regression testing and miscellaneous tasks.
usr.bin User commands.
usr.sbin System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see FreeBSD Handbook.