FreeBSD src
927394cafc
the end of libc++'s <exception>. This is a workaround for building Firefox, which generates a rather convoluted maze of standard library wrapper headers, and this leads to an unfortunate sequence of: 1. wrapper <new> includes libc++ <new>, 2. which includes wrapper <exception>, 3. which includes libc++ <exception>, 4. which includes wrapper <cstdio> (because of -fno-exception), 5. which includes libc++ <new> again, 6. which includes mozalloc.h, 7. which tries to declare operator new with std::bad_alloc, 8. which gives an error because std::bad_alloc is not yet defined. The <new> inclusion at step 5 does nothing, because the header guard for <new> was already encountered in step 1. Then when moz_alloc.h tries to use std::bad_alloc, it is not yet defined, because we are still busy processing <exception> (where this class is defined) from step 3. Mozilla has https://bugzilla.mozilla.org/show_bug.cgi?id=1269171 for this, reported by Jan Beich (jbeich@), but when the fix for it is applied to Firefox, we get into another, similar problem situation: 1. some header includes wrapper <exception>, 2. which includes libc++ <exception>, 3. which includes wrapper <cstdio> (because of -fno-exceptions), 4. which includes mozalloc.h, 5. which includes wrapper <new>, 6. which includes libc++ <new>, 7. which gives an error defining std::bad_alloc, because std::exception is not yet defined. At step 3, we were at the top of libc++'s <exception>, and at that point std::exception is not yet defined. At step 6, <new> does include <exception> again, but similar to step 5 in the previous problem case, the header guard was already encountered, so the whole header is skipped. In upstream libc++'s later revisions r279744 and r279763, the reason for including <cstdio> and <cstdlib> was nullified again, but these commits are rather large and intrusive. Therefore, move the includes to the bottom of the file, just before where they are needed. At that point, std::exception is already fully defined. Suggested by: Jörg Sonnenberger |
||
|---|---|---|
| bin | ||
| cddl | ||
| contrib | ||
| crypto | ||
| etc | ||
| gnu | ||
| include | ||
| kerberos5 | ||
| lib | ||
| libexec | ||
| release | ||
| rescue | ||
| sbin | ||
| secure | ||
| share | ||
| sys | ||
| targets | ||
| tests | ||
| tools | ||
| usr.bin | ||
| usr.sbin | ||
| .arcconfig | ||
| .arclint | ||
| COPYRIGHT | ||
| LOCKS | ||
| MAINTAINERS | ||
| Makefile | ||
| Makefile.inc1 | ||
| Makefile.libcompat | ||
| ObsoleteFiles.inc | ||
| README | ||
| UPDATING | ||
This is the top level of the FreeBSD source directory. This file was last revised on: $FreeBSD$ For copyright information, please see the file COPYRIGHT in this directory (additional copyright information also exists for some sources in this tree - please see the specific source directories for more information). The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7) and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html for more information, including setting make(1) variables. The `buildkernel` and `installkernel` targets build and install the kernel and the modules (see below). Please see the top of the Makefile in this directory for more information on the standard build targets and compile-time flags. Building a kernel is a somewhat more involved process. See build(7), config(8), and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information. Note: If you want to build and install the kernel with the `buildkernel` and `installkernel` targets, you might need to build world before. More information is available in the handbook. The kernel configuration files reside in the sys/<arch>/conf sub-directory. GENERIC is the default configuration used in release builds. NOTES contains entries and documentation for all possible devices, not just those commonly used. Source Roadmap: --------------- bin System/user commands. cddl Various commands and libraries under the Common Development and Distribution License. contrib Packages contributed by 3rd parties. crypto Cryptography stuff (see crypto/README). etc Template files for /etc. gnu Various commands and libraries under the GNU Public License. Please see gnu/COPYING* for more information. include System include files. kerberos5 Kerberos5 (Heimdal) package. lib System libraries. libexec System daemons. release Release building Makefile & associated tools. rescue Build system for statically linked /rescue utilities. sbin System commands. secure Cryptographic libraries and commands. share Shared resources. sys Kernel sources. tests Regression tests which can be run by Kyua. See tests/README for additional information. tools Utilities for regression testing and miscellaneous tasks. usr.bin User commands. usr.sbin System administration commands. For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see: http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html