Alexander Motin 9f6122a6e7 MFV r316893: ... 7604 if volblocksize property is the default, it displays as "-" rather than 8K illumos/illumos-gate@4d86c0eab2 4d86c0eab2 https://www.illumos.org/issues/7604 If a zvol has the default setting for the "volblocksize" property, it is 8KB. However, it is displayed as "-" (not present), rather than "8K". The problem was introduced by: commit 25228e830e86924a41243343b1de9daf2d7dd43a Author: Matthew Ahrens &lt;mahrens@delphix.com&gt; Date: Thu Nov 17 14:37:24 2016 -0800 7571 non-present readonly numeric ZFS props do not have default value which changed changed get_numeric_property() to indicate that readonly default properties are not present. However, zfs_prop_readonly() returns TRUE for both readonly and set-once properties (e.g. volblocksize). Amusingly, that commit essentially reverted: 6900484 default volblocksize is no longer being reported correctly from November 2009. However, that change was not correct either; the correct solution is to only do this check for "truly readonly" (i.e. not setonce) properties. $ zfs list -t volume -o name,volblocksize NAME VOLBLOCK domain0/group-100/appdata_container-101/appdata_windows_timeflow-102/ archive - domain0/group-100/appdata_container-101/appdata_windows_timeflow-102/ datafile - domain0/group-100/appdata_container-101/appdata_windows_timeflow-102/ external - rpool/dump 128K rpool/swap 4K rpool/swap1 =============================================================================== Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com> Reviewed by: Paul Dagnelie <pcd@delphix.com> Reviewed by: John Kennedy <john.kennedy@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Approved by: Robert Mustacchi <rm@joyent.com> Author: Matthew Ahrens <mahrens@delphix.com>		2018-02-20 20:34:04 +00:00
..
compat/opensolaris	Honor all options of "zfs mount -o"	2017-09-05 19:28:35 +00:00
contrib/opensolaris	MFV r316893:	2018-02-20 20:34:04 +00:00
lib	Add inline to errno.d for translating int to string	2018-02-16 04:22:29 +00:00
sbin	DIRDEPS_BUILD: Update dependencies.	2017-10-31 00:07:04 +00:00
tests	Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installed	2016-05-04 23:20:53 +00:00
usr.bin	Add basic tests for ctfconvert(1), fold(1) and rs(1)	2017-11-27 20:01:58 +00:00
usr.sbin	Optimize zfsd for the happy case	2018-02-15 21:30:30 +00:00
Makefile	Convert traditional ${MK_TESTS} conditional idiom for including test	2017-08-02 08:35:51 +00:00
Makefile.inc	Make DTrace stuff compile with C99 standard.	2014-08-22 20:04:51 +00:00