FreeBSD src
Go to file
Chuck Tuffli a1daa3ae5e bhyve: Fix NVMe data structure copy to guest
bhyve's NVMe emulation was transferring Identify data back to the guest
incorrectly causing memory corruptions. These corruptions resulted in
core dumps and other system level errors in the guest.

In their simplest form, NVMe Physical Region Page (PRP) values in
commands indicate which physical pages to use for data transfer. The
first PRP value is not required to be page aligned but does not cross a
page boundary. The second PRP value must be page aligned, does not cross
a page boundary, and need not be contiguous with PRP1.

The code was copying Identify data past the end of PRP1. This happens to
work if PRP1 and PRP2 are physically contiguous but will corrupt guest
memory in unpredictable ways if they are not.

Fix is to copy the Identify data back to the guest piecewise (i.e. for
each PRP entry). Also fix a similarly wrong problem when copying back
Log page data.

Reviewed by:	imp (mentor), araujo, jhb, rgrimes, bhyve
Approved by:	imp (mentor), bhyve (jhb)
MFC after:	2 weeks
Differential Revision: https://reviews.freebsd.org/D19695
2019-04-05 16:54:20 +00:00
bin .Xr trim(8) from dd(1). 2019-03-26 15:44:06 +00:00
cddl Ensure that we use a 64-bit value for the last mmap() argument. 2019-03-20 23:35:15 +00:00
contrib strings: capsicumize it 2019-04-04 16:32:27 +00:00
crypto Add workaround for a QoS-related bug in VMWare Workstation. 2019-03-27 15:17:29 +00:00
etc Compile and install most of the googletest examples 2019-03-11 19:50:44 +00:00
gnu Fix gdb/kgdb build under WITH_PIE 2019-04-01 19:19:51 +00:00
include Add verifying manifest loader for mac_veriexec 2019-02-26 06:17:23 +00:00
kerberos5 Add WITH_PIE knob to build Position Independent Executables 2019-02-15 22:22:38 +00:00
lib Add requiered programs (cc and c++) for some lib/atf regression tests 2019-04-04 20:34:17 +00:00
libexec random(4): Attempt to persist entropy promptly 2019-03-31 04:57:50 +00:00
release Add support for cross-building cloudware images. 2019-04-03 21:54:47 +00:00
rescue rescue: set NO_SHARED in Makefile 2018-11-19 22:18:18 +00:00
sbin Fix build. 2019-04-05 02:37:10 +00:00
secure Add workaround for a QoS-related bug in VMWare Workstation. 2019-03-27 15:17:29 +00:00
share Rewrite intro(4) man page. 2019-04-04 18:52:03 +00:00
stand Create kernel module to parse Veriexec manifest based on envs 2019-04-03 03:57:37 +00:00
sys vn_vmap_seekhole(): align running offset to the block boundary. 2019-04-05 16:14:16 +00:00
targets retire LINKER_FEATURES filter flag 2018-11-12 20:44:22 +00:00
tests Implement tests for online expansion: 2019-04-04 00:05:36 +00:00
tools Add cap_fileargs.h to -legacy if needed. 2019-04-04 04:14:20 +00:00
usr.bin sort(1): randomcoll: Skip the memory allocation entirely 2019-04-04 23:32:27 +00:00
usr.sbin bhyve: Fix NVMe data structure copy to guest 2019-04-05 16:54:20 +00:00
.arcconfig callsign isn't required anymore 2016-09-29 06:19:45 +00:00
.arclint arc lint: ignore /tests/ in chmod 2017-12-19 03:38:06 +00:00
.gitattributes MK_ZFS -> {MK_ZFS|MK_LOADER_ZFS}, this is so we can diable userland / kernel 2019-01-05 22:45:20 +00:00
.gitignore Ignore _.universe-toolchain file. 2018-07-01 13:50:37 +00:00
COPYRIGHT Happy New Year 2019! 2019-01-01 00:25:25 +00:00
LOCKS LOCKS: update current locks 2018-06-09 03:08:04 +00:00
MAINTAINERS Update maintainers for libunwind and lldb. 2019-03-16 13:26:42 +00:00
Makefile Update comment about 'universe' disk usage 2018-11-10 19:09:48 +00:00
Makefile.inc1 pkgbase: Use uname as ABI_FILE 2019-03-27 17:55:39 +00:00
Makefile.libcompat Use ...-freebsd13.0 in -target strings. 2018-11-12 16:55:20 +00:00
Makefile.sys.inc AUTO_OBJ: For all top-level targets enforce using an OBJDIR. 2017-12-05 21:29:47 +00:00
ObsoleteFiles.inc Set tentative merge date, and bump __FreeBSD_version. 2019-03-04 19:23:11 +00:00
README README: add generic notes about GENERIC and NOTES 2018-06-17 19:44:24 +00:00
README.md README: add generic notes about GENERIC and NOTES 2018-06-17 19:44:24 +00:00
UPDATING Add an entry to UPDATING for r345895, which affects the use of nfsuserd daemons 2019-04-04 23:40:30 +00:00

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html, and https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information, including setting make(1) variables.

Source Roadmap:

bin		System/user commands.

cddl		Various commands and libraries under the Common Development
		and Distribution License.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

stand		Boot loader sources.

sys		Kernel sources.

sys/<arch>/conf Kernel configuration files. GENERIC is the configuration
		used in release builds. NOTES contains documentation of
		all possible entries.

tests		Regression tests which can be run by Kyua.  See tests/README
		for additional information.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/current-stable.html