FreeBSD src
Go to file
Ed Maste a4f3f02be6 bsdgrep: fix -w flag matching with an empty pattern
-w flag matching with an empty pattern was generally 'broken', allowing
matches to occur on any line whether or not it actually matches -w
criteria.

This fix required a good amount of refactoring to address.  procline()
is altered to *only* process the line and return whether it was a match
or not, necessary to be able to short-circuit the whole function in case
of this matchall flag. -m flag handling is moved out as well because it
suffers from the same fate as context handling if we bypass any actual
pattern matching.

The matching context (matches, mostly) didn't previously exist outside
of procline(), so we go ahead and create context object for file
processing bits to pass around.  grep_printline() was created due to
this, for the scenarios where the matches don't actually matter and we
just want to print a line or two, a la flushing the context queue and
no -o or --color specified.

Damage from this broken behavior would have been mitigated by the fact
that it is unlikely users would invoke grep -w with an empty pattern.

This was identified while checking PR 105221 for problems it this may
cause in BSD grep, but PR 105221 is *not* a report of this behavior.

Submitted by:	Kyle Evans <kevans91 at ksu.edu>
Differential Revision:	https://reviews.freebsd.org/D10433
2017-05-02 20:39:33 +00:00
bin sh: Simplify handling of newlines in command substitution. 2017-04-28 16:16:22 +00:00
cddl MFV 316894 2017-04-25 17:57:43 +00:00
contrib bsdgrep: fix -w flag matching with an empty pattern 2017-05-02 20:39:33 +00:00
crypto Fix linking with lld by marking OPENSSL_armcap_P as hidden. 2017-04-07 12:41:57 +00:00
etc Remove NATM configuration bits and assorted NATM and ATM remnants. 2017-04-25 21:59:34 +00:00
gnu Add a new GDB_LIBEXEC option to install gdb and kgdb to /usr/libexec. 2017-04-25 18:08:56 +00:00
include <stdio.h>: ftello() and fseeko() were in SUSv2, so extend visibility. 2017-04-29 18:48:05 +00:00
kerberos5 kerberos5: normalize paths using SRCTOP-relative paths or :H when possible 2017-03-04 11:34:36 +00:00
lib Support clnt_raw's use of FD_SETSIZE as a fake file descriptor. 2017-05-01 20:04:07 +00:00
libexec - Remove 'struct vmmeter' from 'struct pcpu', leaving only global vmmeter 2017-04-17 17:34:47 +00:00
release More ATM and NATM removal 2017-04-27 16:05:12 +00:00
rescue More ATM and NATM removal 2017-04-27 16:05:12 +00:00
sbin Add ipfw table all destroy support. 2017-05-02 17:16:24 +00:00
secure Upgrade to OpenSSH 7.4p1. 2017-03-06 01:37:05 +00:00
share Document time_t size. 2017-05-02 14:52:35 +00:00
sys cxgbe(4): Support routines for Tx traffic scheduling. 2017-05-02 20:38:10 +00:00
targets META_MODE: add additional reachover relative paths to DIRDEPS_BUILD 2017-04-07 07:46:21 +00:00
tests Don't pass size_t arguments to setsockopt(SO_SNDBUF/SO_RCVBUF). 2017-04-28 17:58:15 +00:00
tools Fix build of tools/tools/umastat. 2017-04-26 17:58:10 +00:00
usr.bin bsdgrep: fix -w flag matching with an empty pattern 2017-05-02 20:39:33 +00:00
usr.sbin makefs: remove unused cd9660_defaults_set global 2017-05-01 00:53:07 +00:00
.arcconfig callsign isn't required anymore 2016-09-29 06:19:45 +00:00
.arclint
COPYRIGHT Bump copyright year. 2016-12-31 12:41:42 +00:00
LOCKS
MAINTAINERS Due to time constraints remove myself as a vmm(4) maintainer. 2017-04-15 22:42:23 +00:00
Makefile Cache compiler metadata and reuse it at installworld time. 2017-04-13 22:07:34 +00:00
Makefile.inc1 Replace again GNU diff with BSD diff 2017-04-20 19:24:51 +00:00
Makefile.libcompat META_MODE: Fix build-tools still sometimes rebuilding during target build. 2017-04-06 18:21:59 +00:00
ObsoleteFiles.inc Revert r317446 and bring back cy(4). 2017-04-27 16:14:32 +00:00
README README: remove nonexistent 'games' directory. 2016-05-18 10:43:13 +00:00
README.md Remove hard line breaks from README.md 2017-03-01 15:39:58 +00:00
UPDATING Revert r317432 and add a new entry for r316527. 2017-04-26 16:50:54 +00:00

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

For copyright information, please see the file COPYRIGHT in this directory (additional copyright information also exists for some sources in this tree - please see the specific source directories for more information).

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7) and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html for more information, including setting make(1) variables.

The buildkernel and installkernel targets build and install the kernel and the modules (see below). Please see the top of the Makefile in this directory for more information on the standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process. See build(7), config(8), and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information.

Note: If you want to build and install the kernel with the buildkernel and installkernel targets, you might need to build world before. More information is available in the handbook.

The kernel configuration files reside in the sys/<arch>/conf sub-directory. GENERIC is the default configuration used in release builds. NOTES contains entries and documentation for all possible devices, not just those commonly used.

Source Roadmap:

bin				System/user commands.

cddl			Various commands and libraries under the Common Development  
				and Distribution License.

contrib			Packages contributed by 3rd parties.

crypto			Cryptography stuff (see crypto/README).

etc				Template files for /etc.

gnu				Various commands and libraries under the GNU Public License.  
				Please see gnu/COPYING* for more information.

include			System include files.

kerberos5		Kerberos5 (Heimdal) package.

lib				System libraries.

libexec			System daemons.

release			Release building Makefile & associated tools.

rescue			Build system for statically linked /rescue utilities.

sbin			System commands.

secure			Cryptographic libraries and commands.

share			Shared resources.

sys				Kernel sources.

tests			Regression tests which can be run by Kyua.  See tests/README
				for additional information.

tools			Utilities for regression testing and miscellaneous tasks.

usr.bin			User commands.

usr.sbin		System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html