freebsd-dev/cmd
Håkan Johansson 5f20c145df Do not force VDEV_NAME_TYPE_ID in max_width()
Do not force VDEV_NAME_TYPE_ID in max_width(), instead add it
in the relevant calls to max_width().

The first location of max_width() where VDEV_NAME_TYPE_ID is
now added in show_import() is followed by print_import_config() and
print_logs().  Both these print children vdev names that have been
retrieved using an explicit VDEV_NAME_TYPE_ID added.

The second location is in status_callback().  This is followed by
print_status_config(), print_logs(), print_l2cache(), and
print_spares(). For l2cache and spares it should not matter as there
are no mirror-X or raidz-X involved.  print_status_config() as above
retrieves the name using explicit VDEV_NAME_TYPE_ID before
calling itself to print children.

The call of max_width() in get_namewidth() is not changed, as this is
used by zpool_do_iostat(), followed by print_iostat(), which does not
add VDEV_NAME_TYPE_ID.

Overall, we should consider adding VDEV_NAME_TYPE_ID to the
relevant name_flags / cb_name_flags fields, and remove the explicit
adding in called routines.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Haakan T Johansson <f96hajo@chalmers.se>
Closes #5401
2016-11-30 17:46:16 -07:00
..
arc_summary Correct style in arcstat and arc_summary 2016-10-06 10:04:54 -07:00
arcstat Correct exit code for dbufstat -v and arcstat -v 2016-10-06 10:52:21 -07:00
dbufstat Correct exit code for dbufstat -v and arcstat -v 2016-10-06 10:52:21 -07:00
fsck_zfs Add /sbin/fsck.zfs helper 2013-01-09 16:54:58 -08:00
mount_zfs Change /etc/mtab to /proc/self/mounts 2016-09-20 10:07:58 -07:00
raidz_test ABD raidz avx512f support 2016-11-29 14:34:33 -08:00
vdev_id Add extra keyword 'slot' to vdev_id.conf 2015-08-30 10:03:56 -07:00
zdb DLPX-44812 integrate EP-220 large memory scalability 2016-11-29 14:34:27 -08:00
zed Add -c to zpool iostat & status to run command 2016-11-29 14:45:38 -07:00
zfs Allow zfs unshare <protocol> -a 2016-11-29 12:22:38 -07:00
zhack Fix zhack argument processing 2016-08-31 14:32:46 -07:00
zinject Fix coverity defects: CID 147443, 147656, 147655, 147441, 147653 2016-09-29 13:33:09 -07:00
zpios Fix coverity defects: CID 147643, 152204, 49339 2016-10-18 10:43:22 -07:00
zpool Do not force VDEV_NAME_TYPE_ID in max_width() 2016-11-30 17:46:16 -07:00
zstreamdump zstreamdump needs to initialize fletcher 4 support 2016-11-29 14:47:05 -07:00
ztest DLPX-44812 integrate EP-220 large memory scalability 2016-11-29 14:34:27 -08:00
zvol_id OpenZFS 6314 - buffer overflow in dsl_dataset_name 2016-06-28 13:47:03 -07:00
Makefile.am SIMD implementation of vdev_raidz generate and reconstruct routines 2016-06-21 09:27:26 -07:00