b0d29bc47d
Having kyua in the base system will simplify automated testing in CI and eliminates bootstrapping issues on new platforms. The build of kyua is controlled by WITH(OUT)_TESTS_SUPPORT. Reviewed by: emaste Obtained from: CheriBSD Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D24103
96 lines
2.4 KiB
Awk
96 lines
2.4 KiB
Awk
# Copyright 2015 The Kyua Authors.
|
|
# All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions are
|
|
# met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in the
|
|
# documentation and/or other materials provided with the distribution.
|
|
# * Neither the name of Google Inc. nor the names of its contributors
|
|
# may be used to endorse or promote products derived from this software
|
|
# without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
function warn(msg) {
|
|
print FILENAME "[" FNR "]: " msg > "/dev/stderr"
|
|
error = 1
|
|
}
|
|
|
|
BEGIN {
|
|
skip = 0
|
|
error = 0
|
|
}
|
|
|
|
/CHECK_STYLE_DISABLE/ {
|
|
skip = 1
|
|
next
|
|
}
|
|
|
|
/CHECK_STYLE_ENABLE/ {
|
|
skip = 0
|
|
next
|
|
}
|
|
|
|
/CHECK_STYLE_(ENABLE|DISABLE)/ {
|
|
next
|
|
}
|
|
|
|
{
|
|
if (skip)
|
|
next
|
|
}
|
|
|
|
/^[ \t]*#/ {
|
|
next
|
|
}
|
|
|
|
/[$ \t]+_[a-zA-Z0-9]+=/ {
|
|
warn("Variable should not start with an underline")
|
|
}
|
|
|
|
/[^\\]\$[^0-9!'"$?@#*{}(|\/,]+/ {
|
|
warn("Missing braces around variable name")
|
|
}
|
|
|
|
/=(""|'')/ {
|
|
warn("Assignment to the empty string does not need quotes");
|
|
}
|
|
|
|
/basename[ \t]+/ {
|
|
warn("Use parameter expansion instead of basename");
|
|
}
|
|
|
|
/if[ \t]+(test|![ \t]+test)/ {
|
|
warn("Use [ instead of test");
|
|
}
|
|
|
|
/[ \t]+(test|\[).*==/ {
|
|
warn("test(1)'s == operator is not portable");
|
|
}
|
|
|
|
/if.*;[ \t]*fi$/ {
|
|
warn("Avoid using a single-line if conditional");
|
|
}
|
|
|
|
END {
|
|
if (skip)
|
|
warn("Missing CHECK_STYLE_ENABLE");
|
|
if (error)
|
|
exit 1
|
|
}
|