FreeBSD src
Go to file
Andriy Gapon b4e4140d13 MFV r322223: 8378 crash due to bp in-memory modification of nopwrite block
illumos/illumos-gate@b7edcb9408
b7edcb9408

https://www.illumos.org/issues/8378
  The problem is that zfs_get_data() supplies a stale zgd_bp to dmu_sync(), which
  we then nopwrite against.
  zfs_get_data() doesn't hold any DMU-related locks, so after it copies db_blkptr
  to zgd_bp, dbuf_write_ready()
  could change db_blkptr, and dbuf_write_done() could remove the dirty record.
  dmu_sync() then sees the stale
  BP and that the dbuf it not dirty, so it is eligible for nop-writing.
  The fix is for dmu_sync() to copy db_blkptr to zgd_bp after acquiring the
  db_mtx. We could still see a stale
  db_blkptr, but if it is stale then the dirty record will still exist and thus
  we won't attempt to nopwrite.

Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Author: Matthew Ahrens <mahrens@delphix.com>

MFC after:	2 weeks
2017-08-08 10:46:51 +00:00
bin pgrep naively appends the delimiter to all PIDs including the last 2017-08-08 00:31:10 +00:00
cddl MFV r322223: 8378 crash due to bp in-memory modification of nopwrite block 2017-08-08 10:46:51 +00:00
contrib regex(3): Handle invalid {} constructs consistently and adjust tests 2017-08-08 04:10:46 +00:00
crypto Upgrade to OpenSSH 7.5p1. 2017-08-04 12:57:24 +00:00
etc hyperv: Add VF bringup scripts and devd rules. 2017-07-31 07:18:15 +00:00
gnu Convert traditional ${MK_TESTS} conditional idiom for including test 2017-08-02 08:35:51 +00:00
include An MMC/SD/SDIO stack using CAM 2017-07-09 16:57:24 +00:00
kerberos5 Remove dead target introduced in r178828. 2017-08-06 06:35:40 +00:00
lib 8418 zfs_prop_get_table() call in zfs_validate_name() is a no-op 2017-08-08 10:28:01 +00:00
libexec o Replace __riscv__ with __riscv 2017-08-07 14:09:57 +00:00
release Revert r321659, re-enabling ChallengeResponseAuthentication, which was 2017-07-28 18:46:02 +00:00
rescue DIRDEPS_BUILD: Update dependencies. 2017-05-09 01:48:23 +00:00
sbin In debug mode, print the differences between the superblock and 2017-08-07 21:23:59 +00:00
secure Convert traditional ${MK_TESTS} conditional idiom for including test 2017-08-02 08:35:51 +00:00
share Expose API to allow disks to ask for alias names in devfs. 2017-08-07 21:12:38 +00:00
sys MFV r322223: 8378 crash due to bp in-memory modification of nopwrite block 2017-08-08 10:46:51 +00:00
targets Update targets/pseudo/tests/Makefile.depend after recent additions/subtractions 2017-07-19 16:45:57 +00:00
tests Make test scripts under tests/... non-executable 2017-08-08 04:59:16 +00:00
tools zfsboottest: catch up with r316585 and provide ldi_get_size method 2017-08-01 11:09:18 +00:00
usr.bin Respect SIMPLE_BACKUP_SUFFIX environment variable in indent(1) 2017-08-07 18:01:27 +00:00
usr.sbin Revert the parts of r322097 related to /etc/wall_cmos_clock handling as 2017-08-07 21:38:10 +00:00
.arcconfig callsign isn't required anymore 2016-09-29 06:19:45 +00:00
.arclint phabricator related changes: 2015-04-20 20:33:22 +00:00
COPYRIGHT Bump copyright year. 2016-12-31 12:41:42 +00:00
LOCKS
MAINTAINERS Add asomers as a pjdfstest co-maintainer per the project status change 2017-06-28 09:25:15 +00:00
Makefile genericize target exclusion for missing external toolchain 2017-07-27 12:29:31 +00:00
Makefile.inc1 Follow-up to r321684 (Don't use libc++ when cross-building for gcc 2017-08-07 16:23:53 +00:00
Makefile.libcompat Follow-up to r321684 (Don't use libc++ when cross-building for gcc 2017-08-07 16:23:53 +00:00
ObsoleteFiles.inc Rework and simplify the ksyms(4) implementation. 2017-08-03 00:38:13 +00:00
README Vendor import of OpenSSH 7.5p1. 2017-08-03 10:10:20 +00:00
README.md Remove hard line breaks from README.md 2017-03-01 15:39:58 +00:00
UPDATING UPDATING: clarify what the RCMDS knob controls 2017-08-07 21:29:55 +00:00

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

For copyright information, please see the file COPYRIGHT in this directory (additional copyright information also exists for some sources in this tree - please see the specific source directories for more information).

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7) and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html for more information, including setting make(1) variables.

The buildkernel and installkernel targets build and install the kernel and the modules (see below). Please see the top of the Makefile in this directory for more information on the standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process. See build(7), config(8), and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information.

Note: If you want to build and install the kernel with the buildkernel and installkernel targets, you might need to build world before. More information is available in the handbook.

The kernel configuration files reside in the sys/<arch>/conf sub-directory. GENERIC is the default configuration used in release builds. NOTES contains entries and documentation for all possible devices, not just those commonly used.

Source Roadmap:

bin				System/user commands.

cddl			Various commands and libraries under the Common Development  
				and Distribution License.

contrib			Packages contributed by 3rd parties.

crypto			Cryptography stuff (see crypto/README).

etc				Template files for /etc.

gnu				Various commands and libraries under the GNU Public License.  
				Please see gnu/COPYING* for more information.

include			System include files.

kerberos5		Kerberos5 (Heimdal) package.

lib				System libraries.

libexec			System daemons.

release			Release building Makefile & associated tools.

rescue			Build system for statically linked /rescue utilities.

sbin			System commands.

secure			Cryptographic libraries and commands.

share			Shared resources.

sys				Kernel sources.

tests			Regression tests which can be run by Kyua.  See tests/README
				for additional information.

tools			Utilities for regression testing and miscellaneous tasks.

usr.bin			User commands.

usr.sbin		System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html