ea5eee641e
In integrity mode, a larger logical sector (e.g., 4096 bytes) spans several physical sectors (e.g., 512 bytes) on the backing device. Due to hash overhead, a 4096 byte logical sector takes 8.5625 512-byte physical sectors. This means that only 288 bytes (256 data + 32 hash) of the last 512 byte sector are used. The memory allocation used to store the encrypted data to be written to the physical sectors comes from malloc(9) and does not use M_ZERO. Previously, nothing initialized the final physical sector backing each logical sector, aside from the hash + encrypted data portion. So 224 bytes of kernel heap memory was leaked to every block :-(. This patch addresses the issue by initializing the trailing portion of the physical sector in every logical sector to zeros before use. A much simpler but higher overhead fix would be to tag the entire allocation M_ZERO. PR: 222077 Reported by: Maxim Khitrov <max AT mxcrypt.com> Reviewed by: emaste Security: yes Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D12272 |
||
|---|---|---|
| .. | ||
| bde | ||
| cache | ||
| concat | ||
| eli | ||
| gate | ||
| journal | ||
| label | ||
| linux_lvm | ||
| mirror | ||
| mountver | ||
| multipath | ||
| nop | ||
| part | ||
| raid | ||
| raid3 | ||
| sched | ||
| shsec | ||
| stripe | ||
| uzip | ||
| vinum | ||
| virstor | ||
| zero | ||
| geom_aes.c | ||
| geom_bsd_enc.c | ||
| geom_bsd.c | ||
| geom_ccd.c | ||
| geom_ctl.c | ||
| geom_ctl.h | ||
| geom_dev.c | ||
| geom_disk.c | ||
| geom_disk.h | ||
| geom_dump.c | ||
| geom_event.c | ||
| geom_flashmap.c | ||
| geom_fox.c | ||
| geom_int.h | ||
| geom_io.c | ||
| geom_kern.c | ||
| geom_map.c | ||
| geom_mbr_enc.c | ||
| geom_mbr.c | ||
| geom_redboot.c | ||
| geom_slice.c | ||
| geom_slice.h | ||
| geom_subr.c | ||
| geom_sunlabel_enc.c | ||
| geom_sunlabel.c | ||
| geom_vfs.c | ||
| geom_vfs.h | ||
| geom_vol_ffs.c | ||
| geom.h | ||
| notes | ||