FreeBSD src
b7a652ab84
complained so it cannot be entirely bad :-) I include the email that probably explains it for people who already know: > >Compiling with -O3 inlines functions. However the function that is being > >inlined in makeinfo.c (add_word_args()) is a vararg function and must not be > >inlined. > > > >The code in question is K&R style, and AFIK, there is no way for the compiler > >to determine that the function uses vararg. Either change the code to use > >prototypes, or use stdarg, or add a directive to prevent inlining. > > Not declaring a varargs function as varargs before it is used gives > undefined behaviour. > > However, in practice the bug is probably in FreeBSD's <varargs.h>, which > doesn't use gcc's __builtin_next_arg(). gcc should notice that it is > used and not inline functions that have it. <stdarg.h.> uses it, but I > think there's another gcc builtin that it should be using. Patch attached. The ellipsis causes gcc to flag this as a varargs function, and the name "__builtin_va_alist" is special cased in gcc to hide the last argument in the arglist. Reviewed by: bde & phk Submitted by: jlemon@americantv.com (Jonathan Lemon) |
||
|---|---|---|
| bin | ||
| contrib | ||
| eBones | ||
| etc | ||
| games | ||
| gnu | ||
| include | ||
| lib | ||
| libexec | ||
| lkm | ||
| release | ||
| sbin | ||
| secure | ||
| share | ||
| sys | ||
| tools | ||
| usr.bin | ||
| usr.sbin | ||
| COPYRIGHT | ||
| Makefile | ||
| README | ||
This is the top level of the FreeBSD source directory. This file was last revised on: $FreeBSD$ For copyright information, please see the file COPYRIGHT in this directory (additional copyright information also exists for some sources in this tree - please see the specific source directories for more information). The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree, the most commonly used one being ``world'', which rebuilds and installs everything in the FreeBSD system from the source tree except the kernel. Please see the top of the Makefile for more information on the standard build targets and compile-time flags. Building a kernel with config(8) is a somewhat more involved process, documentation for which can be found at: http://www.freebsd.org/handbook/kernelconfig.html And in the config(8) man page. The sample kernel configuration files reside in the sys/i386/conf sub-directory (assuming that you've installed the kernel sources), the file named GENERIC being the one used to build your initial installation kernel. The file LINT contains entries for all possible devices, not just those commonly used, and is meant more as a general reference than an actual kernel configuration file (a kernel built from it wouldn't even run). Source Roadmap: --------------- bin System/User commands. contrib Packages contributed by 3rd parties. eBones Kerberos package - NOT FOR EXPORT! etc Template files for /etc games Amusements. gnu Various commands and libraries under the GNU Public License. Please see gnu/COPYING* for more information. include System include files. lib System libraries. libexec System daemons. lkm Loadable Kernel Modules. release Release building Makefile & associated tools. sbin System commands. secure DES and DES-related utilities - NOT FOR EXPORT! share Shared resources. sys Kernel sources. tools Utilities for regression testing and miscellaneous tasks. usr.bin User commands. usr.sbin System administration commands. For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see: http://www.freebsd.org/handbook/synching.html