ab8d9c1783
Various module parameters such as `zfs_arc_max` were originally `uint64_t` on OpenSolaris/Illumos, but were changed to `unsigned long` for Linux compatibility because Linux's kernel default module parameter implementation did not support 64-bit types on 32-bit platforms. This caused problems when porting OpenZFS to Windows because its LLP64 memory model made `unsigned long` a 32-bit type on 64-bit, which created the undesireable situation that parameters that should accept 64-bit values could not on 64-bit Windows. Upon inspection, it turns out that the Linux kernel module parameter interface is extensible, such that we are allowed to define our own types. Rather than maintaining the original type change via hacks to to continue shrinking module parameters on 32-bit Linux, we implement support for 64-bit module parameters on Linux. After doing a review of all 64-bit kernel parameters (found via the man page and also proposed changes by Andrew Innes), the kernel module parameters fell into a few groups: Parameters that were originally 64-bit on Illumos: * dbuf_cache_max_bytes * dbuf_metadata_cache_max_bytes * l2arc_feed_min_ms * l2arc_feed_secs * l2arc_headroom * l2arc_headroom_boost * l2arc_write_boost * l2arc_write_max * metaslab_aliquot * metaslab_force_ganging * zfetch_array_rd_sz * zfs_arc_max * zfs_arc_meta_limit * zfs_arc_meta_min * zfs_arc_min * zfs_async_block_max_blocks * zfs_condense_max_obsolete_bytes * zfs_condense_min_mapping_bytes * zfs_deadman_checktime_ms * zfs_deadman_synctime_ms * zfs_initialize_chunk_size * zfs_initialize_value * zfs_lua_max_instrlimit * zfs_lua_max_memlimit * zil_slog_bulk Parameters that were originally 32-bit on Illumos: * zfs_per_txg_dirty_frees_percent Parameters that were originally `ssize_t` on Illumos: * zfs_immediate_write_sz Note that `ssize_t` is `int32_t` on 32-bit and `int64_t` on 64-bit. It has been upgraded to 64-bit. Parameters that were `long`/`unsigned long` because of Linux/FreeBSD influence: * l2arc_rebuild_blocks_min_l2size * zfs_key_max_salt_uses * zfs_max_log_walking * zfs_max_logsm_summary_length * zfs_metaslab_max_size_cache_sec * zfs_min_metaslabs_to_flush * zfs_multihost_interval * zfs_unflushed_log_block_max * zfs_unflushed_log_block_min * zfs_unflushed_log_block_pct * zfs_unflushed_max_mem_amt * zfs_unflushed_max_mem_ppm New parameters that do not exist in Illumos: * l2arc_trim_ahead * vdev_file_logical_ashift * vdev_file_physical_ashift * zfs_arc_dnode_limit * zfs_arc_dnode_limit_percent * zfs_arc_dnode_reduce_percent * zfs_arc_meta_limit_percent * zfs_arc_sys_free * zfs_deadman_ziotime_ms * zfs_delete_blocks * zfs_history_output_max * zfs_livelist_max_entries * zfs_max_async_dedup_frees * zfs_max_nvlist_src_size * zfs_rebuild_max_segment * zfs_rebuild_vdev_limit * zfs_unflushed_log_txg_max * zfs_vdev_max_auto_ashift * zfs_vdev_min_auto_ashift * zfs_vnops_read_chunk_size * zvol_max_discard_blocks Rather than clutter the lists with commentary, the module parameters that need comments are repeated below. A few parameters were defined in Linux/FreeBSD specific code, where the use of ulong/long is not an issue for portability, so we leave them alone: * zfs_delete_blocks * zfs_key_max_salt_uses * zvol_max_discard_blocks The documentation for a few parameters was found to be incorrect: * zfs_deadman_checktime_ms - incorrectly documented as int * zfs_delete_blocks - not documented as Linux only * zfs_history_output_max - incorrectly documented as int * zfs_vnops_read_chunk_size - incorrectly documented as long * zvol_max_discard_blocks - incorrectly documented as ulong The documentation for these has been fixed, alongside the changes to document the switch to fixed width types. In addition, several kernel module parameters were percentages or held ashift values, so being 64-bit never made sense for them. They have been downgraded to 32-bit: * vdev_file_logical_ashift * vdev_file_physical_ashift * zfs_arc_dnode_limit_percent * zfs_arc_dnode_reduce_percent * zfs_arc_meta_limit_percent * zfs_per_txg_dirty_frees_percent * zfs_unflushed_log_block_pct * zfs_vdev_max_auto_ashift * zfs_vdev_min_auto_ashift Of special note are `zfs_vdev_max_auto_ashift` and `zfs_vdev_min_auto_ashift`, which were already defined as `uint64_t`, and passed to the kernel as `ulong`. This is inherently buggy on big endian 32-bit Linux, since the values would not be written to the correct locations. 32-bit FreeBSD was unaffected because its sysctl code correctly treated this as a `uint64_t`. Lastly, a code comment suggests that `zfs_arc_sys_free` is Linux-specific, but there is nothing to indicate to me that it is Linux-specific. Nothing was done about that. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Jorgen Lundman <lundman@lundman.net> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Original-patch-by: Andrew Innes <andrew.c12@gmail.com> Original-patch-by: Jorgen Lundman <lundman@lundman.net> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #13984 Closes #14004
129 lines
4.2 KiB
C
129 lines
4.2 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License (the "License").
|
|
* You may not use this file except in compliance with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or https://opensource.org/licenses/CDDL-1.0.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
/*
|
|
* Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
|
|
* Copyright (c) 2018, 2019 by Delphix. All rights reserved.
|
|
*/
|
|
|
|
#ifndef _SYS_DSL_DEADLIST_H
|
|
#define _SYS_DSL_DEADLIST_H
|
|
|
|
#include <sys/bpobj.h>
|
|
#include <sys/zfs_context.h>
|
|
#include <sys/zthr.h>
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif
|
|
|
|
struct dmu_buf;
|
|
struct dsl_pool;
|
|
struct dsl_dataset;
|
|
|
|
typedef struct dsl_deadlist_phys {
|
|
uint64_t dl_used;
|
|
uint64_t dl_comp;
|
|
uint64_t dl_uncomp;
|
|
uint64_t dl_pad[37]; /* pad out to 320b for future expansion */
|
|
} dsl_deadlist_phys_t;
|
|
|
|
typedef struct dsl_deadlist {
|
|
objset_t *dl_os;
|
|
uint64_t dl_object;
|
|
avl_tree_t dl_tree; /* contains dsl_deadlist_entry_t */
|
|
avl_tree_t dl_cache; /* contains dsl_deadlist_cache_entry_t */
|
|
boolean_t dl_havetree;
|
|
boolean_t dl_havecache;
|
|
struct dmu_buf *dl_dbuf;
|
|
dsl_deadlist_phys_t *dl_phys;
|
|
kmutex_t dl_lock;
|
|
|
|
/* if it's the old on-disk format: */
|
|
bpobj_t dl_bpobj;
|
|
boolean_t dl_oldfmt;
|
|
} dsl_deadlist_t;
|
|
|
|
typedef struct dsl_deadlist_cache_entry {
|
|
avl_node_t dlce_node;
|
|
uint64_t dlce_mintxg;
|
|
uint64_t dlce_bpobj;
|
|
uint64_t dlce_bytes;
|
|
uint64_t dlce_comp;
|
|
uint64_t dlce_uncomp;
|
|
} dsl_deadlist_cache_entry_t;
|
|
|
|
typedef struct dsl_deadlist_entry {
|
|
avl_node_t dle_node;
|
|
uint64_t dle_mintxg;
|
|
bpobj_t dle_bpobj;
|
|
} dsl_deadlist_entry_t;
|
|
|
|
typedef struct livelist_condense_entry {
|
|
struct dsl_dataset *ds;
|
|
dsl_deadlist_entry_t *first;
|
|
dsl_deadlist_entry_t *next;
|
|
boolean_t syncing;
|
|
boolean_t cancelled;
|
|
} livelist_condense_entry_t;
|
|
|
|
extern uint64_t zfs_livelist_max_entries;
|
|
extern int zfs_livelist_min_percent_shared;
|
|
|
|
typedef int deadlist_iter_t(void *args, dsl_deadlist_entry_t *dle);
|
|
|
|
void dsl_deadlist_open(dsl_deadlist_t *dl, objset_t *os, uint64_t object);
|
|
void dsl_deadlist_close(dsl_deadlist_t *dl);
|
|
void dsl_deadlist_iterate(dsl_deadlist_t *dl, deadlist_iter_t func, void *arg);
|
|
uint64_t dsl_deadlist_alloc(objset_t *os, dmu_tx_t *tx);
|
|
void dsl_deadlist_free(objset_t *os, uint64_t dlobj, dmu_tx_t *tx);
|
|
void dsl_deadlist_insert(dsl_deadlist_t *dl, const blkptr_t *bp,
|
|
boolean_t free, dmu_tx_t *tx);
|
|
int dsl_deadlist_insert_alloc_cb(void *arg, const blkptr_t *bp, dmu_tx_t *tx);
|
|
int dsl_deadlist_insert_free_cb(void *arg, const blkptr_t *bp, dmu_tx_t *tx);
|
|
void dsl_deadlist_add_key(dsl_deadlist_t *dl, uint64_t mintxg, dmu_tx_t *tx);
|
|
void dsl_deadlist_remove_key(dsl_deadlist_t *dl, uint64_t mintxg, dmu_tx_t *tx);
|
|
void dsl_deadlist_remove_entry(dsl_deadlist_t *dl, uint64_t mintxg,
|
|
dmu_tx_t *tx);
|
|
dsl_deadlist_entry_t *dsl_deadlist_first(dsl_deadlist_t *dl);
|
|
dsl_deadlist_entry_t *dsl_deadlist_last(dsl_deadlist_t *dl);
|
|
uint64_t dsl_deadlist_clone(dsl_deadlist_t *dl, uint64_t maxtxg,
|
|
uint64_t mrs_obj, dmu_tx_t *tx);
|
|
void dsl_deadlist_space(dsl_deadlist_t *dl,
|
|
uint64_t *usedp, uint64_t *compp, uint64_t *uncompp);
|
|
void dsl_deadlist_space_range(dsl_deadlist_t *dl,
|
|
uint64_t mintxg, uint64_t maxtxg,
|
|
uint64_t *usedp, uint64_t *compp, uint64_t *uncompp);
|
|
void dsl_deadlist_merge(dsl_deadlist_t *dl, uint64_t obj, dmu_tx_t *tx);
|
|
void dsl_deadlist_move_bpobj(dsl_deadlist_t *dl, bpobj_t *bpo, uint64_t mintxg,
|
|
dmu_tx_t *tx);
|
|
boolean_t dsl_deadlist_is_open(dsl_deadlist_t *dl);
|
|
int dsl_process_sub_livelist(bpobj_t *bpobj, struct bplist *to_free,
|
|
zthr_t *t, uint64_t *size);
|
|
void dsl_deadlist_clear_entry(dsl_deadlist_entry_t *dle, dsl_deadlist_t *dl,
|
|
dmu_tx_t *tx);
|
|
void dsl_deadlist_discard_tree(dsl_deadlist_t *dl);
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif
|
|
|
|
#endif /* _SYS_DSL_DEADLIST_H */
|