1f960e646b
In a VF's configuration space, "memory space enable" is hard-wired to 0,
so the existing implementation always returns false. We need to read
the SR-IOV control register from the PF device to get the value of the
MSE bit.
Fix pci_bar_enabled() to read this register instead for VFs. I don't
see any way to access the PF's config space without a backpointer in the
pci device ivars, so I added one.
This fixes a regression where bhyve(8) fails to map the MSI-X table
after commit 7fa2335347 ("bhyve: Map the MSI-X table unconditionally
for passthrough") when a VF is passed through, since with that commit we
use PCIOCBARMMAP to map the table and that ioctl always fails for VFs
without this change. As a bonus, pciconf(8) now correctly reports the
enablement of BARs for VFs.
Reported and tested by: Raúl Muñoz <raul.munoz@custos.es>
Reviewed by: rstone, jhb
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D32839
63 lines
2.0 KiB
C
63 lines
2.0 KiB
C
/*-
|
|
* Copyright (c) 2013-2015 Sandvine Inc.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*
|
|
* $FreeBSD$
|
|
*/
|
|
|
|
#ifndef _PCI_IOV_PRIVATE_H_
|
|
#define _PCI_IOV_PRIVATE_H_
|
|
|
|
struct pci_iov_bar {
|
|
struct resource *res;
|
|
|
|
pci_addr_t bar_size;
|
|
pci_addr_t bar_shift;
|
|
};
|
|
|
|
struct pcicfg_iov {
|
|
device_t iov_pf;
|
|
struct cdev *iov_cdev;
|
|
nvlist_t *iov_schema;
|
|
|
|
struct pci_iov_bar iov_bar[PCIR_MAX_BAR_0 + 1];
|
|
struct rman rman;
|
|
char rman_name[64];
|
|
|
|
int iov_pos;
|
|
int iov_num_vfs;
|
|
uint32_t iov_flags;
|
|
|
|
uint16_t iov_ctl;
|
|
uint32_t iov_page_size;
|
|
};
|
|
|
|
#define IOV_RMAN_INITED 0x0001
|
|
#define IOV_BUSY 0x0002
|
|
|
|
void pci_iov_cfg_restore(device_t dev, struct pci_devinfo *dinfo);
|
|
void pci_iov_cfg_save(device_t dev, struct pci_devinfo *dinfo);
|
|
|
|
#endif
|