c208cb9923
With GNU ifuncs, multiple FBT probes may correspond to the same instruction. fbt_invop() assumed that this could not happen and would return after the first probe found in the global FBT hash table, which might not be the one that's enabled. Fix the problem on x86 by linking probes that share a tracepoint and having each linked probe fire when the tracepoint is hit. PR: 230846 Approved by: re (gjb) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D16921
164 lines
3.9 KiB
C
164 lines
3.9 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License (the "License").
|
|
* You may not use this file except in compliance with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or http://www.opensolaris.org/os/licensing.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*
|
|
* Portions Copyright 2006-2008 John Birrell jb@freebsd.org
|
|
* Portions Copyright 2013 Justin Hibbits jhibbits@freebsd.org
|
|
* Portions Copyright 2013 Howard Su howardsu@freebsd.org
|
|
* Portions Copyright 2016 Ruslan Bukin <br@bsdpad.com>
|
|
*
|
|
* $FreeBSD$
|
|
*/
|
|
|
|
/*
|
|
* Copyright 2006 Sun Microsystems, Inc. All rights reserved.
|
|
* Use is subject to license terms.
|
|
*/
|
|
|
|
#include <sys/cdefs.h>
|
|
#include <sys/param.h>
|
|
|
|
#include <sys/dtrace.h>
|
|
|
|
#include <machine/riscvreg.h>
|
|
|
|
#include "fbt.h"
|
|
|
|
#define FBT_PATCHVAL (RISCV_INSN_BREAK)
|
|
#define FBT_ENTRY "entry"
|
|
#define FBT_RETURN "return"
|
|
|
|
int
|
|
fbt_invop(uintptr_t addr, struct trapframe *frame, uintptr_t rval)
|
|
{
|
|
solaris_cpu_t *cpu;
|
|
fbt_probe_t *fbt;
|
|
|
|
cpu = &solaris_cpu[curcpu];
|
|
fbt = fbt_probetab[FBT_ADDR2NDX(addr)];
|
|
|
|
for (; fbt != NULL; fbt = fbt->fbtp_hashnext) {
|
|
if ((uintptr_t)fbt->fbtp_patchpoint == addr) {
|
|
cpu->cpu_dtrace_caller = addr;
|
|
|
|
dtrace_probe(fbt->fbtp_id, frame->tf_a[0],
|
|
frame->tf_a[1], frame->tf_a[2],
|
|
frame->tf_a[3], frame->tf_a[4]);
|
|
|
|
cpu->cpu_dtrace_caller = 0;
|
|
return (fbt->fbtp_savedval);
|
|
}
|
|
}
|
|
|
|
return (0);
|
|
}
|
|
|
|
void
|
|
fbt_patch_tracepoint(fbt_probe_t *fbt, fbt_patchval_t val)
|
|
{
|
|
|
|
*fbt->fbtp_patchpoint = val;
|
|
cpu_icache_sync_range((vm_offset_t)fbt->fbtp_patchpoint, 4);
|
|
}
|
|
|
|
int
|
|
fbt_provide_module_function(linker_file_t lf, int symindx,
|
|
linker_symval_t *symval, void *opaque)
|
|
{
|
|
fbt_probe_t *fbt, *retfbt;
|
|
uint32_t *instr, *limit;
|
|
const char *name;
|
|
char *modname;
|
|
|
|
modname = opaque;
|
|
name = symval->name;
|
|
|
|
/* Check if function is excluded from instrumentation */
|
|
if (fbt_excluded(name))
|
|
return (0);
|
|
|
|
instr = (uint32_t *)(symval->value);
|
|
limit = (uint32_t *)(symval->value + symval->size);
|
|
|
|
/* Look for sd operation */
|
|
for (; instr < limit; instr++) {
|
|
if ((*instr & SD_RA_SP_MASK) == SD_RA_SP)
|
|
break;
|
|
}
|
|
|
|
if (instr >= limit)
|
|
return (0);
|
|
|
|
fbt = malloc(sizeof (fbt_probe_t), M_FBT, M_WAITOK | M_ZERO);
|
|
fbt->fbtp_name = name;
|
|
fbt->fbtp_id = dtrace_probe_create(fbt_id, modname,
|
|
name, FBT_ENTRY, 3, fbt);
|
|
fbt->fbtp_patchpoint = instr;
|
|
fbt->fbtp_ctl = lf;
|
|
fbt->fbtp_loadcnt = lf->loadcnt;
|
|
fbt->fbtp_savedval = *instr;
|
|
fbt->fbtp_patchval = FBT_PATCHVAL;
|
|
fbt->fbtp_rval = DTRACE_INVOP_SD;
|
|
fbt->fbtp_symindx = symindx;
|
|
|
|
fbt->fbtp_hashnext = fbt_probetab[FBT_ADDR2NDX(instr)];
|
|
fbt_probetab[FBT_ADDR2NDX(instr)] = fbt;
|
|
|
|
lf->fbt_nentries++;
|
|
|
|
retfbt = NULL;
|
|
again:
|
|
for (; instr < limit; instr++) {
|
|
if (*instr == RISCV_INSN_RET)
|
|
break;
|
|
}
|
|
|
|
if (instr >= limit)
|
|
return (0);
|
|
|
|
/*
|
|
* We have a winner!
|
|
*/
|
|
fbt = malloc(sizeof (fbt_probe_t), M_FBT, M_WAITOK | M_ZERO);
|
|
fbt->fbtp_name = name;
|
|
if (retfbt == NULL) {
|
|
fbt->fbtp_id = dtrace_probe_create(fbt_id, modname,
|
|
name, FBT_RETURN, 3, fbt);
|
|
} else {
|
|
retfbt->fbtp_probenext = fbt;
|
|
fbt->fbtp_id = retfbt->fbtp_id;
|
|
}
|
|
retfbt = fbt;
|
|
|
|
fbt->fbtp_patchpoint = instr;
|
|
fbt->fbtp_ctl = lf;
|
|
fbt->fbtp_loadcnt = lf->loadcnt;
|
|
fbt->fbtp_symindx = symindx;
|
|
fbt->fbtp_rval = DTRACE_INVOP_RET;
|
|
fbt->fbtp_savedval = *instr;
|
|
fbt->fbtp_patchval = FBT_PATCHVAL;
|
|
fbt->fbtp_hashnext = fbt_probetab[FBT_ADDR2NDX(instr)];
|
|
fbt_probetab[FBT_ADDR2NDX(instr)] = fbt;
|
|
|
|
lf->fbt_nentries++;
|
|
|
|
instr++;
|
|
goto again;
|
|
}
|