6520495abc
This is based on work done by jeff@ and jhb@, as well as the numa.diff patch that has been circulating when someone asks for first-touch NUMA on -10 or -11. * Introduce a simple set of VM policy and iterator types. * tie the policy types into the vm_phys path for now, mirroring how the initial first-touch allocation work was enabled. * add syscalls to control changing thread and process defaults. * add a global NUMA VM domain policy. * implement a simple cascade policy order - if a thread policy exists, use it; if a process policy exists, use it; use the default policy. * processes inherit policies from their parent processes, threads inherit policies from their parent threads. * add a simple tool (numactl) to query and modify default thread/process policities. * add documentation for the new syscalls, for numa and for numactl. * re-enable first touch NUMA again by default, as now policies can be set in a variety of methods. This is only relevant for very specific workloads. This doesn't pretend to be a final NUMA solution. The previous defaults in -HEAD (with MAXMEMDOM set) can be achieved by 'sysctl vm.default_policy=rr'. This is only relevant if MAXMEMDOM is set to something other than 1. Ie, if you're using GENERIC or a modified kernel with non-NUMA, then this is a glorified no-op for you. Thank you to Norse Corp for giving me access to rather large (for FreeBSD!) NUMA machines in order to develop and verify this. Thank you to Dell for providing me with dual socket sandybridge and westmere v3 hardware to do NUMA development with. Thank you to Scott Long at Netflix for providing me with access to the two-socket, four-domain haswell v3 hardware. Thank you to Peter Holm for running the stress testing suite against the NUMA branch during various stages of development! Tested: * MIPS (regression testing; non-NUMA) * i386 (regression testing; non-NUMA GENERIC) * amd64 (regression testing; non-NUMA GENERIC) * westmere, 2 socket (thankyou norse!) * sandy bridge, 2 socket (thankyou dell!) * ivy bridge, 2 socket (thankyou norse!) * westmere-EX, 4 socket / 1TB RAM (thankyou norse!) * haswell, 2 socket (thankyou norse!) * haswell v3, 2 socket (thankyou dell) * haswell v3, 2x18 core (thankyou scott long / netflix!) * Peter Holm ran a stress test suite on this work and found one issue, but has not been able to verify it (it doesn't look NUMA related, and he only saw it once over many testing runs.) * I've tested bhyve instances running in fixed NUMA domains and cpusets; all seems to work correctly. Verified: * intel-pcm - pcm-numa.x and pcm-memory.x, whilst selecting different NUMA policies for processes under test. Review: This was reviewed through phabricator (https://reviews.freebsd.org/D2559) as well as privately and via emails to freebsd-arch@. The git history with specific attributes is available at https://github.com/erikarn/freebsd/ in the NUMA branch (https://github.com/erikarn/freebsd/compare/local/adrian_numa_policy). This has been reviewed by a number of people (stas, rpaulo, kib, ngie, wblock) but not achieved a clear consensus. My hope is that with further exposure and testing more functionality can be implemented and evaluated. Notes: * The VM doesn't handle unbalanced domains very well, and if you have an overly unbalanced memory setup whilst under high memory pressure, VM page allocation may fail leading to a kernel panic. This was a problem in the past, but it's much more easily triggered now with these tools. * This work only controls the path through vm_phys; it doesn't yet strongly/predictably affect contigmalloc, KVA placement, UMA, etc. So, driver placement of memory isn't really guaranteed in any way. That's next on my plate. Sponsored by: Norse Corp, Inc.; Dell
171 lines
4.1 KiB
C
171 lines
4.1 KiB
C
/*-
|
|
* Copyright (c) 2015, Adrian Chadd <adrian@FreeBSD.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice unmodified, this list of conditions, and the following
|
|
* disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
*/
|
|
|
|
#include <sys/cdefs.h>
|
|
__FBSDID("$FreeBSD$");
|
|
|
|
#include <sys/param.h>
|
|
#include <sys/systm.h>
|
|
#include <sys/sysproto.h>
|
|
#include <sys/jail.h>
|
|
#include <sys/kernel.h>
|
|
#include <sys/lock.h>
|
|
#include <sys/malloc.h>
|
|
#include <sys/mutex.h>
|
|
#include <sys/priv.h>
|
|
#include <sys/proc.h>
|
|
#include <sys/refcount.h>
|
|
#include <sys/sched.h>
|
|
#include <sys/smp.h>
|
|
#include <sys/syscallsubr.h>
|
|
#include <sys/cpuset.h>
|
|
#include <sys/sx.h>
|
|
#include <sys/queue.h>
|
|
#include <sys/libkern.h>
|
|
#include <sys/limits.h>
|
|
#include <sys/bus.h>
|
|
#include <sys/interrupt.h>
|
|
|
|
#include <vm/uma.h>
|
|
#include <vm/vm.h>
|
|
#include <vm/vm_page.h>
|
|
#include <vm/vm_param.h>
|
|
#include <vm/vm_phys.h>
|
|
#include <vm/vm_domain.h>
|
|
|
|
int
|
|
sys_numa_setaffinity(struct thread *td, struct numa_setaffinity_args *uap)
|
|
{
|
|
int error;
|
|
struct vm_domain_policy vp;
|
|
struct thread *ttd;
|
|
struct proc *p;
|
|
struct cpuset *set;
|
|
|
|
set = NULL;
|
|
p = NULL;
|
|
|
|
/*
|
|
* Copy in just the policy information into the policy
|
|
* struct. Userland only supplies vm_domain_policy_entry.
|
|
*/
|
|
error = copyin(uap->policy, &vp.p, sizeof(vp.p));
|
|
if (error)
|
|
goto out;
|
|
|
|
/*
|
|
* Ensure the seq number is zero - otherwise seq.h
|
|
* may get very confused.
|
|
*/
|
|
vp.seq = 0;
|
|
|
|
/*
|
|
* Validate policy.
|
|
*/
|
|
if (vm_domain_policy_validate(&vp) != 0) {
|
|
error = EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
/*
|
|
* Go find the desired proc/tid for this operation.
|
|
*/
|
|
error = cpuset_which(uap->which, uap->id, &p,
|
|
&ttd, &set);
|
|
if (error)
|
|
goto out;
|
|
|
|
/* Only handle CPU_WHICH_TID and CPU_WHICH_PID */
|
|
/*
|
|
* XXX if cpuset_which is called with WHICH_CPUSET and NULL cpuset,
|
|
* it'll return ESRCH. We should just return EINVAL.
|
|
*/
|
|
switch (uap->which) {
|
|
case CPU_WHICH_TID:
|
|
vm_domain_policy_copy(&ttd->td_vm_dom_policy, &vp);
|
|
break;
|
|
case CPU_WHICH_PID:
|
|
vm_domain_policy_copy(&p->p_vm_dom_policy, &vp);
|
|
break;
|
|
default:
|
|
error = EINVAL;
|
|
break;
|
|
}
|
|
|
|
PROC_UNLOCK(p);
|
|
out:
|
|
if (set)
|
|
cpuset_rel(set);
|
|
return (error);
|
|
}
|
|
|
|
int
|
|
sys_numa_getaffinity(struct thread *td, struct numa_getaffinity_args *uap)
|
|
{
|
|
int error;
|
|
struct vm_domain_policy vp;
|
|
struct thread *ttd;
|
|
struct proc *p;
|
|
struct cpuset *set;
|
|
|
|
set = NULL;
|
|
p = NULL;
|
|
|
|
error = cpuset_which(uap->which, uap->id, &p,
|
|
&ttd, &set);
|
|
if (error)
|
|
goto out;
|
|
|
|
/* Only handle CPU_WHICH_TID and CPU_WHICH_PID */
|
|
/*
|
|
* XXX if cpuset_which is called with WHICH_CPUSET and NULL cpuset,
|
|
* it'll return ESRCH. We should just return EINVAL.
|
|
*/
|
|
switch (uap->which) {
|
|
case CPU_WHICH_TID:
|
|
vm_domain_policy_localcopy(&vp, &ttd->td_vm_dom_policy);
|
|
break;
|
|
case CPU_WHICH_PID:
|
|
vm_domain_policy_localcopy(&vp, &p->p_vm_dom_policy);
|
|
break;
|
|
default:
|
|
error = EINVAL;
|
|
break;
|
|
}
|
|
if (p)
|
|
PROC_UNLOCK(p);
|
|
/*
|
|
* Copy out only the vm_domain_policy_entry part.
|
|
*/
|
|
if (error == 0)
|
|
error = copyout(&vp.p, uap->policy, sizeof(vp.p));
|
|
out:
|
|
if (set)
|
|
cpuset_rel(set);
|
|
return (error);
|
|
}
|