freebsd-dev/usr.sbin/bhyve/config.c
John Baldwin 621b509048 Refactor configuration management in bhyve.
Replace the existing ad-hoc configuration via various global variables
with a small database of key-value pairs.  The database supports
heirarchical keys using a MIB-like syntax to name the path to a given
key.  Values are always stored as strings.  The API used to manage
configuation values does include wrappers to handling boolean values.
Other values use non-string types require parsing by consumers.

The configuration values are stored in a tree using nvlists.  Leaf
nodes hold string values.  Configuration values are permitted to
reference other configuration values using '%(name)'.  This permits
constructing template configurations.

All existing command line arguments now set configuration values.  For
devices, the "-s" option parses its option argument to generate a list
of key-value pairs for the given device.

A new '-o' command line option permits setting an individual
configuration variable.  The key name is always given as a full path
of dot-separated components.

A new '-k' command line option parses a simple configuration file.
This configuration file holds a flat list of 'key=value' lines where
the 'key' is the full path of a configuration variable.  Lines
starting with a '#' are comments.

In general, bhyve starts by parsing command line options in sequence
and applying those settings to configuration values.  Once this is
complete, bhyve then begins initializing its state based on the
configuration values.  This means that subsequent configuration
options or files may override or supplement previously given settings.

A special 'config.dump' configuration value can be set to true to help
debug configuration issues.  When this value is set, bhyve will print
out the configuration variables as a flat list of 'key=value' lines.

Most command line argments map to a single configuration variable,
e.g.  '-w' sets the 'x86.strictmsr' value to false.  A few command
line arguments have less obvious effects:

- Multiple '-p' options append their values (as a comma-seperated
  list) to "vcpu.N.cpuset" values (where N is a decimal vcpu number).

- For '-s' options, a pci.<bus>.<slot>.<function> node is created.
  The first argument to '-s' (the device type) is used as the value of
  a "device" variable.  Additional comma-separated arguments are then
  parsed into 'key=value' pairs and used to set additional variables
  under the device node.  A PCI device emulation driver can provide
  its own hook to override the parsing of the additonal '-s' arguments
  after the device type.

  After the configuration phase as completed, the init_pci hook
  then walks the "pci.<bus>.<slot>.<func>" nodes.  It uses the
  "device" value to find the device model to use.  The device
  model's init routine is passed a reference to its nvlist node
  in the configuration tree which it can query for specific
  variables.

  The result is that a lot of the string parsing is removed from
  the device models and centralized.  In addition, adding a new
  variable just requires teaching the model to look for the new
  variable.

- For '-l' options, a similar model is used where the string is
  parsed into values that are later read during initialization.
  One key note here is that the serial ports use the commonly
  used lowercase names from existing documentation and examples
  (e.g. "lpc.com1") instead of the uppercase names previously
  used internally in bhyve.

Reviewed by:	grehan
MFC after:	3 months
Differential Revision:	https://reviews.freebsd.org/D26035
2021-03-18 16:30:26 -07:00

432 lines
9.5 KiB
C

/*-
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD
*
* Copyright (c) 2021 John H. Baldwin <jhb@FreeBSD.org>
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <assert.h>
#include <err.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include "config.h"
static nvlist_t *config_root;
void
init_config(void)
{
config_root = nvlist_create(0);
if (config_root == NULL)
err(4, "Failed to create configuration root nvlist");
}
static nvlist_t *
_lookup_config_node(nvlist_t *parent, const char *path, bool create)
{
char *copy, *name, *tofree;
nvlist_t *nvl, *new_nvl;
copy = strdup(path);
if (copy == NULL)
errx(4, "Failed to allocate memory");
tofree = copy;
nvl = parent;
while ((name = strsep(&copy, ".")) != NULL) {
if (*name == '\0') {
warnx("Invalid configuration node: %s", path);
nvl = NULL;
break;
}
if (nvlist_exists_nvlist(nvl, name))
nvl = (nvlist_t *)nvlist_get_nvlist(nvl, name);
else if (nvlist_exists(nvl, name)) {
for (copy = tofree; copy < name; copy++)
if (*copy == '\0')
*copy = '.';
warnx(
"Configuration node %s is a child of existing variable %s",
path, tofree);
nvl = NULL;
break;
} else if (create) {
new_nvl = nvlist_create(0);
if (new_nvl == NULL)
errx(4, "Failed to allocate memory");
nvlist_move_nvlist(nvl, name, new_nvl);
nvl = new_nvl;
} else {
nvl = NULL;
break;
}
}
free(tofree);
return (nvl);
}
nvlist_t *
create_config_node(const char *path)
{
return (_lookup_config_node(config_root, path, true));
}
nvlist_t *
find_config_node(const char *path)
{
return (_lookup_config_node(config_root, path, false));
}
nvlist_t *
create_relative_config_node(nvlist_t *parent, const char *path)
{
return (_lookup_config_node(parent, path, true));
}
nvlist_t *
find_relative_config_node(nvlist_t *parent, const char *path)
{
return (_lookup_config_node(parent, path, false));
}
void
set_config_value_node(nvlist_t *parent, const char *name, const char *value)
{
if (strchr(name, '.') != NULL)
errx(4, "Invalid config node name %s", name);
if (parent == NULL)
parent = config_root;
if (nvlist_exists_string(parent, name))
nvlist_free_string(parent, name);
else if (nvlist_exists(parent, name))
errx(4,
"Attemping to add value %s to existing node %s of list %p",
value, name, parent);
nvlist_add_string(parent, name, value);
}
void
set_config_value(const char *path, const char *value)
{
const char *name;
char *node_name;
nvlist_t *nvl;
/* Look for last separator. */
name = strrchr(path, '.');
if (name == NULL) {
nvl = config_root;
name = path;
} else {
node_name = strndup(path, name - path);
if (node_name == NULL)
errx(4, "Failed to allocate memory");
nvl = create_config_node(node_name);
if (nvl == NULL)
errx(4, "Failed to create configuration node %s",
node_name);
free(node_name);
/* Skip over '.'. */
name++;
}
if (nvlist_exists_nvlist(nvl, name))
errx(4, "Attempting to add value %s to existing node %s",
value, path);
set_config_value_node(nvl, name, value);
}
static const char *
get_raw_config_value(const char *path)
{
const char *name;
char *node_name;
nvlist_t *nvl;
/* Look for last separator. */
name = strrchr(path, '.');
if (name == NULL) {
nvl = config_root;
name = path;
} else {
node_name = strndup(path, name - path);
if (node_name == NULL)
errx(4, "Failed to allocate memory");
nvl = find_config_node(node_name);
free(node_name);
if (nvl == NULL)
return (NULL);
/* Skip over '.'. */
name++;
}
if (nvlist_exists_string(nvl, name))
return (nvlist_get_string(nvl, name));
if (nvlist_exists_nvlist(nvl, name))
warnx("Attempting to fetch value of node %s", path);
return (NULL);
}
static char *
_expand_config_value(const char *value, int depth)
{
FILE *valfp;
const char *cp, *vp;
char *nestedval, *path, *valbuf;
size_t valsize;
valfp = open_memstream(&valbuf, &valsize);
if (valfp == NULL)
errx(4, "Failed to allocate memory");
vp = value;
while (*vp != '\0') {
switch (*vp) {
case '%':
if (depth > 15) {
warnx(
"Too many recursive references in configuration value");
fputc('%', valfp);
vp++;
break;
}
if (vp[1] != '(' || vp[2] == '\0')
cp = NULL;
else
cp = strchr(vp + 2, ')');
if (cp == NULL) {
warnx(
"Invalid reference in configuration value \"%s\"",
value);
fputc('%', valfp);
vp++;
break;
}
vp += 2;
if (cp == vp) {
warnx(
"Empty reference in configuration value \"%s\"",
value);
vp++;
break;
}
/* Allocate a C string holding the path. */
path = strndup(vp, cp - vp);
if (path == NULL)
errx(4, "Failed to allocate memory");
/* Advance 'vp' past the reference. */
vp = cp + 1;
/* Fetch the referenced value. */
cp = get_raw_config_value(path);
if (cp == NULL)
warnx(
"Failed to fetch referenced configuration variable %s",
path);
else {
nestedval = _expand_config_value(cp, depth + 1);
fputs(nestedval, valfp);
free(nestedval);
}
free(path);
break;
case '\\':
vp++;
if (*vp == '\0') {
warnx(
"Trailing \\ in configuration value \"%s\"",
value);
break;
}
/* FALLTHROUGH */
default:
fputc(*vp, valfp);
vp++;
break;
}
}
fclose(valfp);
return (valbuf);
}
const char *
expand_config_value(const char *value)
{
static char *valbuf;
if (strchr(value, '%') == NULL)
return (value);
free(valbuf);
valbuf = _expand_config_value(value, 0);
return (valbuf);
}
const char *
get_config_value(const char *path)
{
const char *value;
value = get_raw_config_value(path);
if (value == NULL)
return (NULL);
return (expand_config_value(value));
}
const char *
get_config_value_node(const nvlist_t *parent, const char *name)
{
if (strchr(name, '.') != NULL)
errx(4, "Invalid config node name %s", name);
if (parent == NULL)
parent = config_root;
if (nvlist_exists_nvlist(parent, name))
warnx("Attempt to fetch value of node %s of list %p", name,
parent);
if (!nvlist_exists_string(parent, name))
return (NULL);
return (expand_config_value(nvlist_get_string(parent, name)));
}
bool
_bool_value(const char *name, const char *value)
{
if (strcasecmp(value, "true") == 0 ||
strcasecmp(value, "on") == 0 ||
strcasecmp(value, "yes") == 0 ||
strcmp(value, "1") == 0)
return (true);
if (strcasecmp(value, "false") == 0 ||
strcasecmp(value, "off") == 0 ||
strcasecmp(value, "no") == 0 ||
strcmp(value, "0") == 0)
return (false);
err(4, "Invalid value %s for boolean variable %s", value, name);
}
bool
get_config_bool(const char *path)
{
const char *value;
value = get_config_value(path);
if (value == NULL)
err(4, "Failed to fetch boolean variable %s", path);
return (_bool_value(path, value));
}
bool
get_config_bool_default(const char *path, bool def)
{
const char *value;
value = get_config_value(path);
if (value == NULL)
return (def);
return (_bool_value(path, value));
}
bool
get_config_bool_node(const nvlist_t *parent, const char *name)
{
const char *value;
value = get_config_value_node(parent, name);
if (value == NULL)
err(4, "Failed to fetch boolean variable %s", name);
return (_bool_value(name, value));
}
bool
get_config_bool_node_default(const nvlist_t *parent, const char *name,
bool def)
{
const char *value;
value = get_config_value_node(parent, name);
if (value == NULL)
return (def);
return (_bool_value(name, value));
}
void
set_config_bool(const char *path, bool value)
{
set_config_value(path, value ? "true" : "false");
}
void
set_config_bool_node(nvlist_t *parent, const char *name, bool value)
{
set_config_value_node(parent, name, value ? "true" : "false");
}
static void
dump_tree(const char *prefix, const nvlist_t *nvl)
{
const char *name;
void *cookie;
int type;
cookie = NULL;
while ((name = nvlist_next(nvl, &type, &cookie)) != NULL) {
if (type == NV_TYPE_NVLIST) {
char *new_prefix;
asprintf(&new_prefix, "%s%s.", prefix, name);
dump_tree(new_prefix, nvlist_get_nvlist(nvl, name));
free(new_prefix);
} else {
assert(type == NV_TYPE_STRING);
printf("%s%s=%s\n", prefix, name,
nvlist_get_string(nvl, name));
}
}
}
void
dump_config(void)
{
dump_tree("", config_root);
}