freebsd-dev/usr.sbin
John Baldwin c74ab5ce6f iscsid: Always free the duplicated address in resolve_addr().
If a "raw" IPv6 address (denoted by a leading '[') is used as a target
address, then 'arg' is incremented by one to skip over the '['.
However, this meant that at the end of the function the wrong address
was passed to free().  With malloc junking enabled and given suitably
small strings, malloc() would happily overwrite the correct number of
bytes with junk, but off by one byte overwriting the byte after the
allocation.

This manifested as the first byte of the 'HeaderDigest' key being
overwritten causing the key name on the wire to be sent as
'\x5eaderDigest' which the target rejected.

Reported by:	Jithesh Arakkan @ Chelsio
Found with:	ASAN (via WITH_ASAN=yes)
Sponsored by:	Chelsio Communications
2021-12-28 16:49:46 -08:00
..
ac Add some HISTORY sections to manpages 2020-02-19 12:49:49 +00:00
accton
acpi Only change the fadt revision in acpidump on i386 2021-10-21 12:20:32 +01:00
adduser adduser: allow standard IFS characters in passwords 2020-04-05 19:25:46 +00:00
apm Fix build with -DNO_ROOT 2021-11-26 12:51:08 +01:00
apmd Stop linking to libl by specifying we do not need yywrap 2019-09-10 07:23:01 +00:00
arp arp(8): fixing the deletion failure of IEEE1394 associated addresses 2021-04-13 22:59:58 +00:00
audit
auditd
auditdistd auditdistd: Remove useless linking with libl 2020-03-24 07:08:39 +00:00
auditreduce
authpf authpf: Start using libpfctl 2021-05-07 22:13:31 +02:00
autofs pkgbase: Put autofs config files in the FreeBSD-autofs package 2021-12-21 10:17:25 +01:00
bhyve bhyve: Only snapshot initialized VirtIO queues 2021-12-17 13:06:53 -05:00
bhyvectl bhyve/snapshot: provide a way to send other messages/data to bhyve 2021-05-12 17:20:15 -08:00
bhyveload bhyveload(8): Implement loader_callbacks::diskwrite 2020-10-07 20:31:13 +00:00
binmiscctl binmiscctl: Avoid segfault with "binmiscctl add" and no extra params 2021-02-08 09:20:38 -05:00
blacklistctl
blacklistd
bluetooth bluetooth: remove hcseriald 2021-09-29 21:18:17 -06:00
boot0cfg Revert r362466 2020-06-22 07:46:24 +00:00
bootparamd bootparamd: Add missing __unused mark. 2021-01-03 00:40:34 +09:00
bsdconfig Fix 'take effect' spelling in menus and comments. 2021-11-18 23:22:12 -07:00
bsdinstall bsdinstall: zfsboot: Prompt user for zpool name if the pool already exists 2021-12-15 15:24:07 +01:00
bsnmpd Remove DS_BUSY case 2021-11-30 16:35:48 -07:00
btxld
camdd camdd(8): Fix the man page date 2020-12-19 13:17:25 +00:00
cdcontrol
certctl pkgbase: Put certctl in the FreeBSD-caroot package 2021-12-21 10:17:44 +01:00
chkgrp
chown fts_read: Handle error from a NULL return better. 2020-12-08 23:38:26 +00:00
chroot chroot: fix typo in usage 2021-07-21 10:16:11 +01:00
ckdist fts_read: Handle error from a NULL return better. 2020-12-08 23:38:26 +00:00
clear_locks pkgbase: Create a FreeBSD-nfs package 2021-06-19 17:49:50 +02:00
config config(5): Update upper limit for maxusers on 64-bit systems 2021-10-28 14:15:08 -04:00
cpucontrol cpucontrol: fix extended signature matching code to avoid fallthough 2021-06-14 17:34:07 -04:00
crashinfo crashinfo: Add references to the gdb port/package 2020-12-02 19:58:50 +00:00
cron cron: consume blanks in system crontabs before options 2021-03-03 23:23:31 -08:00
crunch crunchgen: use realpath(3) instead of ``pwd -P'' 2021-10-27 09:26:00 +00:00
ctladm pkgbase: Move ctld/ctladm to iscsi package 2021-06-19 17:49:57 +02:00
ctld ctld: Disable -Wcast-align warnings. 2021-12-22 15:23:45 -08:00
cxgbetool pkgbase: Create a cxgbe-tools package 2021-09-07 10:19:37 +02:00
daemon daemon: add some basic tests 2021-05-03 09:55:40 -06:00
dconschat dconschat: Remove support for FreeBSD 4.x and earlier. 2021-04-20 15:51:31 -06:00
devctl Add freeze/thaw description to devctl(8) 2021-06-01 12:33:12 +08:00
devinfo devinfo(8): Remove cross-reference to pnpinfo(8) 2021-11-01 12:29:12 -04:00
diskinfo Make "diskinfo -i" also test 1MB reads. 2020-12-10 10:23:18 +00:00
dumpcis Regularize my copyright notice 2019-12-04 16:56:11 +00:00
editmap
edquota edquota(8): Cleanup to make it WARNS=6 clean. 2020-08-17 05:57:22 +00:00
efibootmgr pkgbase: Remove libefivar package and add a efi-tools one 2021-09-07 10:24:21 +02:00
efidp pkgbase: Remove libefivar package and add a efi-tools one 2021-09-07 10:24:21 +02:00
efitable efitable: Don't pass NULL as a format string to xo_err(). 2021-09-15 09:03:17 -07:00
efivar pkgbase: Remove libefivar package and add a efi-tools one 2021-09-07 10:24:21 +02:00
etcupdate secure/caroot, certctl: Rename secure/caroot/blacklisted 2021-06-18 13:38:07 +01:00
extattr vfs_extattr: Allow extattr names up to the full max 2020-05-14 03:01:23 +00:00
extattrctl Fix a few mandoc issues 2020-10-09 14:03:45 +00:00
fdcontrol
fdformat Add example usage for formatting a floppy disk. Adding a more self 2020-05-25 07:18:47 +00:00
fdread
fdwrite
fifolog fifolog: Rename yyparse() to getdate_yyparse(). 2021-06-07 06:31:50 +00:00
flowctl
freebsd-update freebsd-update(8): Add -j flag to support jails 2021-10-01 13:51:03 -05:00
fstyp fstyp: fix build WITHOUT_ICONV 2021-11-02 14:54:45 -04:00
ftp-proxy (t)ftp-proxy: use libpfctl 2021-04-10 11:16:02 +02:00
fwcontrol fwcontrol: Remove support for FreeBSD 4.x 2021-04-20 15:51:31 -06:00
getfmac
getpmac
gpioctl Provide userland notification of gpio pin changes ("userland gpio interrupts"). 2020-12-12 18:34:15 +00:00
gssd pkgbase: Create a FreeBSD-kerberos package 2021-09-07 10:23:14 +02:00
gstat ncurses: chase dependency changes in the source tree 2021-10-04 11:38:24 +02:00
hyperv
i2c i2c(8): fix option handling 2021-10-06 21:56:20 -08:00
ifmcstat
inetd inetd: Use the synopsis from the manual page 2021-12-06 22:15:19 +01:00
iostat iostat: fix rounding errors in iostat -x 2021-07-08 10:16:32 -06:00
iovctl Do a sweep and remove most WARNS=6 settings 2020-10-01 01:10:51 +00:00
ip6addrctl pkgbase: Put a lot of binaries and lib in FreeBSD-runtime 2019-09-05 14:13:08 +00:00
ipfwpcap
iscsid iscsid: Always free the duplicated address in resolve_addr(). 2021-12-28 16:49:46 -08:00
jail jail: Don't allow substitution of valueless jail parameters. 2021-06-18 09:44:37 -07:00
jexec
jls Bugfix to not hide jailparam flags, which for example changes the output 2020-12-15 20:56:35 +00:00
kbdcontrol Stop linking to libl by specifying we do not need yywrap 2019-09-10 07:26:38 +00:00
kbdmap kbdmap: adapt to the new libbsddialog API 2021-12-13 09:08:09 +01:00
keyserv keyserv(8): unifdef out __FreeBSD__ and KEYSERV_RANDOM 2019-12-13 04:03:05 +00:00
kldxref kldxref: add R_PPC64_ADDR64 handler 2021-12-27 15:29:50 -03:00
lastlogin A single comma was missing to separate the "see also" items in 2018-10-20 17:22:04 +00:00
lpr lpr(1): Fix a typo in a source code comment 2021-11-19 20:04:09 +01:00
lptcontrol
mailstats
mailwrapper Make use of the getlocalbase() function for run-time adjustment of the 2020-11-18 20:00:55 +00:00
makefs makefs: remove set but not used variables 2021-11-21 21:21:34 -05:00
makemap
manctl
memcontrol
mergemaster secure/caroot, certctl: Rename secure/caroot/blacklisted 2021-06-18 13:38:07 +01:00
mfiutil Make mfiutil show progress print out the elapsed time estimate in a 2018-10-13 02:21:23 +00:00
mixer mixer: make .Dt tags uppercase 2021-11-20 08:58:36 +01:00
mld6query Remove the USE_RFC2292BIS option and reap dead code 2019-07-22 20:11:33 +00:00
mlx5tool pkgbase: Create a mlx-tools package 2021-09-07 10:20:16 +02:00
mlxcontrol pkgbase: Move back mlxcontrol in the default package 2021-09-09 08:14:53 +02:00
mount_smbfs
mountd mountd: Fix handling of usernames that start with a digit 2021-11-18 13:35:25 -08:00
moused moused(8): Fix a few mandoc warnings 2020-11-20 17:04:49 +00:00
mpsutil mpsutil: Fix data truncation by too short buffers. 2021-11-29 20:20:03 -05:00
mptable
mptutil mptutil: emit a warning on big-endian architectures 2019-07-22 17:25:35 +00:00
mtest
ndp Fix arp/ndp deletion broken by 2fe5a79425. 2021-02-19 21:17:17 +00:00
newsyslog pkgbase: Create a FreeBSD-newsyslog package 2021-12-21 10:17:42 +01:00
nfscbd pkgbase: Create a FreeBSD-nfs package 2021-06-19 17:49:50 +02:00
nfsd nfsd: Fix some issues found by mandoc 2021-07-12 06:31:54 +02:00
nfsdumpstate pkgbase: Create a FreeBSD-nfs package 2021-06-19 17:49:50 +02:00
nfsrevoke pkgbase: Create a FreeBSD-nfs package 2021-06-19 17:49:50 +02:00
nfsuserd pkgbase: Create a FreeBSD-nfs package 2021-06-19 17:49:50 +02:00
ngctl build: remove LIBPTHREAD/LIBTHR build options 2021-01-22 12:33:27 -06:00
nghook
nmtree pkgbase: Create a FreeBSD-mtree package 2021-12-21 10:17:33 +01:00
nologin Revert 363598 2020-08-17 10:25:02 +00:00
nscd nscd: does not warn about invalid values what parsing config file 2020-07-11 19:44:12 +00:00
ntp ntp: Revert "Disable stack gap for ntpd during build." 2021-10-15 16:06:14 -07:00
nvram [PowerPC] De-giant powermac_nvram, update documentation 2020-06-19 18:36:10 +00:00
ofwdump [PowerPC] Allow traversal of oversize OF properties. 2020-11-13 16:49:41 +00:00
pciconf pciconf: Fix up pciconf -lc output 2021-06-01 10:55:44 -05:00
periodic pkgbase: Create a FreeBSD-periodic package 2021-12-21 10:17:38 +01:00
pkg pkgbase: Add a FreeBSD-pkg-bootstrap package 2021-12-21 10:17:48 +01:00
pmc ncurses: chase dependency changes in the source tree 2021-10-04 11:38:24 +02:00
pmcannotate
pmccontrol pmccontrol: improve -L with pmu-events 2021-05-31 17:39:05 -03:00
pmcstat ncurses: chase dependency changes in the source tree 2021-10-04 11:38:24 +02:00
pmcstudy Fix a few mandoc issues 2020-10-09 14:03:45 +00:00
pnfsdscopymr pkgbase: Create a FreeBSD-nfs package 2021-06-19 17:49:50 +02:00
pnfsdsfile pkgbase: Create a FreeBSD-nfs package 2021-06-19 17:49:50 +02:00
pnfsdskill pkgbase: Create a FreeBSD-nfs package 2021-06-19 17:49:50 +02:00
pnpinfo
portsnap portsnap: Remove superfluous semicolons 2021-06-29 11:00:54 -07:00
powerd powerd(8): Add rc.conf(5) to see also 2021-11-06 22:43:30 -04:00
ppp sys/*/conf/*, docs: fix links to handbook 2021-05-20 09:27:10 +01:00
pppctl pkgbase: Put ppp in it's own package 2021-01-04 16:19:36 +01:00
praliases
praudit usr.sbin/praudit: Fix tests after 5619d49e07 2021-02-03 16:02:46 +00:00
prometheus_sysctl_exporter Fix typo on "Celsius" 2021-11-18 23:05:32 -07:00
pstat pstat(8): improve the Size header width after r358181 2020-06-23 18:19:22 +00:00
pw pw(8): use openmemstream instead of sbuf(9) 2021-04-27 05:09:07 +02:00
pwd_mkdb Fix bootstrapping of pwd_mkdb after r364049 2020-08-11 16:46:38 +00:00
pwm usr.sbin/pwm/pwm add support for flags 2021-03-11 09:57:56 +01:00
quot Move the pointers stored in the superblock into a separate 2020-06-19 01:02:53 +00:00
quotaon
rarpd
repquota
rip6query
rmt tag /etc/rmt symlink with pkgbase package 2020-02-12 17:30:09 +00:00
route6d
rpc.lockd rpc.lockd: Use libc strnlen() instead of reimplementing it 2021-06-23 10:06:57 -04:00
rpc.statd Add and document options to allow rpc.lockd and rpc.statd to run in the 2019-11-22 16:53:30 +00:00
rpc.tlsclntd nfs tls: Update for SSL_OP_ENABLE_KTLS. 2021-08-10 14:18:43 -07:00
rpc.tlsservd nfs tls: Update for SSL_OP_ENABLE_KTLS. 2021-08-10 14:18:43 -07:00
rpc.umntall pkgbase: Create a FreeBSD-nfs package 2021-06-19 17:49:50 +02:00
rpc.yppasswdd pkgbase: Put yellow pages programs to its own package 2021-12-21 10:17:22 +01:00
rpc.ypupdated pkgbase: Put yellow pages programs to its own package 2021-12-21 10:17:22 +01:00
rpc.ypxfrd pkgbase: Put yellow pages programs to its own package 2021-12-21 10:17:22 +01:00
rpcbind RPCBIND: skip ipv6 link local when request is not from link local address 2021-10-04 10:45:26 -07:00
rrenumd Fix build with recent byacc. 2020-06-24 02:08:08 +00:00
rtadvctl usr.sbin/rtadvctl: Remove support for FreeBSD 9.x. 2021-01-01 16:06:08 -08:00
rtadvd Remove obsolete compatibility code from rtadvd. 2019-07-17 16:50:53 +00:00
rtprio Add idle priority scheduling privilege group to MAC/priority 2021-12-10 04:54:48 +02:00
rtsold rtsold: Note network interfaces changing index when removed/inserted 2021-12-14 15:27:47 -07:00
rwhod Remove reference to nlist(3) missed in SCCS revision 5.26 by mckusick 2020-07-24 16:58:13 +00:00
sa lastcomm/sa: Remove sparc64 tests, they aren't needed. 2021-10-04 10:51:15 -06:00
sendmail Merge sendmail 8.16.1 to HEAD: See contrib/sendmail/RELEASE_NOTES for details 2020-07-15 18:28:54 +00:00
service pkgbase: Put more binaries/lib in runtime 2021-12-21 10:17:27 +01:00
services_mkdb usr.sbin/services_mkdb: plug memory leak when line was blank. 2021-03-30 15:21:37 -07:00
sesutil sesutil: Fix status checking 2021-07-21 10:14:26 +01:00
setfib
setfmac fts_read: Handle error from a NULL return better. 2020-12-08 23:38:26 +00:00
setpmac
smbmsg
snapinfo
spi Clean up spi.8 2020-08-21 09:48:00 +00:00
spkrtest
spray
syslogd pkgbase: Create a FreeBSD-syslogd package 2021-12-21 10:17:40 +01:00
sysrc Update the spelling of my name 2019-04-22 17:52:46 +00:00
tcpdchk pkgbase: Create a FreeBSD-tcpd package 2021-12-21 10:17:31 +01:00
tcpdmatch pkgbase: Create a FreeBSD-tcpd package 2021-12-21 10:17:31 +01:00
tcpdrop tcpdrop: tweak comments 2021-12-04 15:08:01 +01:00
tcpdump Remove useless linking to libl 2020-03-23 14:44:23 +00:00
tests
traceroute Update Makefile.depend files 2019-12-11 17:37:53 +00:00
traceroute6 traceroute6: Properly calculate UDP checksum 2021-05-03 13:24:30 -04:00
trim trim(8): Fix a few issues reported by mandoc 2020-12-19 13:56:19 +00:00
trpt inet: remove tcp_debug from netinet/tcp_debug.h 2021-11-01 23:10:30 +00:00
tzsetup tzsetup: Fix unicode support 2021-12-17 09:25:07 +01:00
uathload
uefisign uefisign: fix SizeOfHeaders sanity check. 2021-06-03 15:22:14 -06:00
ugidfw
uhsoctl Use correct type for IOCTL request argument. 2018-11-02 22:23:25 +00:00
unbound Fix local-unbound setup for some IPv6 deployments. 2021-03-10 15:53:22 +00:00
usbconfig usbconfig: actually set the exit code in usage() 2021-12-20 22:25:19 +01:00
usbdump usbdump: style: Sort case statements alphabetically 2021-06-04 16:47:28 -06:00
utx pkgbase: Put more binaries/lib in runtime 2021-12-21 10:17:27 +01:00
valectl netmap: several typo fixes 2021-04-02 07:01:20 +00:00
vidcontrol Move font related data structured to sys/font.c and update vtfontcvt 2020-06-14 06:58:58 +00:00
vigr
vipw
wake
watch ncurses: chase dependency changes in the source tree 2021-10-04 11:38:24 +02:00
watchdogd
wlandebug wlandebug.8: remove Xref for missing manpages 2021-03-15 10:04:13 +01:00
wpa wpa: Fix WITHOUT_WPA_SUPPLICANT_EAPOL build 2021-11-11 19:03:05 -08:00
yp_mkdb pkgbase: Put yellow pages programs to its own package 2021-12-21 10:17:22 +01:00
ypbind pkgbase: Put yellow pages programs to its own package 2021-12-21 10:17:22 +01:00
ypldap pkgbase: Put yellow pages programs to its own package 2021-12-21 10:17:22 +01:00
yppoll pkgbase: Put yellow pages programs to its own package 2021-12-21 10:17:22 +01:00
yppush pkgbase: Put yellow pages programs to its own package 2021-12-21 10:17:22 +01:00
ypserv pkgbase: Put yellow pages programs to its own package 2021-12-21 10:17:22 +01:00
ypset pkgbase: Put yellow pages programs to its own package 2021-12-21 10:17:22 +01:00
zic Remove tests for obsolete compilers in the build system 2020-05-12 15:22:40 +00:00
zonectl Cross-reference camcontrol(8) and zonectl(8) man pages. 2021-04-10 10:13:29 +01:00
zzz
Makefile Fix bsd.subdir.mk-related issues after 0a0f748641 2021-07-12 20:54:01 +01:00
Makefile.amd64 Fix build with -DNO_ROOT 2021-11-26 12:51:08 +01:00
Makefile.arm Remove kgmon(8) 2021-04-04 00:50:28 +03:00
Makefile.arm64
Makefile.i386 Remove kgmon(8) 2021-04-04 00:50:28 +03:00
Makefile.inc build: provide a default WARNS for all in-tree builds 2020-09-18 17:17:46 +00:00
Makefile.mips
Makefile.powerpc
Makefile.riscv