FreeBSD src
Go to file
Alan Somers cd037f075c MFV r323789: 8473 scrub does not detect errors on active spares
illumos/illumos-gate@554675eee7
554675eee7

https://www.illumos.org/issues/8473
Scrubbing is supposed to detect and repair all errors in the pool. However,
it wrongly ignores active spare devices. The problem can easily be
reproduced in OpenZFS at git rev 0ef125d with these commands:

truncate -s 64m /tmp/a /tmp/b /tmp/c
sudo zpool create testpool mirror /tmp/a /tmp/b spare /tmp/c
sudo zpool replace testpool /tmp/a /tmp/c
/bin/dd if=/dev/zero bs=1024k count=63 oseek=1 conv=notrunc of=/tmp/c
sync
sudo zpool scrub testpool
zpool status testpool # Will show 0 errors, which is wrong
sudo zpool offline testpool /tmp/a
sudo zpool scrub testpool
zpool status testpool # Will show errors on /tmp/c,
		      # which should've already been fixed

FreeBSD head is partially affected: the first scrub will detect some errors, but the second scrub will detect more.

Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Matt Ahrens <mahrens@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Approved by: Richard Lowe <richlowe@richlowe.net>

MFC after:	1 week
Sponsored by:	Spectra Logic Corp
2017-09-20 16:31:00 +00:00
bin Add basic tests for chflags, mkdir, rcp, and rmdir 2017-09-07 16:54:47 +00:00
cddl MFV r323790: 8567 Inconsistent return value in zpool_read_label 2017-09-20 07:23:50 +00:00
contrib MFV r323678: file 5.32 2017-09-17 19:14:38 +00:00
crypto Upgrade to OpenSSH 7.5p1. 2017-08-04 12:57:24 +00:00
etc Regenerate usb.conf . 2017-09-20 15:00:00 +00:00
gnu Remove redundant source and object files. 2017-09-09 13:18:32 +00:00
include An MMC/SD/SDIO stack using CAM 2017-07-09 16:57:24 +00:00
kerberos5 Replace the include path using CURDIR with KRB5DIR. This is consistent 2017-08-21 12:42:05 +00:00
lib 8567 Inconsistent return value in zpool_read_label 2017-09-20 07:18:09 +00:00
libexec Deorbit catman. The tradeoff of disk for performance has long since tipped 2017-09-13 16:35:16 +00:00
release Bootstrap etcupdate(8) and mergemaster(8) databases when creating 2017-09-20 15:49:12 +00:00
rescue DIRDEPS_BUILD: Update dependencies. 2017-05-09 01:48:23 +00:00
sbin Provide an articulate example of how to properly delete partitions and 2017-09-19 15:08:31 +00:00
secure Convert traditional ${MK_TESTS} conditional idiom for including test 2017-08-02 08:35:51 +00:00
share Add myself and mentorship status to committers files. 2017-09-19 16:38:54 +00:00
sys MFV r323789: 8473 scrub does not detect errors on active spares 2017-09-20 16:31:00 +00:00
targets Deorbit catman. The tradeoff of disk for performance has long since tipped 2017-09-13 16:35:16 +00:00
tests Vendor import of file 5.32. 2017-09-17 15:57:06 +00:00
tools Update OptionalObsoleteFiles.inc with NTP docs 2017-09-15 00:54:37 +00:00
usr.bin Make basic Broadcom I/O space reading functions work 2017-09-18 20:01:01 +00:00
usr.sbin Revert tcpdump to using the source manpage instead of having a copy here. 2017-09-18 16:42:13 +00:00
.arcconfig callsign isn't required anymore 2016-09-29 06:19:45 +00:00
.arclint phabricator related changes: 2015-04-20 20:33:22 +00:00
COPYRIGHT Bump copyright year. 2016-12-31 12:41:42 +00:00
LOCKS
MAINTAINERS Add asomers as a pjdfstest co-maintainer per the project status change 2017-06-28 09:25:15 +00:00
Makefile Quote ${MAKE} when passing in env in case it contains spaces. 2017-08-16 17:54:24 +00:00
Makefile.inc1 Makefile.inc1: bump elf tool chain version check after PR 215350 fix 2017-09-06 01:55:40 +00:00
Makefile.libcompat Honor NO_RTLD for rtld-elf, similar to what's done in libexec/Makefile, with 2017-08-17 20:15:20 +00:00
ObsoleteFiles.inc Deorbit catman. The tradeoff of disk for performance has long since tipped 2017-09-13 16:35:16 +00:00
README Vendor import of OpenSSH 7.5p1. 2017-08-03 10:10:20 +00:00
README.md Remove hard line breaks from README.md 2017-03-01 15:39:58 +00:00
UPDATING Fix language used in the r322923. 2017-09-17 10:28:45 +00:00

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

For copyright information, please see the file COPYRIGHT in this directory (additional copyright information also exists for some sources in this tree - please see the specific source directories for more information).

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7) and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html for more information, including setting make(1) variables.

The buildkernel and installkernel targets build and install the kernel and the modules (see below). Please see the top of the Makefile in this directory for more information on the standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process. See build(7), config(8), and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information.

Note: If you want to build and install the kernel with the buildkernel and installkernel targets, you might need to build world before. More information is available in the handbook.

The kernel configuration files reside in the sys/<arch>/conf sub-directory. GENERIC is the default configuration used in release builds. NOTES contains entries and documentation for all possible devices, not just those commonly used.

Source Roadmap:

bin				System/user commands.

cddl			Various commands and libraries under the Common Development  
				and Distribution License.

contrib			Packages contributed by 3rd parties.

crypto			Cryptography stuff (see crypto/README).

etc				Template files for /etc.

gnu				Various commands and libraries under the GNU Public License.  
				Please see gnu/COPYING* for more information.

include			System include files.

kerberos5		Kerberos5 (Heimdal) package.

lib				System libraries.

libexec			System daemons.

release			Release building Makefile & associated tools.

rescue			Build system for statically linked /rescue utilities.

sbin			System commands.

secure			Cryptographic libraries and commands.

share			Shared resources.

sys				Kernel sources.

tests			Regression tests which can be run by Kyua.  See tests/README
				for additional information.

tools			Utilities for regression testing and miscellaneous tasks.

usr.bin			User commands.

usr.sbin		System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html