freebsd-dev/lib/libc/posix1e/acl_valid.c
Edward Tomasz Napierala d72fb30a43 _posix1e_acl_sort() never returns anything other than 0; change its
return type to void and update callers.  This simplifies code and
fixes one place where the returned value was not actually checked.

Found with:	Coverity Prevent
CID:		4791
2010-06-03 14:29:17 +00:00

125 lines
3.3 KiB
C

/*-
* Copyright (c) 1999, 2000, 2001, 2002 Robert N. M. Watson
* All rights reserved.
*
* This software was developed by Robert Watson for the TrustedBSD Project.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
/*
* acl_valid -- POSIX.1e ACL check routine
*/
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <sys/types.h>
#include "namespace.h"
#include <sys/acl.h>
#include "un-namespace.h"
#include <sys/errno.h>
#include <stdlib.h>
#include "acl_support.h"
/*
* acl_valid: accepts an ACL, returns 0 on valid ACL, -1 for invalid,
* and errno set to EINVAL.
*
* Implemented by calling the acl_check routine in acl_support, which
* requires ordering. We call acl_support's _posix1e_acl_sort to make this
* true. POSIX.1e allows acl_valid() to reorder the ACL as it sees fit.
*
* This call is deprecated, as it doesn't ask whether the ACL is valid
* for a particular target. However, this call is standardized, unlike
* the other two forms.
*/
int
acl_valid(acl_t acl)
{
int error;
if (acl == NULL) {
errno = EINVAL;
return (-1);
}
if (!_acl_brand_may_be(acl, ACL_BRAND_POSIX)) {
errno = EINVAL;
return (-1);
}
_posix1e_acl_sort(acl);
error = _posix1e_acl_check(acl);
if (error) {
errno = error;
return (-1);
} else {
return (0);
}
}
int
acl_valid_file_np(const char *pathp, acl_type_t type, acl_t acl)
{
if (pathp == NULL || acl == NULL) {
errno = EINVAL;
return (-1);
}
type = _acl_type_unold(type);
if (_posix1e_acl(acl, type))
_posix1e_acl_sort(acl);
return (__acl_aclcheck_file(pathp, type, &acl->ats_acl));
}
int
acl_valid_link_np(const char *pathp, acl_type_t type, acl_t acl)
{
if (pathp == NULL || acl == NULL) {
errno = EINVAL;
return (-1);
}
type = _acl_type_unold(type);
if (_posix1e_acl(acl, type))
_posix1e_acl_sort(acl);
return (__acl_aclcheck_link(pathp, type, &acl->ats_acl));
}
int
acl_valid_fd_np(int fd, acl_type_t type, acl_t acl)
{
if (acl == NULL) {
errno = EINVAL;
return (-1);
}
type = _acl_type_unold(type);
if (_posix1e_acl(acl, type))
_posix1e_acl_sort(acl);
acl->ats_cur_entry = 0;
return (___acl_aclcheck_fd(fd, type, &acl->ats_acl));
}