d9e9650a36
it. There are two problems which shall be addressed for shared lookups use to have measurable effect on nullfs scalability: 1. When vfs_lookup() calls VOP_LOOKUP() for nullfs, which passes lookup operation to lower fs, resulting vnode is often only shared-locked. Then null_nodeget() cannot instantiate covering vnode for lower vnode, since insmntque1() and null_hashins() require exclusive lock on the lower. Change the assert that lower vnode is exclusively locked to only require any lock. If null hash failed to find pre-existing nullfs vnode for lower vnode and the vnode is shared-locked, the lower vnode lock is upgraded. 2. Nullfs reclaims its vnodes on deactivation. This is due to nullfs inability to detect reclamation of the lower vnode. Reclamation of a nullfs vnode at deactivation time prevents a reference to the lower vnode to become stale. Change nullfs VOP_INACTIVE to not reclaim the vnode, instead use the VFS_RECLAIM_LOWERVP to get notification and reclaim upper vnode together with the reclamation of the lower vnode. Note that nullfs reclamation procedure calls vput() on the lowervp vnode, temporary unlocking the vnode being reclaimed. This seems to be fine for MPSAFE filesystems, but not-MPSAFE code often put partially initialized vnode on some globally visible list, and later can decide that half-constructed vnode is not needed. If nullfs mount is created above such filesystem, then other threads might catch such not properly initialized vnode. Instead of trying to overcome this case, e.g. by recursing the lower vnode lock in null_reclaim_lowervp(), I decided to rely on nearby removal of the support for non-MPSAFE filesystems. In collaboration with: pho MFC after: 3 weeks
83 lines
3.0 KiB
C
83 lines
3.0 KiB
C
/*-
|
|
* Copyright (c) 1992, 1993
|
|
* The Regents of the University of California. All rights reserved.
|
|
*
|
|
* This code is derived from software donated to Berkeley by
|
|
* Jan-Simon Pendry.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 4. Neither the name of the University nor the names of its contributors
|
|
* may be used to endorse or promote products derived from this software
|
|
* without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*
|
|
* @(#)null.h 8.3 (Berkeley) 8/20/94
|
|
*
|
|
* $FreeBSD$
|
|
*/
|
|
|
|
struct null_mount {
|
|
struct mount *nullm_vfs;
|
|
struct vnode *nullm_rootvp; /* Reference to root null_node */
|
|
};
|
|
|
|
#ifdef _KERNEL
|
|
/*
|
|
* A cache of vnode references
|
|
*/
|
|
struct null_node {
|
|
LIST_ENTRY(null_node) null_hash; /* Hash list */
|
|
struct vnode *null_lowervp; /* VREFed once */
|
|
struct vnode *null_vnode; /* Back pointer */
|
|
};
|
|
|
|
#define MOUNTTONULLMOUNT(mp) ((struct null_mount *)((mp)->mnt_data))
|
|
#define VTONULL(vp) ((struct null_node *)(vp)->v_data)
|
|
#define NULLTOV(xp) ((xp)->null_vnode)
|
|
|
|
int nullfs_init(struct vfsconf *vfsp);
|
|
int nullfs_uninit(struct vfsconf *vfsp);
|
|
int null_nodeget(struct mount *mp, struct vnode *target, struct vnode **vpp);
|
|
struct vnode *null_hashget(struct mount *mp, struct vnode *lowervp);
|
|
void null_hashrem(struct null_node *xp);
|
|
int null_bypass(struct vop_generic_args *ap);
|
|
|
|
#ifdef DIAGNOSTIC
|
|
struct vnode *null_checkvp(struct vnode *vp, char *fil, int lno);
|
|
#define NULLVPTOLOWERVP(vp) null_checkvp((vp), __FILE__, __LINE__)
|
|
#else
|
|
#define NULLVPTOLOWERVP(vp) (VTONULL(vp)->null_lowervp)
|
|
#endif
|
|
|
|
extern struct vop_vector null_vnodeops;
|
|
|
|
#ifdef MALLOC_DECLARE
|
|
MALLOC_DECLARE(M_NULLFSNODE);
|
|
#endif
|
|
|
|
#ifdef NULLFS_DEBUG
|
|
#define NULLFSDEBUG(format, args...) printf(format ,## args)
|
|
#else
|
|
#define NULLFSDEBUG(format, args...)
|
|
#endif /* NULLFS_DEBUG */
|
|
|
|
#endif /* _KERNEL */
|