e07ca0423d
written to disk with newfs(8) and newfs_msdosfs(8). When iterating through snapshot builds in serial, it is possible for a build failure to leave stale md(4) devices behind, in some cases, they could have a UFS or MSDOS filesystem label assigned. If the md(4) is not destroyed (or not able to be destroyed, as has happened recently due to my own fault), the filesystem label that already exists can interfere with a new md(4) device that is targeted to have the same label. This behavior, although admittedly a logic error in the wrapper build scripts, has caused intermittent reports (in particular with the armv6 builds) of missing UFS/MSDOSFS labels, causing the image to fallback to the mountroot prompt. This appears to only happen when the backing md(4) device is destroyed before the calling umount(8) on the target mount, after which the UFS/MSDOSFS label persists. The workaround is this: If EVERYTHINGISFINE is set to non-empty value, check for an existing ufs/rootfs and msdosfs/MSDOSBOOT filesystem label in arm_create_disk(), and rm(1) them if they exist. The EVERYTHINGISFINE variable is chosen because it is used in exactly one other place - release/Makefile.mirrors - and there are big scary warnings at the top of that file as well that it should *not* be used under normal circumstances. This should not destroy a build machine that also uses '/dev/ufs/rootfs' as the UFS label, and I have verified in extensive local testing that the destroyed label is recreated when the md(4) is unmounted/mounted, but this really should not be enabled by anyone. Having said all that, I absolutely *do* plan MFC this to stable/10 for the 10.2-RELEASE cycle, as so far, I have only observed this behavior on stable/10, but this is a temporary solution until I can unravel all of the failure paths to properly trap them. MFC after: 3 days Sponsored by: The FreeBSD Foundation
154 lines
5.2 KiB
Bash
154 lines
5.2 KiB
Bash
#!/bin/sh
|
|
#-
|
|
# Copyright (c) 2015 The FreeBSD Foundation
|
|
# All rights reserved.
|
|
#
|
|
# Portions of this software were developed by Glen Barber
|
|
# under sponsorship from the FreeBSD Foundation.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions
|
|
# are met:
|
|
# 1. Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# 2. Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in the
|
|
# documentation and/or other materials provided with the distribution.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
|
|
# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
# ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
|
|
# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
# OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
# SUCH DAMAGE.
|
|
#
|
|
# Common subroutines used to build arm/armv6 images.
|
|
#
|
|
# $FreeBSD$
|
|
#
|
|
|
|
cleanup() {
|
|
if [ -c "${DESTDIR}/dev/null" ]; then
|
|
umount_loop ${DESTDIR}/dev 2>/dev/null
|
|
fi
|
|
umount_loop ${DESTDIR}
|
|
if [ ! -z "${mddev}" ]; then
|
|
mdconfig -d -u ${mddev}
|
|
fi
|
|
|
|
return 0
|
|
}
|
|
|
|
umount_loop() {
|
|
DIR=$1
|
|
i=0
|
|
sync
|
|
while ! umount ${DIR}; do
|
|
i=$(( $i + 1 ))
|
|
if [ $i -ge 10 ]; then
|
|
# This should never happen. But, it has happened.
|
|
echo "Cannot umount(8) ${DIR}"
|
|
echo "Something has gone horribly wrong."
|
|
return 1
|
|
fi
|
|
sleep 1
|
|
done
|
|
|
|
return 0
|
|
}
|
|
|
|
arm_create_disk() {
|
|
# XXX: This is potentially dangerous, but works around an issue
|
|
# properly labeling md(4) devices when the label already
|
|
# exists.
|
|
# EVERYTHINGISFINE should *never* be set for non-RE use.
|
|
# Trust me. I'm an engineer.
|
|
if [ ! -z "${EVERYTHINGISFINE}" ]; then
|
|
for _label in ufs/rootfs msdosfs/MSDOSBOOT; do
|
|
if [ -e "${CHROOTDIR}/dev/${_label}" ]; then
|
|
rm ${CHROOTDIR}/dev/${_label}
|
|
fi
|
|
done
|
|
fi
|
|
# Create the target raw file and temporary work directory.
|
|
chroot ${CHROOTDIR} gpart create -s ${PART_SCHEME} ${mddev}
|
|
chroot ${CHROOTDIR} gpart add -t '!12' -a 63 -s ${FAT_SIZE} ${mddev}
|
|
chroot ${CHROOTDIR} gpart set -a active -i 1 ${mddev}
|
|
chroot ${CHROOTDIR} newfs_msdos -L msdosboot -F ${FAT_TYPE} /dev/${mddev}s1
|
|
chroot ${CHROOTDIR} gpart add -t freebsd ${mddev}
|
|
chroot ${CHROOTDIR} gpart create -s bsd ${mddev}s2
|
|
chroot ${CHROOTDIR} gpart add -t freebsd-ufs -a 64k /dev/${mddev}s2
|
|
chroot ${CHROOTDIR} newfs -U -L rootfs /dev/${mddev}s2a
|
|
chroot ${CHROOTDIR} tunefs -N enable /dev/${mddev}s2a
|
|
|
|
return 0
|
|
}
|
|
|
|
arm_create_user() {
|
|
# Create a default user account 'freebsd' with the password 'freebsd',
|
|
# and set the default password for the 'root' user to 'root'.
|
|
chroot ${CHROOTDIR} /usr/sbin/pw -R ${DESTDIR} \
|
|
groupadd freebsd -g 1001
|
|
chroot ${CHROOTDIR} mkdir -p ${DESTDIR}/home/freebsd
|
|
chroot ${CHROOTDIR} /usr/sbin/pw -R ${DESTDIR} \
|
|
useradd freebsd \
|
|
-m -M 0755 -w yes -n freebsd -u 1001 -g 1001 -G 0 \
|
|
-c 'FreeBSD User' -d '/home/freebsd' -s '/bin/csh'
|
|
chroot ${CHROOTDIR} /usr/sbin/pw -R ${DESTDIR} \
|
|
usermod root -w yes
|
|
|
|
return 0
|
|
}
|
|
|
|
arm_install_base() {
|
|
chroot ${CHROOTDIR} mount /dev/${mddev}s2a ${DESTDIR}
|
|
eval chroot ${CHROOTDIR} make -C ${WORLDDIR} \
|
|
TARGET=${EMBEDDED_TARGET} \
|
|
TARGET_ARCH=${EMBEDDED_TARGET_ARCH} \
|
|
DESTDIR=${DESTDIR} KERNCONF=${KERNEL} \
|
|
installworld installkernel distribution
|
|
chroot ${CHROOTDIR} mkdir -p ${DESTDIR}/boot/msdos
|
|
|
|
arm_create_user
|
|
|
|
echo '# Custom /etc/fstab for FreeBSD embedded images' \
|
|
> ${CHROOTDIR}/${DESTDIR}/etc/fstab
|
|
echo "/dev/ufs/rootfs / ufs rw 1 1" \
|
|
>> ${CHROOTDIR}/${DESTDIR}/etc/fstab
|
|
echo "/dev/msdosfs/MSDOSBOOT /boot/msdos msdosfs rw,noatime 0 0" \
|
|
>> ${CHROOTDIR}/${DESTDIR}/etc/fstab
|
|
echo "md /tmp mfs rw,noatime,-s30m 0 0" \
|
|
>> ${CHROOTDIR}/${DESTDIR}/etc/fstab
|
|
echo "md /var/log mfs rw,noatime,-s15m 0 0" \
|
|
>> ${CHROOTDIR}/${DESTDIR}/etc/fstab
|
|
echo "md /var/tmp mfs rw,noatime,-s12m 0 0" \
|
|
>> ${CHROOTDIR}/${DESTDIR}/etc/fstab
|
|
|
|
local hostname
|
|
hostname="$(echo ${KERNEL} | tr '[:upper:]' '[:lower:]')"
|
|
echo "hostname=\"${hostname}\"" > ${CHROOTDIR}/${DESTDIR}/etc/rc.conf
|
|
echo 'ifconfig_DEFAULT="DHCP"' >> ${CHROOTDIR}/${DESTDIR}/etc/rc.conf
|
|
echo 'sshd_enable="YES"' >> ${CHROOTDIR}/${DESTDIR}/etc/rc.conf
|
|
echo 'sendmail_enable="NONE"' >> ${CHROOTDIR}/${DESTDIR}/etc/rc.conf
|
|
echo 'sendmail_submit_enable="NO"' >> ${CHROOTDIR}/${DESTDIR}/etc/rc.conf
|
|
echo 'sendmail_outbound_enable="NO"' >> ${CHROOTDIR}/${DESTDIR}/etc/rc.conf
|
|
echo 'sendmail_msp_queue_enable="NO"' >> ${CHROOTDIR}/${DESTDIR}/etc/rc.conf
|
|
echo 'growfs_enable="YES"' >> ${CHROOTDIR}/${DESTDIR}/etc/rc.conf
|
|
|
|
sync
|
|
umount_loop ${CHROOTDIR}/${DESTDIR}
|
|
|
|
return 0
|
|
}
|
|
|
|
arm_install_uboot() {
|
|
# Override in the arm/KERNEL.conf file.
|
|
|
|
return 0
|
|
}
|