freebsd-dev/cmd/zfs
Tobin Harding ced28193b0 Fix coverity defects: 147480, 147584
CID 147480: Logically dead code (DEADCODE)

Remove non-null check and subsequent function call. Add ASSERT to future
proof the code.

usage label is only jumped to before `zhp` is initialized.

CID 147584: Out-of-bounds access (OVERRUN)

Subtract length of current string from buffer length for `size` argument
to `snprintf`.

Starting address for the write is the start of the buffer + the current
string length. We need to subtract this string length else risk a buffer
overflow.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tobin C. Harding <me@tobin.cc>
Closes #6745
2017-10-16 15:32:48 -07:00
..
.gitignore
Makefile.am Add libtpool (thread pools) 2017-08-09 15:31:08 -07:00
zfs_iter.c OpenZFS 6637 - replacing "dontclose" with "should_close" 2017-01-12 11:25:27 -08:00
zfs_iter.h Illumos #2583 2013-11-21 11:13:53 -08:00
zfs_main.c Fix coverity defects: 147480, 147584 2017-10-16 15:32:48 -07:00
zfs_util.h