6a5abb1ee5
O_SEARCH is defined by POSIX [0] to open a directory for searching, skipping permissions checks on the directory itself after the initial open(). This is close to the semantics we've historically applied for O_EXEC on a directory, which is UB according to POSIX. Conveniently, O_SEARCH on a file is also explicitly undefined behavior according to POSIX, so O_EXEC would be a fine choice. The spec goes on to state that O_SEARCH and O_EXEC need not be distinct values, but they're not defined to be the same value. This was pointed out as an incompatibility with other systems that had made its way into libarchive, which had assumed that O_EXEC was an alias for O_SEARCH. This defines compatibility O_SEARCH/FSEARCH (equivalent to O_EXEC and FEXEC respectively) and expands our UB for O_EXEC on a directory. O_EXEC on a directory is checked in vn_open_vnode already, so for completeness we add a NOEXECCHECK when O_SEARCH has been specified on the top-level fd and do not re-check that when descending in namei. [0] https://pubs.opengroup.org/onlinepubs/9699919799/ Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D23247
25 lines
665 B
Makefile
25 lines
665 B
Makefile
# $FreeBSD$
|
|
|
|
NETBSD_ATF_TESTS_C= faccessat_test
|
|
NETBSD_ATF_TESTS_C+= fchmodat_test
|
|
NETBSD_ATF_TESTS_C+= fchownat_test
|
|
NETBSD_ATF_TESTS_C+= fexecve_test
|
|
NETBSD_ATF_TESTS_C+= fstatat_test
|
|
NETBSD_ATF_TESTS_C+= linkat_test
|
|
NETBSD_ATF_TESTS_C+= mkdirat_test
|
|
NETBSD_ATF_TESTS_C+= mkfifoat_test
|
|
NETBSD_ATF_TESTS_C+= mknodat_test
|
|
NETBSD_ATF_TESTS_C+= o_search_test
|
|
NETBSD_ATF_TESTS_C+= openat_test
|
|
NETBSD_ATF_TESTS_C+= readlinkat_test
|
|
NETBSD_ATF_TESTS_C+= renameat_test
|
|
NETBSD_ATF_TESTS_C+= symlinkat_test
|
|
NETBSD_ATF_TESTS_C+= unlinkat_test
|
|
NETBSD_ATF_TESTS_C+= utimensat_test
|
|
|
|
CFLAGS+= -D_INCOMPLETE_XOPEN_C063
|
|
|
|
.include "../Makefile.netbsd-tests"
|
|
|
|
.include <bsd.test.mk>
|