bfcb817bcd
This patch fixes two issues relating to FUSE_ACCESS when the default_permissions mount option is disabled: * VOP_ACCESS() calls with VADMIN set should never be sent to a fuse server in the form of FUSE_ACCESS operations. The FUSE protocol has no equivalent of VADMIN, so we must evaluate such things kernel-side, regardless of the default_permissions setting. * The FUSE protocol only requires FUSE_ACCESS to be sent for two purposes: for the access(2) syscall and to check directory permissions for searchability during lookup. FreeBSD sends it much more frequently, due to differences between our VFS and Linux's, for which FUSE was designed. But this patch does eliminate several cases not required by the FUSE protocol: * for any FUSE_*XATTR operation * when creating a new file * when deleting a file * when setting timestamps, such as by utimensat(2). * Additionally, when default_permissions is disabled, this patch removes one FUSE_GETATTR operation when deleting a file. PR: 245689 Reported by: MooseFS FreeBSD Team <freebsd@moosefs.pro> Reviewed by: cem MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D24777
165 lines
4.7 KiB
C++
165 lines
4.7 KiB
C++
/*-
|
|
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD
|
|
*
|
|
* Copyright (c) 2019 The FreeBSD Foundation
|
|
*
|
|
* This software was developed by BFF Storage Systems, LLC under sponsorship
|
|
* from the FreeBSD Foundation.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*
|
|
* $FreeBSD$
|
|
*/
|
|
|
|
extern "C" {
|
|
#include <fcntl.h>
|
|
#include <semaphore.h>
|
|
}
|
|
|
|
#include "mockfs.hh"
|
|
#include "utils.hh"
|
|
|
|
using namespace testing;
|
|
|
|
class Rmdir: public FuseTest {
|
|
public:
|
|
void expect_lookup(const char *relpath, uint64_t ino, int times=1)
|
|
{
|
|
EXPECT_LOOKUP(FUSE_ROOT_ID, relpath)
|
|
.Times(times)
|
|
.WillRepeatedly(Invoke(ReturnImmediate([=](auto in __unused, auto& out) {
|
|
SET_OUT_HEADER_LEN(out, entry);
|
|
out.body.entry.attr_valid = UINT64_MAX;
|
|
out.body.entry.attr.mode = S_IFDIR | 0755;
|
|
out.body.entry.nodeid = ino;
|
|
out.body.entry.attr.nlink = 2;
|
|
})));
|
|
}
|
|
|
|
void expect_rmdir(uint64_t parent, const char *relpath, int error)
|
|
{
|
|
EXPECT_CALL(*m_mock, process(
|
|
ResultOf([=](auto in) {
|
|
return (in.header.opcode == FUSE_RMDIR &&
|
|
0 == strcmp(relpath, in.body.rmdir) &&
|
|
in.header.nodeid == parent);
|
|
}, Eq(true)),
|
|
_)
|
|
).WillOnce(Invoke(ReturnErrno(error)));
|
|
}
|
|
};
|
|
|
|
/*
|
|
* A successful rmdir should clear the parent directory's attribute cache,
|
|
* because the fuse daemon should update its mtime and ctime
|
|
*/
|
|
TEST_F(Rmdir, parent_attr_cache)
|
|
{
|
|
const char FULLPATH[] = "mountpoint/some_dir";
|
|
const char RELPATH[] = "some_dir";
|
|
struct stat sb;
|
|
sem_t sem;
|
|
uint64_t ino = 42;
|
|
Sequence seq;
|
|
|
|
ASSERT_EQ(0, sem_init(&sem, 0, 0)) << strerror(errno);
|
|
|
|
expect_lookup(RELPATH, ino);
|
|
EXPECT_CALL(*m_mock, process(
|
|
ResultOf([=](auto in) {
|
|
return (in.header.opcode == FUSE_RMDIR &&
|
|
0 == strcmp(RELPATH, in.body.rmdir) &&
|
|
in.header.nodeid == FUSE_ROOT_ID);
|
|
}, Eq(true)),
|
|
_)
|
|
).InSequence(seq)
|
|
.WillOnce(Invoke(ReturnErrno(0)));
|
|
expect_forget(ino, 1, &sem);
|
|
EXPECT_CALL(*m_mock, process(
|
|
ResultOf([=](auto in) {
|
|
return (in.header.opcode == FUSE_GETATTR &&
|
|
in.header.nodeid == FUSE_ROOT_ID);
|
|
}, Eq(true)),
|
|
_)
|
|
).InSequence(seq)
|
|
.WillRepeatedly(Invoke(ReturnImmediate([=](auto i __unused, auto& out) {
|
|
SET_OUT_HEADER_LEN(out, attr);
|
|
out.body.attr.attr.ino = FUSE_ROOT_ID;
|
|
out.body.attr.attr.mode = S_IFDIR | 0755;
|
|
out.body.attr.attr_valid = UINT64_MAX;
|
|
})));
|
|
|
|
ASSERT_EQ(0, rmdir(FULLPATH)) << strerror(errno);
|
|
EXPECT_EQ(0, stat("mountpoint", &sb)) << strerror(errno);
|
|
sem_wait(&sem);
|
|
sem_destroy(&sem);
|
|
}
|
|
|
|
TEST_F(Rmdir, enotempty)
|
|
{
|
|
const char FULLPATH[] = "mountpoint/some_dir";
|
|
const char RELPATH[] = "some_dir";
|
|
uint64_t ino = 42;
|
|
|
|
expect_lookup(RELPATH, ino);
|
|
expect_rmdir(FUSE_ROOT_ID, RELPATH, ENOTEMPTY);
|
|
|
|
ASSERT_NE(0, rmdir(FULLPATH));
|
|
ASSERT_EQ(ENOTEMPTY, errno);
|
|
}
|
|
|
|
/* Removing a directory should expire its entry cache */
|
|
TEST_F(Rmdir, entry_cache)
|
|
{
|
|
const char FULLPATH[] = "mountpoint/some_dir";
|
|
const char RELPATH[] = "some_dir";
|
|
sem_t sem;
|
|
uint64_t ino = 42;
|
|
|
|
expect_lookup(RELPATH, ino, 2);
|
|
expect_rmdir(FUSE_ROOT_ID, RELPATH, 0);
|
|
expect_forget(ino, 1, &sem);
|
|
|
|
ASSERT_EQ(0, rmdir(FULLPATH)) << strerror(errno);
|
|
ASSERT_EQ(0, access(FULLPATH, F_OK)) << strerror(errno);
|
|
sem_wait(&sem);
|
|
sem_destroy(&sem);
|
|
}
|
|
|
|
TEST_F(Rmdir, ok)
|
|
{
|
|
const char FULLPATH[] = "mountpoint/some_dir";
|
|
const char RELPATH[] = "some_dir";
|
|
sem_t sem;
|
|
uint64_t ino = 42;
|
|
|
|
ASSERT_EQ(0, sem_init(&sem, 0, 0)) << strerror(errno);
|
|
|
|
expect_lookup(RELPATH, ino);
|
|
expect_rmdir(FUSE_ROOT_ID, RELPATH, 0);
|
|
expect_forget(ino, 1, &sem);
|
|
|
|
ASSERT_EQ(0, rmdir(FULLPATH)) << strerror(errno);
|
|
sem_wait(&sem);
|
|
sem_destroy(&sem);
|
|
}
|