2019-03-11 22:29:56 +00:00
|
|
|
/*-
|
|
|
|
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD
|
|
|
|
*
|
|
|
|
* Copyright (c) 2019 The FreeBSD Foundation
|
|
|
|
*
|
|
|
|
* This software was developed by BFF Storage Systems, LLC under sponsorship
|
|
|
|
* from the FreeBSD Foundation.
|
|
|
|
*
|
|
|
|
* Redistribution and use in source and binary forms, with or without
|
|
|
|
* modification, are permitted provided that the following conditions
|
|
|
|
* are met:
|
|
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer.
|
|
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
|
|
* documentation and/or other materials provided with the distribution.
|
|
|
|
*
|
|
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
|
|
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
|
|
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
|
|
* SUCH DAMAGE.
|
|
|
|
*/
|
|
|
|
|
|
|
|
extern "C" {
|
|
|
|
#include <aio.h>
|
|
|
|
#include <fcntl.h>
|
|
|
|
#include <unistd.h>
|
|
|
|
}
|
|
|
|
|
|
|
|
#include "mockfs.hh"
|
|
|
|
#include "utils.hh"
|
|
|
|
|
|
|
|
using namespace testing;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* TODO: remove FUSE_FSYNC_FDATASYNC definition when upgrading to protocol 7.28.
|
|
|
|
* This bit was actually part of kernel protocol version 5.2, but never
|
|
|
|
* documented until after 7.28
|
|
|
|
*/
|
|
|
|
#ifndef FUSE_FSYNC_FDATASYNC
|
|
|
|
#define FUSE_FSYNC_FDATASYNC 1
|
|
|
|
#endif
|
|
|
|
|
|
|
|
class Fsync: public FuseTest {
|
|
|
|
public:
|
|
|
|
void expect_fsync(uint64_t ino, uint32_t flags, int error)
|
|
|
|
{
|
|
|
|
EXPECT_CALL(*m_mock, process(
|
|
|
|
ResultOf([=](auto in) {
|
|
|
|
return (in->header.opcode == FUSE_FSYNC &&
|
|
|
|
in->header.nodeid == ino &&
|
|
|
|
in->body.fsync.fh == FH &&
|
|
|
|
in->body.fsync.fsync_flags == flags);
|
|
|
|
}, Eq(true)),
|
|
|
|
_)
|
|
|
|
).WillOnce(Invoke(ReturnErrno(error)));
|
|
|
|
}
|
|
|
|
|
|
|
|
void expect_lookup(const char *relpath, uint64_t ino)
|
|
|
|
{
|
2019-03-15 22:47:20 +00:00
|
|
|
FuseTest::expect_lookup(relpath, ino, S_IFREG | 0644, 0, 1);
|
2019-03-11 22:29:56 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void expect_write(uint64_t ino, uint64_t size, const void *contents)
|
|
|
|
{
|
2019-03-14 00:12:59 +00:00
|
|
|
FuseTest::expect_write(ino, 0, size, size, 0, contents);
|
2019-03-11 22:29:56 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
};
|
|
|
|
|
|
|
|
/* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236379 */
|
|
|
|
/* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236473 */
|
|
|
|
/* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236474 */
|
|
|
|
TEST_F(Fsync, DISABLED_aio_fsync)
|
|
|
|
{
|
|
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
|
|
const char RELPATH[] = "some_file.txt";
|
|
|
|
const char *CONTENTS = "abcdefgh";
|
|
|
|
ssize_t bufsize = strlen(CONTENTS);
|
|
|
|
uint64_t ino = 42;
|
|
|
|
struct aiocb iocb, *piocb;
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
expect_lookup(RELPATH, ino);
|
2019-03-14 00:12:59 +00:00
|
|
|
expect_open(ino, 0, 1);
|
|
|
|
expect_getattr(ino, 0);
|
2019-03-11 22:29:56 +00:00
|
|
|
expect_write(ino, bufsize, CONTENTS);
|
|
|
|
expect_fsync(ino, 0, 0);
|
|
|
|
|
|
|
|
fd = open(FULLPATH, O_RDWR);
|
|
|
|
ASSERT_LE(0, fd) << strerror(errno);
|
|
|
|
ASSERT_EQ(bufsize, write(fd, CONTENTS, bufsize)) << strerror(errno);
|
|
|
|
|
|
|
|
bzero(&iocb, sizeof(iocb));
|
|
|
|
iocb.aio_fildes = fd;
|
|
|
|
|
|
|
|
ASSERT_EQ(0, aio_fsync(O_SYNC, &iocb)) << strerror(errno);
|
|
|
|
ASSERT_EQ(0, aio_waitcomplete(&piocb, NULL)) << strerror(errno);
|
|
|
|
|
|
|
|
/* Deliberately leak fd. close(2) will be tested in release.cc */
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* fuse(4) should NOT fsync during VOP_RELEASE or VOP_INACTIVE
|
|
|
|
*
|
|
|
|
* This test only really make sense in writeback caching mode, but it should
|
|
|
|
* still pass in any cache mode.
|
|
|
|
*/
|
|
|
|
TEST_F(Fsync, close)
|
|
|
|
{
|
|
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
|
|
const char RELPATH[] = "some_file.txt";
|
|
|
|
const char *CONTENTS = "abcdefgh";
|
|
|
|
ssize_t bufsize = strlen(CONTENTS);
|
|
|
|
uint64_t ino = 42;
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
expect_lookup(RELPATH, ino);
|
2019-03-14 00:12:59 +00:00
|
|
|
expect_open(ino, 0, 1);
|
|
|
|
expect_getattr(ino, 0);
|
2019-03-11 22:29:56 +00:00
|
|
|
expect_write(ino, bufsize, CONTENTS);
|
|
|
|
EXPECT_CALL(*m_mock, process(
|
|
|
|
ResultOf([=](auto in) {
|
|
|
|
return (in->header.opcode == FUSE_SETATTR);
|
|
|
|
}, Eq(true)),
|
|
|
|
_)
|
2019-03-15 17:04:33 +00:00
|
|
|
).WillRepeatedly(Invoke(ReturnImmediate([=](auto i __unused, auto out) {
|
2019-03-11 22:29:56 +00:00
|
|
|
SET_OUT_HEADER_LEN(out, attr);
|
|
|
|
out->body.attr.attr.ino = ino; // Must match nodeid
|
2019-03-14 17:20:24 +00:00
|
|
|
})));
|
2019-03-11 22:29:56 +00:00
|
|
|
EXPECT_CALL(*m_mock, process(
|
|
|
|
ResultOf([=](auto in) {
|
|
|
|
return (in->header.opcode == FUSE_FSYNC);
|
|
|
|
}, Eq(true)),
|
|
|
|
_)
|
|
|
|
).Times(0);
|
2019-03-15 16:16:50 +00:00
|
|
|
expect_release(ino, 1, 0, 0);
|
2019-03-11 22:29:56 +00:00
|
|
|
|
|
|
|
fd = open(FULLPATH, O_RDWR);
|
|
|
|
ASSERT_LE(0, fd) << strerror(errno);
|
|
|
|
ASSERT_EQ(bufsize, write(fd, CONTENTS, bufsize)) << strerror(errno);
|
|
|
|
close(fd);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236474 */
|
|
|
|
TEST_F(Fsync, DISABLED_eio)
|
|
|
|
{
|
|
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
|
|
const char RELPATH[] = "some_file.txt";
|
|
|
|
const char *CONTENTS = "abcdefgh";
|
|
|
|
ssize_t bufsize = strlen(CONTENTS);
|
|
|
|
uint64_t ino = 42;
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
expect_lookup(RELPATH, ino);
|
2019-03-14 00:12:59 +00:00
|
|
|
expect_open(ino, 0, 1);
|
|
|
|
expect_getattr(ino, 0);
|
2019-03-11 22:29:56 +00:00
|
|
|
expect_write(ino, bufsize, CONTENTS);
|
|
|
|
expect_fsync(ino, FUSE_FSYNC_FDATASYNC, EIO);
|
|
|
|
|
|
|
|
fd = open(FULLPATH, O_RDWR);
|
|
|
|
ASSERT_LE(0, fd) << strerror(errno);
|
|
|
|
ASSERT_EQ(bufsize, write(fd, CONTENTS, bufsize)) << strerror(errno);
|
|
|
|
ASSERT_NE(0, fdatasync(fd));
|
|
|
|
ASSERT_EQ(EIO, errno);
|
|
|
|
|
|
|
|
/* Deliberately leak fd. close(2) will be tested in release.cc */
|
|
|
|
}
|
|
|
|
|
2019-03-15 18:06:51 +00:00
|
|
|
/*
|
|
|
|
* If the filesystem returns ENOSYS, it will be treated as success and
|
|
|
|
* subsequent calls to VOP_FSYNC will succeed automatically without being sent
|
|
|
|
* to the filesystem daemon
|
|
|
|
*/
|
|
|
|
/* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236474 */
|
|
|
|
/* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236557 */
|
|
|
|
TEST_F(Fsync, DISABLED_enosys)
|
|
|
|
{
|
|
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
|
|
const char RELPATH[] = "some_file.txt";
|
|
|
|
const char *CONTENTS = "abcdefgh";
|
|
|
|
ssize_t bufsize = strlen(CONTENTS);
|
|
|
|
uint64_t ino = 42;
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
expect_lookup(RELPATH, ino);
|
|
|
|
expect_open(ino, 0, 1);
|
|
|
|
expect_getattr(ino, 0);
|
|
|
|
expect_write(ino, bufsize, CONTENTS);
|
|
|
|
expect_fsync(ino, FUSE_FSYNC_FDATASYNC, ENOSYS);
|
|
|
|
|
|
|
|
fd = open(FULLPATH, O_RDWR);
|
|
|
|
ASSERT_LE(0, fd) << strerror(errno);
|
|
|
|
ASSERT_EQ(bufsize, write(fd, CONTENTS, bufsize)) << strerror(errno);
|
|
|
|
EXPECT_EQ(0, fdatasync(fd));
|
|
|
|
|
|
|
|
/* Subsequent calls shouldn't query the daemon*/
|
|
|
|
EXPECT_EQ(0, fdatasync(fd));
|
|
|
|
/* Deliberately leak fd. close(2) will be tested in release.cc */
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2019-03-11 22:29:56 +00:00
|
|
|
/* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236474 */
|
|
|
|
TEST_F(Fsync, DISABLED_fdatasync)
|
|
|
|
{
|
|
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
|
|
const char RELPATH[] = "some_file.txt";
|
|
|
|
const char *CONTENTS = "abcdefgh";
|
|
|
|
ssize_t bufsize = strlen(CONTENTS);
|
|
|
|
uint64_t ino = 42;
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
expect_lookup(RELPATH, ino);
|
2019-03-14 00:12:59 +00:00
|
|
|
expect_open(ino, 0, 1);
|
|
|
|
expect_getattr(ino, 0);
|
2019-03-11 22:29:56 +00:00
|
|
|
expect_write(ino, bufsize, CONTENTS);
|
|
|
|
expect_fsync(ino, FUSE_FSYNC_FDATASYNC, 0);
|
|
|
|
|
|
|
|
fd = open(FULLPATH, O_RDWR);
|
|
|
|
ASSERT_LE(0, fd) << strerror(errno);
|
|
|
|
ASSERT_EQ(bufsize, write(fd, CONTENTS, bufsize)) << strerror(errno);
|
|
|
|
ASSERT_EQ(0, fdatasync(fd)) << strerror(errno);
|
|
|
|
|
|
|
|
/* Deliberately leak fd. close(2) will be tested in release.cc */
|
|
|
|
}
|
|
|
|
|
|
|
|
/* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236473 */
|
|
|
|
/* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236474 */
|
|
|
|
TEST_F(Fsync, DISABLED_fsync)
|
|
|
|
{
|
|
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
|
|
const char RELPATH[] = "some_file.txt";
|
|
|
|
const char *CONTENTS = "abcdefgh";
|
|
|
|
ssize_t bufsize = strlen(CONTENTS);
|
|
|
|
uint64_t ino = 42;
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
expect_lookup(RELPATH, ino);
|
2019-03-14 00:12:59 +00:00
|
|
|
expect_open(ino, 0, 1);
|
|
|
|
expect_getattr(ino, 0);
|
2019-03-11 22:29:56 +00:00
|
|
|
expect_write(ino, bufsize, CONTENTS);
|
|
|
|
expect_fsync(ino, 0, 0);
|
|
|
|
|
|
|
|
fd = open(FULLPATH, O_RDWR);
|
|
|
|
ASSERT_LE(0, fd) << strerror(errno);
|
|
|
|
ASSERT_EQ(bufsize, write(fd, CONTENTS, bufsize)) << strerror(errno);
|
|
|
|
ASSERT_EQ(0, fsync(fd)) << strerror(errno);
|
|
|
|
|
|
|
|
/* Deliberately leak fd. close(2) will be tested in release.cc */
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Fsync should sync a file with dirty metadata but clean data */
|
|
|
|
/* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236473 */
|
|
|
|
/* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236474 */
|
|
|
|
TEST_F(Fsync, DISABLED_fsync_metadata_only)
|
|
|
|
{
|
|
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
|
|
const char RELPATH[] = "some_file.txt";
|
|
|
|
uint64_t ino = 42;
|
|
|
|
int fd;
|
|
|
|
mode_t mode = 0755;
|
|
|
|
|
|
|
|
expect_lookup(RELPATH, ino);
|
2019-03-14 00:12:59 +00:00
|
|
|
expect_open(ino, 0, 1);
|
|
|
|
expect_getattr(ino, 0);
|
2019-03-11 22:29:56 +00:00
|
|
|
EXPECT_CALL(*m_mock, process(
|
|
|
|
ResultOf([=](auto in) {
|
|
|
|
return (in->header.opcode == FUSE_SETATTR);
|
|
|
|
}, Eq(true)),
|
|
|
|
_)
|
2019-03-15 17:04:33 +00:00
|
|
|
).WillOnce(Invoke(ReturnImmediate([=](auto i __unused, auto out) {
|
2019-03-11 22:29:56 +00:00
|
|
|
SET_OUT_HEADER_LEN(out, attr);
|
|
|
|
out->body.attr.attr.ino = ino; // Must match nodeid
|
|
|
|
out->body.attr.attr.mode = S_IFREG | mode;
|
2019-03-14 17:20:24 +00:00
|
|
|
})));
|
2019-03-11 22:29:56 +00:00
|
|
|
|
|
|
|
expect_fsync(ino, 0, 0);
|
|
|
|
|
|
|
|
fd = open(FULLPATH, O_RDWR);
|
|
|
|
ASSERT_LE(0, fd) << strerror(errno);
|
|
|
|
ASSERT_EQ(0, fchmod(fd, mode)) << strerror(errno);
|
|
|
|
ASSERT_EQ(0, fsync(fd)) << strerror(errno);
|
|
|
|
/* Deliberately leak fd. close(2) will be tested in release.cc */
|
|
|
|
}
|
|
|
|
|
|
|
|
// fsync()ing a file that isn't dirty should be a no-op
|
|
|
|
TEST_F(Fsync, nop)
|
|
|
|
{
|
|
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
|
|
const char RELPATH[] = "some_file.txt";
|
|
|
|
uint64_t ino = 42;
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
expect_lookup(RELPATH, ino);
|
2019-03-14 00:12:59 +00:00
|
|
|
expect_open(ino, 0, 1);
|
|
|
|
expect_getattr(ino, 0);
|
2019-03-11 22:29:56 +00:00
|
|
|
|
|
|
|
fd = open(FULLPATH, O_WRONLY);
|
|
|
|
ASSERT_LE(0, fd) << strerror(errno);
|
|
|
|
|
|
|
|
ASSERT_EQ(0, fsync(fd)) << strerror(errno);
|
|
|
|
|
|
|
|
/* Deliberately leak fd. close(2) will be tested in release.cc */
|
|
|
|
}
|
|
|
|
|
2019-03-14 00:12:59 +00:00
|
|
|
// TODO: ENOSYS test
|