d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add warnings, ala mktemp, to tempnam and tmpnam as a reminder that

Browse Source 
these are inherently unsafe interfaces.

Do not allow TMPDIR to override path for setuid/setgid programs.
This commit is contained in:
Warner Losh 1999-08-21 17:56:44 +00:00
parent d00275330d
commit 028aace8e1
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/libc/stdio/tempnam.c
View File

@ -36,7 +36,7 @@
static char sccsid[] = "@(#)tempnam.c 8.1 (Berkeley) 6/4/93";
#endif
static const char rcsid[] =
"$Id$";
"$Id: tempnam.c,v 1.5 1997/02/22 15:02:37 peter Exp $";
#endif /* LIBC_SCCS and not lint */
#include <sys/param.h>
@ -47,6 +47,11 @@ static const char rcsid[] =
#include <unistd.h>
#include <paths.h>
__warn_references(tempnam,
"warning: tempnam() possibly used unsafely; consider using mkstemp()");
extern char *_mktemp __P((char *));
char *
tempnam(dir, pfx)
const char *dir, *pfx;
@ -60,10 +65,10 @@ tempnam(dir, pfx)
if (!pfx)
pfx = "tmp.";
if ((f = getenv("TMPDIR"))) {
if (issetugid() == 0 && (f = getenv("TMPDIR"))) {
(void)snprintf(name, MAXPATHLEN, "%s%s%sXXXXXX", f,
*(f + strlen(f) - 1) == '/'? "": "/", pfx);
if ((f = mktemp(name)))
if ((f = _mktemp(name)))
return(f);
}

5
lib/libc/stdio/tmpnam.c
View File

@ -43,6 +43,11 @@ static char sccsid[] = "@(#)tmpnam.c 8.3 (Berkeley) 3/28/94";
#include <stdio.h>
#include <unistd.h>
__warn_references(tmpnam,
"warning: tmpnam() possibly used unsafely; consider using mkstemp()");
extern char *_mktemp __P((char *));
char *
tmpnam(s)
char *s;