d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

routed: Fix use after free.

Browse Source 
For the multihomed case, ifp be used after being freed. NULL the value
after freeing it and avoid getting into the branch without reassigning
a new value.

CID:		272671
Obtained from:	NetBSD
MFC after:	2 weeks
This commit is contained in:
Pedro F. Giffuni 2016-05-14 23:07:26 +00:00
parent 54811dda50
commit 0b279f8c94
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sbin/routed/if.c
View File

@ -955,6 +955,7 @@ ifinit(void)
(intmax_t)now.tv_sec - (intmax_t)now.tv_sec -
ifp->int_data.ts); ifp->int_data.ts);
ifdel(ifp); ifdel(ifp);
ifp = NULL;
} }
continue; continue;
} }
@ -1151,7 +1152,7 @@ ifinit(void)
/* If we are multi-homed, optionally advertise a route to /* If we are multi-homed, optionally advertise a route to
* our main address. * our main address.
*/ */
if (advertise_mhome if ((advertise_mhome && ifp)
|| (tot_interfaces > 1 || (tot_interfaces > 1
&& mhome && mhome
&& (ifp = ifwithaddr(myaddr, 0, 0)) != NULL && (ifp = ifwithaddr(myaddr, 0, 0)) != NULL