d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Supply default implementation of VOP_RENAME() that does neccessary

Browse Source 
unlocks and unreferences for argument vnodes, as expected by
kern_renameat(9), and returns EOPNOTSUPP. This fixes locks and
reference leaks when rename is attempted on fs that does not
implement rename.

PR:	kern/107439
Based on submission by:	Mikolaj Golub <to.my.trociny gmail com>
Tested by:	Mikolaj Golub
MFC after:	1 week
This commit is contained in:
Konstantin Belousov 2010-04-02 14:03:43 +00:00
parent ea01588095
commit 0bc7bd67ca
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sys/kern/vfs_default.c
View File

@ -67,6 +67,7 @@ __FBSDID("$FreeBSD$");
#include <vm/vnode_pager.h> #include <vm/vnode_pager.h>
static int vop_nolookup(struct vop_lookup_args *); static int vop_nolookup(struct vop_lookup_args *);
static int vop_norename(struct vop_rename_args *);
static int vop_nostrategy(struct vop_strategy_args *); static int vop_nostrategy(struct vop_strategy_args *);
static int get_next_dirent(struct vnode *vp, struct dirent **dpp, static int get_next_dirent(struct vnode *vp, struct dirent **dpp,
char *dirbuf, int dirbuflen, off_t *off, char *dirbuf, int dirbuflen, off_t *off,
@ -113,6 +114,7 @@ struct vop_vector default_vnodeops = {
.vop_poll = vop_nopoll, .vop_poll = vop_nopoll,
.vop_putpages = vop_stdputpages, .vop_putpages = vop_stdputpages,
.vop_readlink = VOP_EINVAL, .vop_readlink = VOP_EINVAL,
.vop_rename = vop_norename,
.vop_revoke = VOP_PANIC, .vop_revoke = VOP_PANIC,
.vop_strategy = vop_nostrategy, .vop_strategy = vop_nostrategy,
.vop_unlock = vop_stdunlock, .vop_unlock = vop_stdunlock,
@ -205,6 +207,20 @@ vop_nolookup(ap)
return (ENOTDIR); return (ENOTDIR);
} }
/*
* vop_norename:
*
* Handle unlock and reference counting for arguments of vop_rename
* for filesystems that do not implement rename operation.
*/
static int
vop_norename(struct vop_rename_args *ap)
{
vop_rename_fail(ap);
return (EOPNOTSUPP);
}
/* /*
* vop_nostrategy: * vop_nostrategy:
* *