d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tcp_hostcache: implement tcp_hc_updatemtu() via tcp_hc_update.

Browse Source 
Locking changes are planned here, and without this change too
much copy-and-paste would be between these two functions.

Reviewed by:	rscheff
This commit is contained in:
Gleb Smirnoff 2021-04-08 14:15:42 -07:00
parent e8b9c508b7
commit 0c25bf7e7c
1 changed files with 5 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
sys/netinet/tcp_hostcache.c
View File

@ -559,37 +559,9 @@ tcp_hc_getmtu(struct in_conninfo *inc)
void
tcp_hc_updatemtu(struct in_conninfo *inc, uint32_t mtu)
{
struct hc_metrics *hc_entry;
struct hc_metrics_lite hcml = { .rmx_mtu = mtu };
if (!V_tcp_use_hostcache)
return;
/*
* Find the right bucket.
*/
hc_entry = tcp_hc_lookup(inc, true);
/*
* If we don't have an existing object, try to insert a new one.
*/
if (hc_entry == NULL) {
hc_entry = tcp_hc_insert(inc);
if (hc_entry == NULL)
return;
}
hc_entry->rmx_mtu = mtu;
/*
* Put it upfront so we find it faster next time.
*/
TAILQ_REMOVE(&hc_entry->rmx_head->hch_bucket, hc_entry, rmx_q);
TAILQ_INSERT_HEAD(&hc_entry->rmx_head->hch_bucket, hc_entry, rmx_q);
/*
* Unlock bucket row.
*/
THC_UNLOCK(&hc_entry->rmx_head->hch_mtx);
return (tcp_hc_update(inc, &hcml));
}
/*
@ -611,6 +583,9 @@ tcp_hc_update(struct in_conninfo *inc, struct hc_metrics_lite *hcml)
return;
}
if (hcml->rmx_mtu != 0) {
hc_entry->rmx_mtu = hcml->rmx_mtu;
}
if (hcml->rmx_rtt != 0) {
if (hc_entry->rmx_rtt == 0)
hc_entry->rmx_rtt = hcml->rmx_rtt;