d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MFC r207484:

Browse Source 
When configuring a system-wide couting PMC, hwpmc was incorrectly logging
 process mappings for that PMC.  Nothing ever reads pmc logs out of a
 counting PMC, so the log buffers were leaked when the PMC was
 deconfigured.  The process mappings are only useful for sampling PMCs
 anyway, so only log the mappings if the PMC is a sampling PMC.

 This bug would cause allocating sample-mode PMCs to fail with ENOMEM
 after allocating several counting-mode PMCs.

Approved by:	emaste (mentor)
This commit is contained in:
Ryan Stone 2010-05-24 18:21:42 +00:00
parent 2a147bb27e
commit 0cd51665f0
1 changed files with 9 additions and 9 deletions

18
sys/dev/hwpmc/hwpmc_mod.c

@ -2675,16 +2675,16 @@ pmc_start(struct pmc *pm)
PMCDBG(PMC,OPS,1, "po=%p in global list", po);
}
po->po_sscount++;
}
/*
* Log mapping information for all existing processes in the
* system. Subsequent mappings are logged as they happen;
* see pmc_process_mmap().
*/
if (po->po_logprocmaps == 0) {
pmc_log_all_process_mappings(po);
po->po_logprocmaps = 1;
/*
* Log mapping information for all existing processes in the
* system. Subsequent mappings are logged as they happen;
* see pmc_process_mmap().
*/
if (po->po_logprocmaps == 0) {
pmc_log_all_process_mappings(po);
po->po_logprocmaps = 1;
}
}
/*