d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

In icmp_reflect(): If the packet was not addressed to us and was

Browse Source 
received on an interface without an IP address, try to find a
non-loopback AF_INET address to use.  If that fails, drop it.
Previously, we used the address at the top of the in_ifaddrhead list,
which didn't make much sense, and would cause a panic if there were no
AF_INET addresses configured on the system.

PR:		29337, 30524
Reviewed by:	ru, jlemon
Obtained from:	NetBSD
This commit is contained in:
Dima Dorfman 2001-11-27 19:58:09 +00:00
parent 19d2c78f34
commit 0d4bef5dd4
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
sys/netinet/ip_icmp.c
View File

@ -623,10 +623,23 @@ icmp_reflect(m)
(struct sockaddr *)&icmpdst, m->m_pkthdr.rcvif);
/*
* The following happens if the packet was not addressed to us,
* and was received on an interface with no IP address.
* and was received on an interface with no IP address:
* We find the first AF_INET address on the first non-loopback
* interface.
*/
if (ia == NULL)
ia = TAILQ_FIRST(&in_ifaddrhead);
TAILQ_FOREACH(ia, &in_ifaddrhead, ia_link)
if ((ia->ia_ifp->if_flags & IFF_LOOPBACK) == 0)
break;
/*
* If we still didn't find an address, punt. We could have an
* interface up and (and receiving packets) with no address.
*/
if (ia == NULL) {
m_freem(m);
goto done;
}
match:
t = IA_SIN(ia)->sin_addr;
ip->ip_src = t;