d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- Correct a long-standing race condition in vm_page_try_to_free() that

Browse Source 
could result in a dirty page being unintentionally freed.
 - Simplify the dirty page check in vm_page_dontneed().

Reviewed by:	tegge
MFC after:	7 days
This commit is contained in:
Alan Cox 2004-02-19 07:43:55 +00:00
parent 3c8e9ebafb
commit 0f75a97722
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/vm/vm_page.c
View File

@ -1316,11 +1316,10 @@ vm_page_try_to_free(vm_page_t m)
(m->flags & (PG_BUSY|PG_UNMANAGED))) {
return (0);
}
vm_page_test_dirty(m);
pmap_remove_all(m);
if (m->dirty)
return (0);
vm_page_busy(m);
pmap_remove_all(m);
vm_page_free(m);
return (1);
}
@ -1405,8 +1404,8 @@ vm_page_dontneed(vm_page_t m)
return;
}
if (m->dirty == 0)
vm_page_test_dirty(m);
if (m->dirty == 0 && pmap_is_modified(m))
vm_page_dirty(m);
if (m->dirty || (dnw & 0x0070) == 0) {
/*