d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tftp: fix two minor Coverity CIDs

Browse Source 
Reported by:	Coverity
CID 1394842: file descriptor leak in an error path
CID 1007603: single byte array overflow
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D21695
This commit is contained in:
Alan Somers 2019-10-03 20:22:25 +00:00
parent fa0e0c0269
commit 123d18b5c7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
usr.bin/tftp/main.c
View File

@ -491,6 +491,7 @@ put(int argc, char *argv[])
if (fstat(fd, &sb) < 0) { if (fstat(fd, &sb) < 0) {
warn("%s", cp); warn("%s", cp);
close(fd);
return; return;
} }
asprintf(&options[OPT_TSIZE].o_request, "%ju", sb.st_size); asprintf(&options[OPT_TSIZE].o_request, "%ju", sb.st_size);
@ -746,7 +747,7 @@ command(bool interactive, EditLine *el, History *hist, HistEvent *hep)
exit(0); exit(0);
len = MIN(MAXLINE, num); len = MIN(MAXLINE, num);
memcpy(line, bp, len); memcpy(line, bp, len);
line[len] = '\0'; line[len - 1] = '\0';
history(hist, hep, H_ENTER, bp); history(hist, hep, H_ENTER, bp);
} else { } else {
line[0] = 0; line[0] = 0;