d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ada: Move comment

Browse Source 
Move the comment about releasing ccb before periph to adaprobedone()
where it belongs.

Sponsored by:		Netflix
This commit is contained in:
Warner Losh 2022-05-04 16:53:03 -06:00
parent ef4edb70c9
commit 1907e1c07c
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
sys/cam/ata/ata_da.c
View File

@ -2691,6 +2691,12 @@ adaprobedone(struct cam_periph *periph, union ccb *ccb)
softc = (struct ada_softc *)periph->softc;
/*
* Since our peripheral may be invalidated by an error we must release
* our CCB before releasing the reference on the peripheral. The
* peripheral will only go away once the last reference is removed, and
* we need it around for the CCB release operation.
*/
if (ccb != NULL)
xpt_release_ccb(ccb);
@ -2987,15 +2993,6 @@ adadone(struct cam_periph *periph, union ccb *done_ccb)
}
}
/*
* Since our peripheral may be invalidated by an error
* above or an external event, we must release our CCB
* before releasing the reference on the peripheral.
* The peripheral will only go away once the last reference
* is removed, and we need it around for the CCB release
* operation.
*/
xpt_release_ccb(done_ccb);
softc->state = ADA_STATE_WCACHE;
xpt_schedule(periph, priority);