d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify devfs_fsync() by removing it. This might also be a minor

Browse Source 
optimization, as vn_isdisk() needs to lock a global mutex.

Reviewed by:	imp
Tested by:	pho
MFC after:	2 weeks
Sponsored by:	DARPA, AFRL
Differential Revision:	https://reviews.freebsd.org/D9628
This commit is contained in:
Edward Tomasz Napierala 2017-02-20 16:18:33 +00:00
parent 5a49cd0099
commit 1a2dbd1aa3
1 changed files with 1 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
sys/fs/devfs/devfs_vnops.c
View File

@ -676,32 +676,6 @@ devfs_close_f(struct file *fp, struct thread *td)
return (error);
}
static int
devfs_fsync(struct vop_fsync_args *ap)
{
int error;
struct bufobj *bo;
struct devfs_dirent *de;
if (!vn_isdisk(ap->a_vp, &error)) {
bo = &ap->a_vp->v_bufobj;
de = ap->a_vp->v_data;
if (error == ENXIO && bo->bo_dirty.bv_cnt > 0) {
printf("Device %s went missing before all of the data "
"could be written to it; expect data loss.\n",
de->de_dirent->d_name);
error = vop_stdfsync(ap);
if (bo->bo_dirty.bv_cnt != 0 || error != 0)
printf("devfs_fsync: vop_stdfsync failed.");
}
return (0);
}
return (vop_stdfsync(ap));
}
static int
devfs_getattr(struct vop_getattr_args *ap)
{
@ -1912,7 +1886,7 @@ static struct vop_vector devfs_specops = {
.vop_bmap = VOP_PANIC,
.vop_close = devfs_close,
.vop_create = VOP_PANIC,
.vop_fsync = devfs_fsync,
.vop_fsync = vop_stdfsync,
.vop_getattr = devfs_getattr,
.vop_ioctl = devfs_ioctl,
.vop_link = VOP_PANIC,