d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ipfilter: Remove unused ioctl

Browse Source 
The SIOCSTAT1 ioctl is only used in ip_auth and is unused in ip_state.
The ip_state version was likely added to support a new statistic yet
to be developed in ipfstat(8) or for some sample userspace application
(similar in fashion to the sample provided for authentication rules).
There is no need to report individual state hash table bucket lengths
to any future userspace application.

If needed for any future debugging purposes a DTrace probe would be a
better vehicle.

This unused ioctl in ip_stat results in a panic.

PR:		266124
Reported by:	Robert Morris <rtm@lcs.mit.edu>
MFC after:	3 days
This commit is contained in:
Cy Schubert 2022-09-06 13:58:35 -07:00
parent 3e81ef62f9
commit 1f7a710ab3
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/netpfil/ipfilter/netinet/ip_state.c
View File

@ -751,18 +751,6 @@ ipf_state_ioctl(ipf_main_softc_t *softc, caddr_t data, ioctlcmd_t cmd,
error = ipf_state_getent(softc, softs, data);
break;
/*
* Return a copy of the hash table bucket lengths
*/
case SIOCSTAT1 :
error = BCOPYOUT(softs->ipf_state_stats.iss_bucketlen, data,
softs->ipf_state_size * sizeof(u_int));
if (error != 0) {
IPFERROR(100017);
error = EFAULT;
}
break;
case SIOCGENITER :
{
ipftoken_t *token;