d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pci_dw: Drop unconditional explicit DEBUG define

Browse Source 
This has been present since the first revision of the file. The debugf
macros have always been unused so it doesn't actually do anything
useful, and besides, debugging should not be unconditionally turned on
for a production driver. Moreover, this breaks the riscv LINT kernel
build as sys/conf/NOTES includes options DEBUG, resulting in a macro
redefinition error. This does not show up in the arm64 LINT kernel build
since that has an explicit nooptions DEBUG, which is dubious and should
be revisited. Rather than copy such a hack to riscv's NOTES, fix this
specific instance of DEBUG breaking.

Fixes:		896e217a0eae ("fu740_pci_dw: Add SiFive FU740 PCIe controller driver")
MFC after:	1 week
This commit is contained in:
Jessica Clarke 2021-08-07 21:25:36 +01:00
parent 5668a155cb
commit 22997b7550
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sys/dev/pci/pci_dw.c
View File

@ -59,7 +59,6 @@ __FBSDID("$FreeBSD$");
#include "pcib_if.h"
#include "pci_dw_if.h"
#define DEBUG
#ifdef DEBUG
#define debugf(fmt, args...) do { printf(fmt,##args); } while (0)
#else