d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Silence a coverity warning about ignoring a return value. We do, but

Browse Source 
we also know that it "can't fail" given the single-threaded nature of
device enumeration. Go ahead and check it just in case, but add a
comment.

CID: 1009393
Sponsored by: Netflix, Inc
This commit is contained in:
Warner Losh 2015-02-03 18:59:52 +00:00
parent 6b31e1302f
commit 234530168a
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
sys/dev/fe/if_fe_isa.c
View File

@ -133,10 +133,21 @@ static int
fe_isa_attach(device_t dev)
{
struct fe_softc *sc = device_get_softc(dev);
int error = 0;
if (sc->port_used)
fe_alloc_port(dev, sc->port_used);
fe_alloc_irq(dev, 0);
/*
* Note: these routines aren't expected to fail since we also call
* them in the probe routine. But coverity complains, so we'll honor
* that complaint since the intention here was never to ignore them..
*/
if (sc->port_used) {
error = fe_alloc_port(dev, sc->port_used);
if (error != 0)
return (error);
}
error = fe_alloc_irq(dev, 0);
if (error != 0)
return (error);
return fe_attach(dev);
}