d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

netstat: fix double-free in netlink error code path.

Browse Source 
CID:	1504382
This commit is contained in:
Alexander V. Chernikov 2023-03-18 14:01:46 +00:00 committed by Oscar Zhao
parent a10ee27528
commit 268629fefc
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
usr.bin/netstat/route_netlink.c
View File

@ -91,10 +91,8 @@ prepare_ifmap_netlink(struct snl_state *ss, size_t *pifmap_size)
};
msg.hdr.nlmsg_len = sizeof(msg);
if (!snl_send_message(ss, &msg.hdr)) {
snl_free(ss);
if (!snl_send_message(ss, &msg.hdr))
return (NULL);
}
struct ifmap_entry *ifmap = NULL;
uint32_t ifmap_size = 0;
@ -286,6 +284,10 @@ p_rtable_netlink(int fibnum, int af)
return (false);
ifmap = prepare_ifmap_netlink(&ss, &ifmap_size);
if (ifmap == NULL) {
snl_free(&ss);
return (false);
}
struct {
struct nlmsghdr hdr;