From 2c1e6cce5b7d0ce74f385b99386d91fdd47b9782 Mon Sep 17 00:00:00 2001 From: Rick Macklem Date: Sat, 20 Jun 2009 00:54:57 +0000 Subject: [PATCH] Change the size of the nfsc_groups[] array in the experimental nfs client to RPCAUTH_UNIXGIDS + 1 (17), since that is what can go on the wire for AUTH_SYS authentication. Reviewed by: brooks Approved by: kib (mentor) --- sys/fs/nfs/nfs.h | 8 ++++---- sys/fs/nfsclient/nfs_clport.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/fs/nfs/nfs.h b/sys/fs/nfs/nfs.h index 0160af2a1894..d02c754134c8 100644 --- a/sys/fs/nfs/nfs.h +++ b/sys/fs/nfs/nfs.h @@ -404,13 +404,13 @@ typedef struct { (b)->bits[1] = NFSATTRBIT_REFERRAL1; } while (0) /* - * Store uid, gid creds that handle maps to. - * Since some BSDen define cr_gid as cr_groups[0], I'll just keep them - * all in nfsc_groups[NGROUPS + 1]. + * Store uid, gid creds that were used when the stateid was acquired. + * The RPC layer allows RPCAUTH_UNIXGIDS + 1 groups to go out on the wire, + * so that's how many gets stored here. */ struct nfscred { uid_t nfsc_uid; - gid_t nfsc_groups[NGROUPS + 1]; + gid_t nfsc_groups[RPCAUTH_UNIXGIDS + 1]; int nfsc_ngroups; }; diff --git a/sys/fs/nfsclient/nfs_clport.c b/sys/fs/nfsclient/nfs_clport.c index 5b747c7e3dae..6453bcf7afb6 100644 --- a/sys/fs/nfsclient/nfs_clport.c +++ b/sys/fs/nfsclient/nfs_clport.c @@ -979,7 +979,7 @@ newnfs_copyincred(struct ucred *cr, struct nfscred *nfscr) int i; nfscr->nfsc_uid = cr->cr_uid; - nfscr->nfsc_ngroups = MIN(cr->cr_ngroups, XU_NGROUPS); + nfscr->nfsc_ngroups = MIN(cr->cr_ngroups, RPCAUTH_UNIXGIDS + 1); for (i = 0; i < nfscr->nfsc_ngroups; i++) nfscr->nfsc_groups[i] = cr->cr_groups[i]; }