d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mlx5en: Add missing error case when creating VXLAN flow tables.

Browse Source 
While at it remove redundant checks for IFCAP_VXLAN_HWCSUM flag.

MFC after:	1 week
Reviewed by:	kib
Sponsored by:	Mellanox Technologies // NVIDIA Networking
This commit is contained in:
Hans Petter Selasky 2021-06-16 15:01:27 +02:00 committed by Konstantin Belousov
parent 1918b253d3
commit 2f7ce2326f
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c
View File

@ -2252,34 +2252,28 @@ mlx5e_open_flow_table(struct mlx5e_priv *priv)
err = mlx5e_create_main_flow_table(priv, true);
if (err)
goto err_destroy_main_flow_table;
}
if ((priv->ifp->if_capenable & IFCAP_VXLAN_HWCSUM) != 0) {
err = mlx5e_create_inner_rss_flow_table(priv);
if (err)
goto err_destroy_main_vxlan_flow_table;
}
if ((priv->ifp->if_capenable & IFCAP_VXLAN_HWCSUM) != 0) {
err = mlx5e_add_vxlan_catchall_rule(priv);
if (err != 0)
goto err_destroy_inner_rss_flow_table;
}
if ((priv->ifp->if_capenable & IFCAP_VXLAN_HWCSUM) != 0) {
err = mlx5e_add_main_vxlan_rules(priv);
if (err != 0)
goto err_destroy_inner_rss_flow_table;
goto err_destroy_vxlan_catchall_rule;
}
return (0);
err_destroy_vxlan_catchall_rule:
mlx5e_del_vxlan_catchall_rule(priv);
err_destroy_inner_rss_flow_table:
if ((priv->ifp->if_capenable & IFCAP_VXLAN_HWCSUM) != 0)
mlx5e_destroy_inner_rss_flow_table(priv);
mlx5e_destroy_inner_rss_flow_table(priv);
err_destroy_main_vxlan_flow_table:
if ((priv->ifp->if_capenable & IFCAP_VXLAN_HWCSUM) != 0)
mlx5e_destroy_main_vxlan_flow_table(priv);
mlx5e_destroy_main_vxlan_flow_table(priv);
err_destroy_main_flow_table:
mlx5e_destroy_main_flow_table(priv);
err_destroy_vxlan_flow_table: